hw/audio/virtio-snd: Remove unused assignment
PATCH 1/1 hw/audio/virtio-snd: Remove unused assignment
Coverity reported:
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
CID 1542933: Code maintainability issues (UNUSED_VALUE) CID 1542934: Code maintainability issues (UNUSED_VALUE)Assigning value "NULL" to "stream" here, but that stored
value is overwritten before it can be used.
Simply remove the unused assignments.
Resolves: Coverity CID 1542933
Resolves: Coverity CID 1542934
Fixes 731655f87f ("virtio-snd: rewrite invalid tx/rx message handling")
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
--- hw/audio/virtio-snd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
hw/audio/virtio-snd.c +6 -2
@@ -885,7 +885,9 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq) }trace_virtio_snd_handle_tx_xfer (); -for (VirtIOSoundPCMStream *stream =NULL ;; stream =NULL ) { +for (;;) { +VirtIOSoundPCMStream *stream; + elem =virtqueue_pop (vq,sizeof (VirtQueueElement));if (!elem) {break ;
@@ -964,7 +966,9 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq) }trace_virtio_snd_handle_rx_xfer (); -for (VirtIOSoundPCMStream *stream =NULL ;; stream =NULL ) { +for (;;) { +VirtIOSoundPCMStream *stream; + elem =virtqueue_pop (vq,sizeof (VirtQueueElement));if (!elem) {break ;
Signature · 1 line
2.41.0
Quoted 9 lines · Philippe Mathieu-Daudé
Coverity reported:
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
CID 1542933: Code maintainability issues (UNUSED_VALUE) CID 1542934: Code maintainability issues (UNUSED_VALUE)Assigning value "NULL" to "stream" here, but that stored
value is overwritten before it can be used.
Simply remove the unused assignments.
Quoted 7 lines
Resolves: Coverity CID 1542933
Resolves: Coverity CID 1542934Fixes 731655f87f ("virtio-snd: rewrite invalid tx/rx message handling")Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- hw/audio/virtio-snd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Per IRC:
Reviewed-by Manos Pitsidianakis <[email protected]>
Thanks, queued.