Skip to contentSkip to conversation

gpio: pcie-idio-24: Use -ENOTSUPP consistently

PATCH Applied Andy Shevchenko 4 participants 4 messages Apr 10, 2024 – Apr 12, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: pcie-idio-24: Use -ENOTSUPP consistently

The GPIO library expects the drivers to return -ENOTSUPP in some cases and not using analogue POSIX code. Make the driver to follow this.

---
 drivers/gpio/gpio-pcie-idio-24.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-pcie-idio-24.c +1 -1
index 2efd1b1a0805f..7f7f95ad4343d 100644
@@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
 	case IDIO_24_CONTROL_REG:
 		/* We can only set direction for TTL/CMOS lines */
 		if (offset < 48)
-			return -EOPNOTSUPP;
+			return -ENOTSUPP;
 
 		*reg = IDIO_24_CONTROL_REG;
 		*mask = CONTROL_REG_OUT_MODE;
Signature · 1 line
2.44.0
#3 lore raw
In reply to Andy Shevchenko
Quoted 23 lines · Andy Shevchenko

The GPIO library expects the drivers to return -ENOTSUPP in some cases and not using analogue POSIX code. Make the driver to follow this.

---
 drivers/gpio/gpio-pcie-idio-24.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-pcie-idio-24.c +1 -2
index 2efd1b1a0805f..7f7f95ad4343d 100644
@@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
        case IDIO_24_CONTROL_REG:
                /* We can only set direction for TTL/CMOS lines */
                if (offset < 48)
-                       return -EOPNOTSUPP;
+                       return -ENOTSUPP;
 
                *reg = IDIO_24_CONTROL_REG;
                *mask = CONTROL_REG_OUT_MODE;
--
Quoted 2 lines

2.44.0

Applied, thanks!

Bart