gpio: pcie-idio-24: Use -ENOTSUPP consistently
Subsystems (2)
PATCH 1/1 gpio: pcie-idio-24: Use -ENOTSUPP consistently
The GPIO library expects the drivers to return -ENOTSUPP in some cases and not using analogue POSIX code. Make the driver to follow this.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/gpio/gpio-pcie-idio-24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-pcie-idio-24.c +1 -1
@@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsignedcase IDIO_24_CONTROL_REG :/* We can only set direction for TTL/CMOS lines */ if (offset <48 ) -return -EOPNOTSUPP ; +return -ENOTSUPP ; *reg =IDIO_24_CONTROL_REG ; *mask =CONTROL_REG_OUT_MODE ;
Signature · 1 line
2.44.0
Quoted 4 lines · Andy Shevchenko
The GPIO library expects the drivers to return
-ENOTSUPPin some cases and not using analogue POSIX code. Make the driver to follow this.Signed-off-by Andy Shevchenko <[email protected]>
Quoted 4 lines · Andy Shevchenko
The GPIO library expects the drivers to return
-ENOTSUPPin some cases and not using analogue POSIX code. Make the driver to follow this.Signed-off-by Andy Shevchenko <[email protected]>
Reviewed-by Linus Walleij <[email protected]>
Yours,
Linus Walleij
Bartosz Golaszewski
AppliedQuoted 23 lines · Andy Shevchenko
The GPIO library expects the drivers to return
-ENOTSUPPin some cases and not using analogue POSIX code. Make the driver to follow this.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/gpio/gpio-pcie-idio-24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpio/gpio-pcie-idio-24.c +1
-2@@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsignedcase IDIO_24_CONTROL_REG :/* We can only set direction for TTL/CMOS lines */ if (offset <48 ) -return -EOPNOTSUPP ; +return -ENOTSUPP ; *reg =IDIO_24_CONTROL_REG ; *mask =CONTROL_REG_OUT_MODE ; --
Quoted 2 lines
2.44.0
Applied, thanks!
Bart