Skip to contentSkip to conversation

efi_loader: using EFI_UNSUPPORTED for private authenticated variables

PATCH In review Weizhao Ouyang 3 participants 3 messages Apr 10, 2024 – Apr 11, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi_loader: using EFI_UNSUPPORTED for private authenticated variables

Improve error message for UEFI SCT tests.

---
 lib/efi_loader/efi_variable.c | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/efi_variable.c +1 -0
index 2951dc78c7..e6c1219a11 100644
@@ -163,6 +163,7 @@ static efi_status_t efi_variable_authenticate(const u16 *variable,
 		break;
 	default:
 		/* TODO: support private authenticated variables */
+		ret = EFI_UNSUPPORTED;
 		goto err;
 	}
 
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Weizhao Ouyang

Improve error message for UEFI SCT tests.

---
  lib/efi_loader/efi_variable.c | 1 +
  1 file changed, 1 insertion(+)
lib/efi_loader/efi_variable.c +0 -0
index 2951dc78c7..e6c1219a11 100644

lib/efi_loader/efi_variable.c static efi_status_t efi_variable_authenticate(const u16 *variable, · line 166

Quoted 4 lines
lib/efi_loader/efi_variable.c +1 -0
@@ -163,6 +163,7 @@ static efi_status_t efi_variable_authenticate(const u16 *variable,
  		break;
  	default:
  		/* TODO: support private authenticated variables */
+		ret = EFI_UNSUPPORTED;

This looks more adequate than EFI_SECURITY_VIOLATION. Thanks.

Quoted 3 lines
lib/efi_loader/efi_variable.c +0 -0
  		goto err;
  	}
 
Reviewed-by
#2 lore raw
Quoted 21 lines · Heinrich Schuchardt
Quoted 12 lines · Weizhao Ouyang

Improve error message for UEFI SCT tests.

---
  lib/efi_loader/efi_variable.c | 1 +
  1 file changed, 1 insertion(+)
lib/efi_loader/efi_variable.c +0 -0
index 2951dc78c7..e6c1219a11 100644

lib/efi_loader/efi_variable.c static efi_status_t efi_variable_authenticate(const u16 *variable, · line 166

Quoted 4 lines
lib/efi_loader/efi_variable.c +1 -0
@@ -163,6 +163,7 @@ static efi_status_t efi_variable_authenticate(const u16 *variable,
              break;
      default:
              /* TODO: support private authenticated variables */
+             ret = EFI_UNSUPPORTED;

This looks more adequate than EFI_SECURITY_VIOLATION. Thanks.

Quoted 6 lines
Quoted 3 lines
lib/efi_loader/efi_variable.c +0 -0
              goto err;
      }