Add features, fixes and laptops for CS35L41 HDA
Subsystems (3)
cover Add features, fixes and laptops for CS35L41 HDA
This chain adds a number of improvements for CS35L41, including a new firmware loading feature, as well as some additional cleanup.
Patch 1 adds support for a new firmware tuning file which is used to set special tuning parameters used by the firmware. The HP Omen laptop added in patches 2 and 3 use such a feature.
Patch 4 changes the DSP1RX5/6 Source used by the firmware to depend on the boost type. A similar change in the ASoC driver will be needed later.
Patches 5 and 6 are cleanup patches, with the first of those re-using cs-amp-lib for calibration which as added for CS35L56 drivers, ensuring that all laptops are using the correct calibration values.
Patch 7 fixes a small error in the CS35L41 Property table for the Lenovo Legion slim 7 16ARHA7.
Richard Fitzgerald (1):
ALSA: hda: cs35l41: Remove redundant argument to
cs35l41_request_firmware_file()
Stefan Binding (6):
ALSA: hda: cs35l41: Set the max PCM Gain using tuning setting
ALSA: hda: cs35l41: Support HP Omen models without _DSD
ALSA: hda/realtek: Add quirks for HP Omen models using CS35L41
ALSA: hda: cs35l41: Update DSP1RX5/6 Sources for DSP config
ALSA: hda: cs35l41: Use shared cs-amp-lib to apply calibration
ALSA: hda: cs35l41: Remove Speaker ID for Lenovo Legion slim 7 16ARHA7
include/sound/cs35l41.h | 5 + sound/pci/hda/Kconfig | 2 + sound/pci/hda/cs35l41_hda.c | 347 +++++++++++++++++++-------- sound/pci/hda/cs35l41_hda.h | 6 + sound/pci/hda/cs35l41_hda_property.c | 8 +- sound/pci/hda/patch_realtek.c | 4 + 6 files changed, 265 insertions(+), 107 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/7 ALSA: hda: cs35l41: Set the max PCM Gain using tuning setting
Some systems requires different max PCM Gains settings than the default. The current default value, when running firmware is 17.5 dB, which is used for all systems. Some systems require lower values. Value when running without firmware is 4.5 dB and remains unchanged.
Since the gain value is dependent on Tuning and Firmware, it can change, so it cannot be saved in _DSD. Instead we can store it inside a configuration binary file alongside the Firmware and Tuning files.
The gain value increments in steps of 1 dB, with value 0 representing 0.5 dB. The max value is 20, which corresponds to 20.5 dB.
--- include/sound/cs35l41.h | 5 ++ sound/pci/hda/cs35l41_hda.c | 170 +++++++++++++++++++++++++++++++++--- sound/pci/hda/cs35l41_hda.h | 3 + 3 files changed, 167 insertions(+), 11 deletions(-)
include/sound/cs35l41.h +5 -0
@@ -554,6 +554,11 @@#define CS35L41_LRCLK_FRC_SHIFT 1#define CS35L41_AMP_GAIN_PCM_MASK 0x3E0 +#define CS35L41_AMP_GAIN_PCM_SHIFT 5 +#define CS35L41_AMP_GAIN_PDM_MASK 0x1F +#define CS35L41_AMP_GAIN_PDM_SHIFT 0 +#define CS35L41_AMP_GAIN_PCM_MAX 20 +#define CS35L41_AMP_GAIN_PDM_MAX 20#define CS35L41_AMP_GAIN_ZC_MASK 0x0400#define CS35L41_AMP_GAIN_ZC_SHIFT 10
sound/pci/hda/cs35l41_hda.c +159 -11
241 lines not on this page · raw message
sound/pci/hda/cs35l41_hda.h +3 -0
@@ -21,6 +21,8 @@#include <linux/firmware/cirrus/wmfw.h> #define CS35L41_MAX_ACCEPTABLE_SPI_SPEED_HZ 1000000 +#define DEFAULT_AMP_GAIN_PCM 17/* 17.5dB Gain */ +#define DEFAULT_AMP_GAIN_PDM 19/* 19.5dB Gain */ struct cs35l41_amp_cal_data {u32 calTarget[2 ];
@@ -83,6 +85,7 @@ struct cs35l41_hda {bool mute_override;enum control_bus control_bus;bool bypass_fw; +unsigned int tuning_gain; };
Signature · 1 line
2.34.1
kernel test robot
build botRe: [PATCH v1 1/7] ALSA: hda: cs35l41: Set the max PCM Gain using tuning setting
kernel test robot noticed the following build warnings:
Hi Stefan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on tiwai-sound/for-linus linus/master v6.9-rc3 next-20240410] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Binding/ALSA-hda-cs35l41-Set-the-max-PCM-Gain-using-tuning-setting/20240410-235446 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20240410155223.7164-2-sbinding%40opensource.cirrus.com patch subject: [PATCH v1 1/7] ALSA: hda: cs35l41: Set the max PCM Gain using tuning setting config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240411/[email protected]/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240411/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/acpi.h:14,
from sound/pci/hda/cs35l41_hda.c:9:
sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_read_tuning_params':
>> sound/pci/hda/cs35l41_hda.c:511:39: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
511 | dev_err(cs35l41->dev, "Wrong Size for Tuning Param file. Expected %d got %ld\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/pci/hda/cs35l41_hda.c:511:17: note: in expansion of macro 'dev_err'
511 | dev_err(cs35l41->dev, "Wrong Size for Tuning Param file. Expected %d got %ld\n",
| ^~~~~~~
sound/pci/hda/cs35l41_hda.c:511:92: note: format string is defined here
511 | dev_err(cs35l41->dev, "Wrong Size for Tuning Param file. Expected %d got %ld\n",
| ~~^
| |
| long int
| %d
In file included from include/linux/printk.h:566,
from include/asm-generic/bug.h:22,
from arch/x86/include/asm/bug.h:87,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/linux/spinlock.h:60,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/slab.h:16,
from include/linux/resource_ext.h:11,
from include/linux/acpi.h:13:
sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_load_tuning_params':
sound/pci/hda/cs35l41_hda.c:565:39: warning: '%s' directive argument is null [-Wformat-overflow=]
565 | dev_dbg(cs35l41->dev, "Missing Tuning Param File: %s: %d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
273 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/pci/hda/cs35l41_hda.c:565:17: note: in expansion of macro 'dev_dbg'
565 | dev_dbg(cs35l41->dev, "Missing Tuning Param File: %s: %d\n",
| ^~~~~~~
sound/pci/hda/cs35l41_hda.c:565:67: note: format string is defined here
565 | dev_dbg(cs35l41->dev, "Missing Tuning Param File: %s: %d\n",
| ^~vim +511 sound/pci/hda/cs35l41_hda.c
500
501 static int cs35l41_read_tuning_params(struct cs35l41_hda *cs35l41, const struct firmware *firmware)
502 {
503 struct cs35l41_tuning_params *params;
504 unsigned int offset = 0;
505 unsigned int end;
506 int i;
507
508 params = (void *)&firmware->data[0];
509
510 if (le32_to_cpu(params->size) != firmware->size) {
> 511 dev_err(cs35l41->dev, "Wrong Size for Tuning Param file. Expected %d got %ld\n",
512 le32_to_cpu(params->size), firmware->size);
513 return -EINVAL;
514 }
515
516 if (le32_to_cpu(params->version) != 1) {
517 dev_err(cs35l41->dev, "Unsupported Tuning Param Version: %d\n",
518 le32_to_cpu(params->version));
519 return -EINVAL;
520 }
521
522 if (le32_to_cpu(params->signature) != CS35L41_TUNING_SIG) {
523 dev_err(cs35l41->dev,
524 "Mismatched Signature for Tuning Param file. Expected %#x got %#x\n",
525 CS35L41_TUNING_SIG, le32_to_cpu(params->signature));
526 return -EINVAL;
527 }
528
529 end = firmware->size - sizeof(struct cs35l41_tuning_params);
530
531 for (i = 0; i < le32_to_cpu(params->num_entries); i++) {
532 struct cs35l41_tuning_param *param;
533
534 if ((offset >= end) || ((offset + sizeof(struct cs35l41_tuning_param_hdr)) >= end))
535 return -EFAULT;
536
537 param = (void *)¶ms->data[offset];
538 offset += le32_to_cpu(param->hdr.size);
539
540 if (offset > end)
541 return -EFAULT;
542
543 switch (le32_to_cpu(param->hdr.type)) {
544 case TUNING_PARAM_GAIN:
545 cs35l41->tuning_gain = le32_to_cpu(param->gain);
546 dev_dbg(cs35l41->dev, "Applying Gain: %d\n", cs35l41->tuning_gain);
547 break;
548 default:
549 break;
550 }
551 }
552
553 return 0;
554 }
555
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
kernel test robot
build botRe: [PATCH v1 1/7] ALSA: hda: cs35l41: Set the max PCM Gain using tuning setting
In reply to Stefan Bindingkernel test robot noticed the following build warnings:
Hi Stefan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on tiwai-sound/for-linus linus/master v6.9-rc3 next-20240410] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Stefan-Binding/ALSA-hda-cs35l41-Set-the-max-PCM-Gain-using-tuning-setting/20240410-235446 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next patch link: https://lore.kernel.org/r/20240410155223.7164-2-sbinding%40opensource.cirrus.com patch subject: [PATCH v1 1/7] ALSA: hda: cs35l41: Set the max PCM Gain using tuning setting config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20240411/[email protected]/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240411/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:566,
from include/asm-generic/bug.h:22,
from arch/loongarch/include/asm/bug.h:60,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/loongarch/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from include/linux/spinlock.h:56,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/slab.h:16,
from include/linux/resource_ext.h:11,
from include/linux/acpi.h:13,
from sound/pci/hda/cs35l41_hda.c:9:
sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_load_tuning_params':
>> sound/pci/hda/cs35l41_hda.c:565:39: warning: '%s' directive argument is null [-Wformat-overflow=]
565 | dev_dbg(cs35l41->dev, "Missing Tuning Param File: %s: %d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
273 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
sound/pci/hda/cs35l41_hda.c:565:17: note: in expansion of macro 'dev_dbg'
565 | dev_dbg(cs35l41->dev, "Missing Tuning Param File: %s: %d\n",
| ^~~~~~~
sound/pci/hda/cs35l41_hda.c:565:67: note: format string is defined here
565 | dev_dbg(cs35l41->dev, "Missing Tuning Param File: %s: %d\n",
| ^~vim +565 sound/pci/hda/cs35l41_hda.c
555
556 static int cs35l41_load_tuning_params(struct cs35l41_hda *cs35l41, char *tuning_filename)
557 {
558 const struct firmware *tuning_param_file = NULL;
559 char *tuning_param_filename = NULL;
560 int ret;
561
562 ret = cs35l41_request_tuning_param_file(cs35l41, tuning_filename, &tuning_param_file,
563 &tuning_param_filename, cs35l41->acpi_subsystem_id);
564 if (ret) {
> 565 dev_dbg(cs35l41->dev, "Missing Tuning Param File: %s: %d\n",
566 tuning_param_filename, ret);
567 return 0;
568 }
569
570 ret = cs35l41_read_tuning_params(cs35l41, tuning_param_file);
571 if (ret) {
572 dev_err(cs35l41->dev, "Error reading Tuning Params from file: %s: %d\n",
573 tuning_param_filename, ret);
574 /* Reset to default Tuning Parameters */
575 cs35l41_set_default_tuning_params(cs35l41);
576 }
577
578 release_firmware(tuning_param_file);
579 kfree(tuning_param_filename);
580
581 return ret;
582 }
583
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH 2/7 ALSA: hda: cs35l41: Support HP Omen models without _DSD
In reply to Stefan BindingAdd support for 2 new HP Omen models without _DSD into configuration table.
These laptops use the PCM Gain setting for the tuning setting file.
--- sound/pci/hda/cs35l41_hda_property.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +4 -0
@@ -70,6 +70,8 @@ static const struct cs35l41_config cs35l41_config_table[] = { { "103C8C15", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4000, 24 }, { "103C8C16", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4000, 24 }, { "103C8C17", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4000, 24 }, + { "103C8C4D", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, + { "103C8C4E", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, { "103C8C4F", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, { "103C8C50", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 }, { "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
@@ -457,6 +459,8 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = { { "CSC3551", "103C8C15", generic_dsd_config }, { "CSC3551", "103C8C16", generic_dsd_config }, { "CSC3551", "103C8C17", generic_dsd_config }, + { "CSC3551", "103C8C4D", generic_dsd_config }, + { "CSC3551", "103C8C4E", generic_dsd_config }, { "CSC3551", "103C8C4F", generic_dsd_config }, { "CSC3551", "103C8C50", generic_dsd_config }, { "CSC3551", "103C8C51", generic_dsd_config },
Signature · 1 line
2.34.1
PATCH 3/7 ALSA: hda/realtek: Add quirks for HP Omen models using CS35L41
In reply to Stefan BindingAdd 4 laptops using CS35L41 HDA.
None of these laptops have _DSD, so require entries in property configuration table for cs35l41_hda driver.
--- sound/pci/hda/patch_realtek.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/pci/hda/patch_realtek.c +4 -0
@@ -10040,6 +10040,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x8b92 ,"HP" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x8b96 ,"HP" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ),SND_PCI_QUIRK (0x103c ,0x8b97 ,"HP" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ), +SND_PCI_QUIRK (0x103c ,0x8bb3 ,"HP Slim OMEN" ,ALC287_FIXUP_CS35L41_I2C_2 ), +SND_PCI_QUIRK (0x103c ,0x8bb4 ,"HP Slim OMEN" ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8bdd ,"HP Envy 17" ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8bde ,"HP Envy 17" ,ALC287_FIXUP_CS35L41_I2C_2 ), SND_PCI_QUIRK(0x103c, 0x8bdf, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),
@@ -10060,6 +10062,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x8c47 ,"HP EliteBook 840 G11" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x8c48 ,"HP EliteBook 860 G11" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x8c49 ,"HP Elite x360 830 2-in-1 G11" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ), +SND_PCI_QUIRK (0x103c ,0x8c4d ,"HP Omen" ,ALC287_FIXUP_CS35L41_I2C_2 ), +SND_PCI_QUIRK (0x103c ,0x8c4e ,"HP Omen" ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8c4f ,"HP Envy 15" ,ALC287_FIXUP_CS35L41_I2C_2 ),SND_PCI_QUIRK (0x103c ,0x8c50 ,"HP Envy 17" ,ALC287_FIXUP_CS35L41_I2C_2 ), SND_PCI_QUIRK(0x103c, 0x8c51, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
Signature · 1 line
2.34.1
PATCH 4/7 ALSA: hda: cs35l41: Update DSP1RX5/6 Sources for DSP config
In reply to Stefan BindingCurrently, all PC systems are set to use VBSTMON for DSP1RX5_SRC, however, this is required only for external boost systems. Internal boost systems require VPMON instead of VBSTMON to be the input to DSP1RX5_SRC.
All systems require DSP1RX6_SRC to be set to VBSTMON. Also fix incorrect comment for DACPCM1_SRC to use DSP1TX1.
--- sound/pci/hda/cs35l41_hda.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
sound/pci/hda/cs35l41_hda.c +6 -2
@@ -102,7 +102,7 @@ static const struct reg_sequence cs35l41_hda_config_dsp[] = { { CS35L41_SP_HIZ_CTRL, 0x00000003 }, // Hi-Z unused/disabled { CS35L41_SP_TX_WL, 0x00000018 }, // 24 cycles/slot { CS35L41_SP_RX_WL, 0x00000018 }, // 24 cycles/slot - { CS35L41_DAC_PCM1_SRC, 0x00000032 }, // DACPCM1_SRC = ERR_VOL + { CS35L41_DAC_PCM1_SRC, 0x00000032 }, // DACPCM1_SRC = DSP1TX1 { CS35L41_ASP_TX1_SRC, 0x00000018 }, // ASPTX1 SRC = VMON { CS35L41_ASP_TX2_SRC, 0x00000019 }, // ASPTX2 SRC = IMON { CS35L41_ASP_TX3_SRC, 0x00000028 }, // ASPTX3 SRC = VPMON
@@ -111,7 +111,7 @@ static const struct reg_sequence cs35l41_hda_config_dsp[] = { { CS35L41_DSP1_RX2_SRC, 0x00000008 }, // DSP1RX2 SRC = ASPRX1 { CS35L41_DSP1_RX3_SRC, 0x00000018 }, // DSP1RX3 SRC = VMON { CS35L41_DSP1_RX4_SRC, 0x00000019 }, // DSP1RX4 SRC = IMON - { CS35L41_DSP1_RX5_SRC, 0x00000029 }, // DSP1RX5 SRC = VBSTMON + { CS35L41_DSP1_RX6_SRC, 0x00000029 }, // DSP1RX6 SRC = VBSTMON }; static const struct reg_sequence cs35l41_hda_unmute[] = {
@@ -693,6 +693,10 @@ static void cs35l41_hda_play_start(struct device *dev)if (cs35l41->cs_dsp.running) {regmap_multi_reg_write (reg, cs35l41_hda_config_dsp,ARRAY_SIZE (cs35l41_hda_config_dsp)); +if (cs35l41->hw_cfg.bst_type ==CS35L41_INT_BOOST ) +regmap_write (reg,CS35L41_DSP1_RX5_SRC ,CS35L41_INPUT_SRC_VPMON ); +else +regmap_write (reg,CS35L41_DSP1_RX5_SRC ,CS35L41_INPUT_SRC_VBSTMON );regmap_update_bits (reg,CS35L41_PWR_CTRL2 ,CS35L41_VMON_EN_MASK |CS35L41_IMON_EN_MASK ,1 <<CS35L41_VMON_EN_SHIFT |1 <<CS35L41_IMON_EN_SHIFT );
Signature · 1 line
2.34.1
PATCH 5/7 ALSA: hda: cs35l41: Use shared cs-amp-lib to apply calibration
In reply to Stefan BindingThe original mechanism for applying calibration assumed that the calibration data would be ordered the same as the amp instances. However, for some 4 amp laptops, this is not the case.
To ensure that the correct calibration is applied to the correct amp, the calibration data contains a unique id, which matches a unique id inside the CS35L41. This can be used to match to the correct data entry. This mechanism is available inside the shared module cs-amp-lib.
--- sound/pci/hda/Kconfig | 2 + sound/pci/hda/cs35l41_hda.c | 140 +++++++++++++++++------------------- sound/pci/hda/cs35l41_hda.h | 3 + 3 files changed, 72 insertions(+), 73 deletions(-)
sound/pci/hda/Kconfig +2 -0
@@ -128,6 +128,7 @@ config SND_HDA_SCODEC_CS35L41_I2C select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 select SND_HDA_CS_DSP_CONTROLS + select SND_SOC_CS_AMP_LIB help Say Y or M here to include CS35L41 I2C HD-audio side codec support in snd-hda-intel driver, such as ALC287.
@@ -144,6 +145,7 @@ config SND_HDA_SCODEC_CS35L41_SPI select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 select SND_HDA_CS_DSP_CONTROLS + select SND_SOC_CS_AMP_LIB help Say Y or M here to include CS35L41 SPI HD-audio side codec support in snd-hda-intel driver, such as ALC287.
sound/pci/hda/cs35l41_hda.c +67 -73
187 lines not on this page · raw message
sound/pci/hda/cs35l41_hda.h +3 -0
@@ -16,6 +16,7 @@#include <linux/gpio/consumer.h> #include <linux/device.h> #include <sound/cs35l41.h> +#include <sound/cs-amp-lib.h> #include <linux/firmware/cirrus/cs_dsp.h> #include <linux/firmware/cirrus/wmfw.h>
@@ -86,6 +87,8 @@ struct cs35l41_hda {enum control_bus control_bus;bool bypass_fw;unsigned int tuning_gain; +struct cirrus_amp_cal_data cal_data; +bool cal_data_valid; };
Signature · 1 line
2.34.1
PATCH 6/7 ALSA: hda: cs35l41: Remove redundant argument to cs35l41_request_firmware_file()
In reply to Stefan BindingFrom: Richard Fitzgerald <[email protected]>
In every case the 'dir' argument to cs35l41_request_firmware_file() is passed the string "cirrus/", so this is a redundant argument and can be removed.
--- sound/pci/hda/cs35l41_hda.c | 39 ++++++++++++++----------------------- 1 file changed, 15 insertions(+), 24 deletions(-)
sound/pci/hda/cs35l41_hda.c +15 -24
@@ -23,7 +23,6 @@#include "hda_cs_dsp_ctl.h" #include "cs35l41_hda_property.h" -#define CS35L41_FIRMWARE_ROOT "cirrus/"#define CS35L41_PART "cs35l41"#define HALO_STATE_DSP_CTL_NAME "HALO_STATE"
@@ -172,7 +171,7 @@ static int cs35l41_request_tuning_param_file(struct cs35l41_hda *cs35l41, char *static int cs35l41_request_firmware_file (struct cs35l41_hda *cs35l41,const struct firmware **firmware,char **filename, -const char *dir,const char *ssid,const char *amp_name, +const char *ssid,const char *amp_name,int spkid,const char *filetype) {const char *const dsp_name = cs35l41->cs_dsp.name;
@@ -180,23 +179,23 @@ static int cs35l41_request_firmware_file(struct cs35l41_hda *cs35l41,int ret =0 ;if (spkid >-1 && ssid && amp_name) - *filename =kasprintf (GFP_KERNEL ,"%s%s-%s-%s-%s-spkid%d-%s.%s" , dir,CS35L41_PART , + *filename =kasprintf (GFP_KERNEL ,"cirrus/%s-%s-%s-%s-spkid%d-%s.%s" ,CS35L41_PART , dsp_name, hda_cs_dsp_fw_ids[cs35l41->firmware_type], ssid, spkid, amp_name, filetype);else if (spkid >-1 && ssid) - *filename =kasprintf (GFP_KERNEL ,"%s%s-%s-%s-%s-spkid%d.%s" , dir,CS35L41_PART , + *filename =kasprintf (GFP_KERNEL ,"cirrus/%s-%s-%s-%s-spkid%d.%s" ,CS35L41_PART , dsp_name, hda_cs_dsp_fw_ids[cs35l41->firmware_type], ssid, spkid, filetype);else if (ssid && amp_name) - *filename =kasprintf (GFP_KERNEL ,"%s%s-%s-%s-%s-%s.%s" , dir,CS35L41_PART , + *filename =kasprintf (GFP_KERNEL ,"cirrus/%s-%s-%s-%s-%s.%s" ,CS35L41_PART , dsp_name, hda_cs_dsp_fw_ids[cs35l41->firmware_type], ssid, amp_name, filetype);else if (ssid) - *filename =kasprintf (GFP_KERNEL ,"%s%s-%s-%s-%s.%s" , dir,CS35L41_PART , + *filename =kasprintf (GFP_KERNEL ,"cirrus/%s-%s-%s-%s.%s" ,CS35L41_PART , dsp_name, hda_cs_dsp_fw_ids[cs35l41->firmware_type], ssid, filetype);else - *filename =kasprintf (GFP_KERNEL ,"%s%s-%s-%s.%s" , dir,CS35L41_PART , + *filename =kasprintf (GFP_KERNEL ,"cirrus/%s-%s-%s.%s" ,CS35L41_PART , dsp_name, hda_cs_dsp_fw_ids[cs35l41->firmware_type], filetype);
@@ -237,13 +236,11 @@ static int cs35l41_request_firmware_files_spkid(struct cs35l41_hda *cs35l41,/* try cirrus/part-dspN-fwtype-sub<-spkidN><-ampname>.wmfw */ ret =cs35l41_request_firmware_file (cs35l41, wmfw_firmware, wmfw_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, cs35l41->amp_name, cs35l41->speaker_id,"wmfw" );if (!ret) {/* try cirrus/part-dspN-fwtype-sub<-spkidN><-ampname>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, cs35l41->amp_name, cs35l41->speaker_id,"bin" );if (ret)
@@ -254,12 +251,11 @@ static int cs35l41_request_firmware_files_spkid(struct cs35l41_hda *cs35l41,/* try cirrus/part-dspN-fwtype-sub<-ampname>.wmfw */ ret =cs35l41_request_firmware_file (cs35l41, wmfw_firmware, wmfw_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, + cs35l41->acpi_subsystem_id, cs35l41->amp_name,-1 ,"wmfw" );if (!ret) {/* try cirrus/part-dspN-fwtype-sub<-spkidN><-ampname>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, cs35l41->amp_name, cs35l41->speaker_id,"bin" );if (ret)
@@ -270,18 +266,17 @@ static int cs35l41_request_firmware_files_spkid(struct cs35l41_hda *cs35l41,/* try cirrus/part-dspN-fwtype-sub<-spkidN>.wmfw */ ret =cs35l41_request_firmware_file (cs35l41, wmfw_firmware, wmfw_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, + cs35l41->acpi_subsystem_id,NULL , cs35l41->speaker_id,"wmfw" );if (!ret) {/* try cirrus/part-dspN-fwtype-sub<-spkidN><-ampname>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, cs35l41->amp_name, cs35l41->speaker_id,"bin" );if (ret)/* try cirrus/part-dspN-fwtype-sub<-spkidN>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, - coeff_filename,CS35L41_FIRMWARE_ROOT , + coeff_filename, cs35l41->acpi_subsystem_id,NULL , cs35l41->speaker_id,"bin" );if (ret)
@@ -292,18 +287,17 @@ static int cs35l41_request_firmware_files_spkid(struct cs35l41_hda *cs35l41,/* try cirrus/part-dspN-fwtype-sub.wmfw */ ret =cs35l41_request_firmware_file (cs35l41, wmfw_firmware, wmfw_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, + cs35l41->acpi_subsystem_id,NULL ,-1 ,"wmfw" );if (!ret) {/* try cirrus/part-dspN-fwtype-sub<-spkidN><-ampname>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, cs35l41->amp_name, cs35l41->speaker_id,"bin" );if (ret)/* try cirrus/part-dspN-fwtype-sub<-spkidN>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, - coeff_filename,CS35L41_FIRMWARE_ROOT , + coeff_filename, cs35l41->acpi_subsystem_id,NULL , cs35l41->speaker_id,"bin" );if (ret)
@@ -330,13 +324,13 @@ static int cs35l41_fallback_firmware_file(struct cs35l41_hda *cs35l41,/* fallback try cirrus/part-dspN-fwtype.wmfw */ ret =cs35l41_request_firmware_file (cs35l41, wmfw_firmware, wmfw_filename, -CS35L41_FIRMWARE_ROOT ,NULL ,NULL ,-1 ,"wmfw" ); +NULL ,NULL ,-1 ,"wmfw" );if (ret) goto err;/* fallback try cirrus/part-dspN-fwtype.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT ,NULL ,NULL ,-1 ,"bin" ); +NULL ,NULL ,-1 ,"bin" );if (ret) {release_firmware (*wmfw_firmware);kfree (*wmfw_filename);
@@ -365,12 +359,11 @@ static int cs35l41_request_firmware_files(struct cs35l41_hda *cs35l41,/* try cirrus/part-dspN-fwtype-sub<-ampname>.wmfw */ ret =cs35l41_request_firmware_file (cs35l41, wmfw_firmware, wmfw_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, + cs35l41->acpi_subsystem_id, cs35l41->amp_name,-1 ,"wmfw" );if (!ret) {/* try cirrus/part-dspN-fwtype-sub<-ampname>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, cs35l41->amp_name,-1 ,"bin" );if (ret)
@@ -381,18 +374,16 @@ static int cs35l41_request_firmware_files(struct cs35l41_hda *cs35l41,/* try cirrus/part-dspN-fwtype-sub.wmfw */ ret =cs35l41_request_firmware_file (cs35l41, wmfw_firmware, wmfw_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, + cs35l41->acpi_subsystem_id,NULL ,-1 ,"wmfw" );if (!ret) {/* try cirrus/part-dspN-fwtype-sub<-ampname>.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id, cs35l41->amp_name,-1 ,"bin" );if (ret)/* try cirrus/part-dspN-fwtype-sub.bin */ ret =cs35l41_request_firmware_file (cs35l41, coeff_firmware, coeff_filename, -CS35L41_FIRMWARE_ROOT , cs35l41->acpi_subsystem_id,NULL ,-1 ,"bin" );if (ret)
Signature · 1 line
2.34.1
PATCH 7/7 ALSA: hda: cs35l41: Remove Speaker ID for Lenovo Legion slim 7 16ARHA7
In reply to Stefan BindingThese laptops do not have _DSD and must be added by configuration table, however, the initial entries for them are incorrect:
Neither laptop contains a Speaker ID GPIO.
This issue would not affect audio playback, but may affect which files are loaded when loading firmware.
--- sound/pci/hda/cs35l41_hda_property.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/cs35l41_hda_property.c +2 -2
@@ -112,8 +112,8 @@ static const struct cs35l41_config cs35l41_config_table[] = { { "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 }, { "10433A60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 }, { "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 }, - { "17AA3877", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, - { "17AA3878", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 }, + { "17AA3877", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 }, + { "17AA3878", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 }, { "17AA38A9", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 }, { "17AA38AB", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 }, { "17AA38B4", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
Signature · 1 line
2.34.1