Skip to contentSkip to conversation

clk: qcom: fix module autoloading

PATCH Applied Krzysztof Kozlowski 4 participants 4 messages Apr 10, 2024 – Apr 12, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: qcom: fix module autoloading

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Clocks are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

---
 drivers/clk/qcom/gcc-msm8917.c | 1 +
 drivers/clk/qcom/gcc-msm8953.c | 1 +
 2 files changed, 2 insertions(+)
drivers/clk/qcom/gcc-msm8917.c +1 -0
index f2dd132e2fb1..f2b8729e4198 100644
@@ -3278,6 +3278,7 @@ static const struct of_device_id gcc_msm8917_match_table[] = {
 	{ .compatible = "qcom,gcc-qm215", .data = &gcc_qm215_desc },
 	{},
 };
+MODULE_DEVICE_TABLE(of, gcc_msm8917_match_table);
 
 static struct platform_driver gcc_msm8917_driver = {
 	.probe = gcc_msm8917_probe,
drivers/clk/qcom/gcc-msm8953.c +1 -0
index 68359534ff25..7563bff58118 100644
@@ -4227,6 +4227,7 @@ static const struct of_device_id gcc_msm8953_match_table[] = {
 	{ .compatible = "qcom,gcc-msm8953" },
 	{},
 };
+MODULE_DEVICE_TABLE(of, gcc_msm8953_match_table);
 
 static struct platform_driver gcc_msm8953_driver = {
 	.probe = gcc_msm8953_probe,
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Clocks are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

---
  drivers/clk/qcom/gcc-msm8917.c | 1 +
  drivers/clk/qcom/gcc-msm8953.c | 1 +
  2 files changed, 2 insertions(+)
drivers/clk/qcom/gcc-msm8917.c +1 -0
index f2dd132e2fb1..f2b8729e4198 100644
@@ -3278,6 +3278,7 @@ static const struct of_device_id gcc_msm8917_match_table[] = {
  	{ .compatible = "qcom,gcc-qm215", .data = &gcc_qm215_desc },
  	{},
  };
+MODULE_DEVICE_TABLE(of, gcc_msm8917_match_table);
 
  static struct platform_driver gcc_msm8917_driver = {
  	.probe = gcc_msm8917_probe,
drivers/clk/qcom/gcc-msm8953.c +0 -0
index 68359534ff25..7563bff58118 100644

drivers/clk/qcom/gcc-msm8953.c static const struct of_device_id gcc_msm8953_match_table[] = { · line 4233

Quoted 7 lines
drivers/clk/qcom/gcc-msm8953.c +1 -0
@@ -4227,6 +4227,7 @@ static const struct of_device_id gcc_msm8953_match_table[] = {
  	{ .compatible = "qcom,gcc-msm8953" },
  	{},
  };
+MODULE_DEVICE_TABLE(of, gcc_msm8953_match_table);
 
  static struct platform_driver gcc_msm8953_driver = {
  	.probe = gcc_msm8953_probe,
maintainer Applied
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Clocks are considered core components, so usually they are built-in, however these can be built and used as modules on some generic kernel.

Applied, thanks!

[1/1] clk: qcom: fix module autoloading

      commit: 1aab318f1e4900fac325e0d55a0591108ea0cfbb

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>