optimize fsl-edma for imx8QM
Subsystems (3)
cover optimize fsl-edma for imx8QM
The patchset optimize fsl-edma.
For the details, please check the patch commit log.
Joy Zou (1):
dmaengine: fsl-edma: optimize edma driver for imx8QM
drivers/dma/fsl-edma-common.c | 16 ++++------------ drivers/dma/fsl-edma-main.c | 8 -------- 2 files changed, 4 insertions(+), 20 deletions(-)
Signature · 1 line
2.37.1
PATCH 1/1 dmaengine: fsl-edma: optimize edma driver for imx8QM
The eDMA hardware issue only exist imx8QM A0. A0 never mass production. So remove the workaround safely.
--- drivers/dma/fsl-edma-common.c | 16 ++++------------ drivers/dma/fsl-edma-main.c | 8 -------- 2 files changed, 4 insertions(+), 20 deletions(-)
drivers/dma/fsl-edma-common.c +4 -12
@@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct fsl_edma_chan *fsl_chan) flags =fsl_edma_drvflags (fsl_chan); val =edma_readl_chreg (fsl_chan, ch_sbr); -/* Remote/local swapped wrongly on iMX8 QM Audio edma */ -if (flags &FSL_EDMA_DRV_QUIRK_SWAPPED ) { -if (!fsl_chan->is_rxchan) - val |=EDMA_V3_CH_SBR_RD ; -else - val |=EDMA_V3_CH_SBR_WR ; - }else { -if (fsl_chan->is_rxchan) - val |=EDMA_V3_CH_SBR_RD ; -else - val |=EDMA_V3_CH_SBR_WR ; - } +if (fsl_chan->is_rxchan) + val |=EDMA_V3_CH_SBR_RD ; +else + val |=EDMA_V3_CH_SBR_WR ;if (fsl_chan->is_remote) val &= ~(EDMA_V3_CH_SBR_RD |EDMA_V3_CH_SBR_WR );
drivers/dma/fsl-edma-main.c +0 -8
@@ -349,13 +349,6 @@ static struct fsl_edma_drvdata imx8qm_data = { .setup_irq = fsl_edma3_irq_init, }; -static struct fsl_edma_drvdata imx8qm_audio_data = { - .flags =FSL_EDMA_DRV_QUIRK_SWAPPED |FSL_EDMA_DRV_HAS_PD |FSL_EDMA_DRV_EDMA3 , - .chreg_space_sz =0x10000 , - .chreg_off =0x10000 , - .setup_irq = fsl_edma3_irq_init, -}; -static struct fsl_edma_drvdata imx8ulp_data = { .flags =FSL_EDMA_DRV_HAS_CHMUX |FSL_EDMA_DRV_HAS_CHCLK |FSL_EDMA_DRV_HAS_DMACLK |FSL_EDMA_DRV_EDMA3 ,
@@ -397,7 +390,6 @@ static const struct of_device_id fsl_edma_dt_ids[] = { { .compatible = "fsl,ls1028a-edma", .data = &ls1028a_data}, { .compatible = "fsl,imx7ulp-edma", .data = &imx7ulp_data}, { .compatible = "fsl,imx8qm-edma", .data = &imx8qm_data}, - { .compatible = "fsl,imx8qm-adma", .data = &imx8qm_audio_data}, { .compatible = "fsl,imx8ulp-edma", .data = &imx8ulp_data}, { .compatible = "fsl,imx93-edma3", .data = &imx93_data3}, { .compatible = "fsl,imx93-edma4", .data = &imx93_data4},
Signature · 1 line
2.37.1
Frank Li
maintainerRe: [PATCH v1 1/1] dmaengine: fsl-edma: optimize edma driver for imx8QM
Quoted 55 lines · Joy Zou
The eDMA hardware issue only exist imx8QM A0. A0 never mass production. So remove the workaround safely.
Signed-off-by Joy Zou <[email protected]>--- drivers/dma/fsl-edma-common.c | 16 ++++------------ drivers/dma/fsl-edma-main.c | 8 -------- 2 files changed, 4 insertions(+), 20 deletions(-)drivers/dma/fsl-edma-common.c +4
-12@@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct fsl_edma_chan *fsl_chan) flags =fsl_edma_drvflags (fsl_chan); val =edma_readl_chreg (fsl_chan, ch_sbr); -/* Remote/local swapped wrongly on iMX8 QM Audio edma */ -if (flags &FSL_EDMA_DRV_QUIRK_SWAPPED ) { -if (!fsl_chan->is_rxchan) - val |=EDMA_V3_CH_SBR_RD ; -else - val |=EDMA_V3_CH_SBR_WR ; - }else { -if (fsl_chan->is_rxchan) - val |=EDMA_V3_CH_SBR_RD ; -else - val |=EDMA_V3_CH_SBR_WR ; - } +if (fsl_chan->is_rxchan) + val |=EDMA_V3_CH_SBR_RD ; +else + val |=EDMA_V3_CH_SBR_WR ;if (fsl_chan->is_remote) val &= ~(EDMA_V3_CH_SBR_RD |EDMA_V3_CH_SBR_WR );drivers/dma/fsl-edma-main.c +0
-7@@ -349,13 +349,6 @@ static struct fsl_edma_drvdata imx8qm_data = { .setup_irq = fsl_edma3_irq_init, }; -static struct fsl_edma_drvdata imx8qm_audio_data = { - .flags =FSL_EDMA_DRV_QUIRK_SWAPPED |FSL_EDMA_DRV_HAS_PD |FSL_EDMA_DRV_EDMA3 , - .chreg_space_sz =0x10000 , - .chreg_off =0x10000 , - .setup_irq = fsl_edma3_irq_init, -}; -static struct fsl_edma_drvdata imx8ulp_data = { .flags =FSL_EDMA_DRV_HAS_CHMUX |FSL_EDMA_DRV_HAS_CHCLK |FSL_EDMA_DRV_HAS_DMACLK |FSL_EDMA_DRV_EDMA3 ,
drivers/dma/fsl-edma-main.c static const struct of_device_id fsl_edma_dt_ids[] = { · line 400
Quoted 4 lines
drivers/dma/fsl-edma-main.c +0
-1@@ -397,7 +390,6 @@ static const struct of_device_id fsl_edma_dt_ids[] = { { .compatible = "fsl,ls1028a-edma", .data = &ls1028a_data}, { .compatible = "fsl,imx7ulp-edma", .data = &imx7ulp_data}, { .compatible = "fsl,imx8qm-edma", .data = &imx8qm_data}, - { .compatible = "fsl,imx8qm-adma", .data = &imx8qm_audio_data},
Please update binding doc also.
Frank Li
Quoted 6 lines
drivers/dma/fsl-edma-main.c +0
-0{ .compatible = "fsl,imx8ulp-edma", .data = &imx8ulp_data}, { .compatible = "fsl,imx93-edma3", .data = &imx93_data3}, { .compatible = "fsl,imx93-edma4", .data = &imx93_data4},Signature · 1 line
2.37.1
RE: [PATCH v1 1/1] dmaengine: fsl-edma: optimize edma driver for imx8QM
Quoted 72 lines
-----Original Message-----
From: Frank Li <[email protected]>
Sent: 2024年4月11日 10:41
To: Joy Zou <[email protected]>
Cc: Peng Fan <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v1 1/1] dmaengine: fsl-edma: optimize edma driver for imx8QMQuoted 1 line · Joy Zou
The eDMA hardware issue only exist imx8QM A0. A0 never mass
production.
Quoted 42 lines
So remove the workaround safely.
Signed-off-by Joy Zou <[email protected]>--- drivers/dma/fsl-edma-common.c | 16 ++++------------ drivers/dma/fsl-edma-main.c | 8 -------- 2 files changed, 4 insertions(+), 20 deletions(-)(quoted diff) +0
-0
b/drivers/dma/fsl-edma-common.cindexf9144b015439..ed93e01282d5100644drivers/dma/fsl-edma-common.c +4
-12@@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct fsl_edma_chan *fsl_chan) flags =fsl_edma_drvflags (fsl_chan); val =edma_readl_chreg (fsl_chan, ch_sbr); -/* Remote/local swapped wrongly on iMX8 QM Audio edma */ -if (flags &FSL_EDMA_DRV_QUIRK_SWAPPED ) { -if (!fsl_chan->is_rxchan) - val |=EDMA_V3_CH_SBR_RD ; -else - val |=EDMA_V3_CH_SBR_WR ; - }else { -if (fsl_chan->is_rxchan) - val |=EDMA_V3_CH_SBR_RD ; -else - val |=EDMA_V3_CH_SBR_WR ; - } +if (fsl_chan->is_rxchan) + val |=EDMA_V3_CH_SBR_RD ; +else + val |=EDMA_V3_CH_SBR_WR ;if (fsl_chan->is_remote)val &= ~(EDMA_V3_CH_SBR_RD |
EDMA_V3_CH_SBR_WR); diff --gita/drivers/dma/fsl-edma-main.cb/drivers/dma/fsl-edma-main.cindex755a3dc3b0a7..b06fa147d6ba100644drivers/dma/fsl-edma-main.c static struct fsl_edma_drvdata imx8qm_data = { · line 353
Quoted 5 lines
drivers/dma/fsl-edma-main.c +0
-2@@ -349,13 +349,6 @@ static struct fsl_edma_drvdata imx8qm_data = { .setup_irq = fsl_edma3_irq_init, }; -static struct fsl_edma_drvdata imx8qm_audio_data = { - .flags = FSL_EDMA_DRV_QUIRK_SWAPPED | FSL_EDMA_DRV_HAS_PD |
FSL_EDMA_DRV_EDMA3,drivers/dma/fsl-edma-main.c static struct fsl_edma_drvdata imx8qm_data = {
Quoted 7 lines
drivers/dma/fsl-edma-main.c +0
-5- .chreg_space_sz = 0x10000, - .chreg_off = 0x10000, - .setup_irq = fsl_edma3_irq_init, -}; -static struct fsl_edma_drvdata imx8ulp_data = { .flags = FSL_EDMA_DRV_HAS_CHMUX | FSL_EDMA_DRV_HAS_CHCLK |
FSL_EDMA_DRV_HAS_DMACLK|drivers/dma/fsl-edma-main.c static const struct of_device_id fsl_edma_dt_ids[] =
Quoted 2 lines
drivers/dma/fsl-edma-main.c +0
-0FSL_EDMA_DRV_EDMA3,@@ -397,7 +390,6 @@ static const struct of_device_id fsl_edma_dt_ids[] ={
Quoted 6 lines
drivers/dma/fsl-edma-main.c static const struct of_device_id fsl_edma_dt_ids[] = { · line 400
Quoted 4 lines
drivers/dma/fsl-edma-main.c +0
-1{ .compatible = "fsl,ls1028a-edma", .data = &ls1028a_data}, { .compatible = "fsl,imx7ulp-edma", .data = &imx7ulp_data}, { .compatible = "fsl,imx8qm-edma", .data = &imx8qm_data}, - { .compatible = "fsl,imx8qm-adma", .data = &imx8qm_audio_data},Please update binding doc also.
Thanks for your comments!
Yeah, will add bindings update on next version.
BR
Joy Zou
Quoted 9 lines
Frank Li
Quoted 6 lines
drivers/dma/fsl-edma-main.c +0
-1{ .compatible = "fsl,imx8ulp-edma", .data = &imx8ulp_data}, { .compatible = "fsl,imx93-edma3", .data = &imx93_data3}, { .compatible = "fsl,imx93-edma4", .data = &imx93_data4}, --2.37.1