Skip to contentSkip to conversation

zram01.sh: Increase timeout for check_read_mem_used_total

PATCH In review Wei Gao via ltp 2 participants 3 messages Apr 11, 2024 – May 7, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zram01.sh: Increase timeout for check_read_mem_used_total

Increase timeout value to let case pass on our low ppc64le machine.

---
 testcases/kernel/device-drivers/zram/zram01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/device-drivers/zram/zram01.sh +1 -1
index 0c100b706..959dab217 100755
@@ -155,7 +155,7 @@ zram_fill_fs()
 			continue
 		fi
 
-		TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
+		TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10
 		mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
 		tst_res TINFO "mem_used_total: $mem_used_total"
 
Signature · 5 lines
2.35.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#1 lore raw

Hi all,

Quoted 1 line

Increase timeout value to let case pass on our low ppc64le

nit: s/low/low resource/

Quoted 12 lines

machine.

---
 testcases/kernel/device-drivers/zram/zram01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/device-drivers/zram/zram01.sh +0 -0
index 0c100b706..959dab217 100755

testcases/kernel/device-drivers/zram/zram01.sh zram_fill_fs() · line 158

Quoted 5 lines
testcases/kernel/device-drivers/zram/zram01.sh +1 -1
@@ -155,7 +155,7 @@ zram_fill_fs()
 			continue
 		fi
 
-		TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
+		TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10

Sounds ok for me to avoid timeout.
@Cyril, @Li WDYT? Or do you smell bug we try to cover?

Kind regards,
Petr

Quoted 2 lines
testcases/kernel/device-drivers/zram/zram01.sh +0 -0
 		mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
 		tst_res TINFO "mem_used_total: $mem_used_total"
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi all,

Quoted 3 lines

Hi all,

Quoted 1 line

...

Quoted 8 lines
Quoted 7 lines
testcases/kernel/device-drivers/zram/zram01.sh +0 -0
index 0c100b706..959dab217 100755
@@ -155,7 +155,7 @@ zram_fill_fs()
 			continue
 		fi
Quoted 7 lines

testcases/kernel/device-drivers/zram/zram01.sh zram_fill_fs() · line 158

Quoted 2 lines
testcases/kernel/device-drivers/zram/zram01.sh +1 -1
-		TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
+		TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10

Sounds ok for me to avoid timeout.
@Cyril, @Li WDYT? Or do you smell bug we try to cover?

FYI merged. Thanks!

Kind regards,
Petr

Quoted 5 lines

Kind regards,
Petr

Quoted 2 lines
testcases/kernel/device-drivers/zram/zram01.sh +0 -0
 		mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
 		tst_res TINFO "mem_used_total: $mem_used_total"
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp