Skip to contentSkip to conversation

Remove the empty lines from sama5 and sama7 DT files

PATCH In review Mihai Sain 3 participants 18 messages Apr 11, 2024

Subsystems (2)
lore
Share & tools
lore

Mihai Sain

author
#0 lore raw

cover Remove the empty lines from sama5 and sama7 DT files

This patch series removes the empty lines from sama5 and sama7 DT files.

Mihai Sain (13):
ARM: dts: microchip: sama7g5ek: Remove the empty line 50
ARM: dts: microchip: sama7g5: Remove the empty line 139
ARM: dts: microchip: sama5d2: Remove the empty lines 47 and 63
ARM: dts: microchip: sama5d27_som1_ek: Remove the empty lines
ARM: dts: microchip: sama5d27_wlsom1_ek: Remove the empty line 31
ARM: dts: microchip: sama5d29_curiosity: Remove the empty line 48
ARM: dts: microchip: sama5d2_icp: Remove the empty line 47
ARM: dts: microchip: sama5d2_ptc_ek: Remove the empty line 401
ARM: dts: microchip: sama5d2_xplained: Remove the empty line 710
ARM: dts: microchip: sama5d3_eds: Remove the empty line 24
ARM: dts: microchip: sama5d3_xplained: Remove the empty line 377
ARM: dts: microchip: sama5d4_xplained: Remove the empty line 247
ARM: dts: microchip: sama5d4ek: Remove the empty line 274

 arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts   | 4 ----
 arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1_ek.dts | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts        | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts     | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts   | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts        | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts   | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d4_xplained.dts   | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d4ek.dts          | 1 -
 arch/arm/boot/dts/microchip/at91-sama7g5ek.dts          | 1 -
 arch/arm/boot/dts/microchip/sama5d2.dtsi                | 2 --
 arch/arm/boot/dts/microchip/sama7g5.dtsi                | 1 -
 13 files changed, 17 deletions(-)

base-commit: e8c39d0f57f358950356a8e44ee5159f57f86ec5

Signature · 1 line
2.44.0
author
#1 lore raw

PATCH 1/13 ARM: dts: microchip: sama7g5ek: Remove the empty line 50

Remove the empty line 50 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama7g5ek.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama7g5ek.dts +0 -1
index 217e9b96c61e..e34ee887b7f8 100644
@@ -47,7 +47,6 @@ main_xtal {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio_default>;
 
Signature · 1 line
2.44.0
#2 lore raw

Re: [PATCH 01/13] ARM: dts: microchip: sama7g5ek: Remove the empty line 50

Quoted 1 line · Mihai Sain

Remove the empty line 50 from gpio-keys node.

Why? Commit msg *must* say why you are doing this.

I don't see any reason for this. You do not make code readable, you do not explain the issue being addressed.

Best regards,
Krzysztof

author
#3 lore raw

PATCH 2/13 ARM: dts: microchip: sama7g5: Remove the empty line 139

In reply to Mihai Sain

Remove the empty line 139 from regulator node.

---
 arch/arm/boot/dts/microchip/sama7g5.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/sama7g5.dtsi +0 -1
index 75778be126a3..1b99181d05d4 100644
@@ -136,7 +136,6 @@ usb_clk: usb_clk {
 
 	vddout25: fixed-regulator-vddout25 {
 		compatible = "regulator-fixed";
-
 		regulator-name = "VDDOUT25";
 		regulator-min-microvolt = <2500000>;
 		regulator-max-microvolt = <2500000>;
Signature · 1 line
2.44.0
author
#4 lore raw

PATCH 3/13 ARM: dts: microchip: sama5d2: Remove the empty lines 47 and 63

In reply to Mihai Sain

Remove the empty line 47 from etb node.
Remove the empty line 63 from etm node.

---
 arch/arm/boot/dts/microchip/sama5d2.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/microchip/sama5d2.dtsi +0 -2
index 5f8e297e19ed..7aea6c2368a2 100644
@@ -44,7 +44,6 @@ pmu {
 	etb@740000 {
 		compatible = "arm,coresight-etb10", "arm,primecell";
 		reg = <0x740000 0x1000>;
-
 		clocks = <&pmc PMC_TYPE_CORE PMC_MCK>;
 		clock-names = "apb_pclk";
 
@@ -60,7 +59,6 @@ etb_in: endpoint {
 	etm@73c000 {
 		compatible = "arm,coresight-etm3x", "arm,primecell";
 		reg = <0x73c000 0x1000>;
-
 		clocks = <&pmc PMC_TYPE_CORE PMC_MCK>;
 		clock-names = "apb_pclk";
 
Signature · 1 line
2.44.0
#5 lore raw

Re: [PATCH 03/13] ARM: dts: microchip: sama5d2: Remove the empty lines 47 and 63

Quoted 13 lines · Mihai Sain

Remove the empty line 47 from etb node.
Remove the empty line 63 from etm node.

---
 arch/arm/boot/dts/microchip/sama5d2.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/microchip/sama5d2.dtsi +0 -0
index 5f8e297e19ed..7aea6c2368a2 100644

arch/arm/boot/dts/microchip/sama5d2.dtsi pmu { · line 47

Quoted 4 lines
arch/arm/boot/dts/microchip/sama5d2.dtsi +0 -1
@@ -44,7 +44,6 @@ pmu {
 	etb@740000 {
 		compatible = "arm,coresight-etb10", "arm,primecell";
 		reg = <0x740000 0x1000>;
-

Do not remove line by line in one patch. This is trivial. One patch per all your boards doing such simple cleanuops.

Your subject already shows the ridiculousness of this split.

Best regards,
Krzysztof

author
#6 lore raw

PATCH 4/13 ARM: dts: microchip: sama5d27_som1_ek: Remove the empty lines

In reply to Mihai Sain

Remove the empty line 482 from gpio-keys node. Remove the empty lines 519,530,542 from regulator nodes.

---
 arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 4 ----
 1 file changed, 4 deletions(-)
arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts +0 -4
index f3ffb8f01d8a..8597e7541dfb 100644
@@ -479,7 +479,6 @@ can1: can@fc050000 {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio_default>;
 
@@ -516,7 +515,6 @@ led-blue {
 
 	vddin_3v3: fixed-regulator-vddin_3v3 {
 		compatible = "regulator-fixed";
-
 		regulator-name = "VDDIN_3V3";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
@@ -527,7 +525,6 @@ vddin_3v3: fixed-regulator-vddin_3v3 {
 
 	vddana: fixed-regulator-vddana {
 		compatible = "regulator-fixed";
-
 		regulator-name = "VDDANA";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
@@ -539,7 +536,6 @@ vddana: fixed-regulator-vddana {
 
 	advref: fixed-regulator-advref {
 		compatible = "regulator-fixed";
-
 		regulator-name = "advref";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
Signature · 1 line
2.44.0
author
#7 lore raw

PATCH 5/13 ARM: dts: microchip: sama5d27_wlsom1_ek: Remove the empty line 31

In reply to Mihai Sain

Remove the empty line 31 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1_ek.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1_ek.dts +0 -1
index 15239834d886..6e485c9be889 100644
@@ -28,7 +28,6 @@ chosen {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio_default>;
 
Signature · 1 line
2.44.0
author
#8 lore raw

PATCH 6/13 ARM: dts: microchip: sama5d29_curiosity: Remove the empty line 48

In reply to Mihai Sain

Remove the empty line 48 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts +0 -1
index 6b02b7bcfd49..79836dd6faa8 100644
@@ -45,7 +45,6 @@ main_xtal {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio_default>;
 
Signature · 1 line
2.44.0
author
#9 lore raw

PATCH 7/13 ARM: dts: microchip: sama5d2_icp: Remove the empty line 47

In reply to Mihai Sain

Remove the empty line 47 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts +0 -1
index 999adeca6f33..6d0551925e63 100644
@@ -44,7 +44,6 @@ main_xtal {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio_default>;
 
Signature · 1 line
2.44.0
author
#10 lore raw

PATCH 8/13 ARM: dts: microchip: sama5d2_ptc_ek: Remove the empty line 401

In reply to Mihai Sain

Remove the empty line 401 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts +0 -1
index 200b20515ab1..e46a6357668e 100644
@@ -398,7 +398,6 @@ pinctrl_usba_vbus: usba_vbus {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio_default>;
 
Signature · 1 line
2.44.0
author
#11 lore raw

PATCH 9/13 ARM: dts: microchip: sama5d2_xplained: Remove the empty line 710

In reply to Mihai Sain

Remove the empty line 710 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts +0 -1
index 6680031387e8..ae7fcbe2436b 100644
@@ -707,7 +707,6 @@ can1: can@fc050000 {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio_default>;
 
Signature · 1 line
2.44.0
author
#12 lore raw

PATCH 10/13 ARM: dts: microchip: sama5d3_eds: Remove the empty line 24

In reply to Mihai Sain

Remove the empty line 24 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts +0 -1
index c287b03d768b..094ce5751956 100644
@@ -21,7 +21,6 @@ chosen {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio>;
 
Signature · 1 line
2.44.0
author
#13 lore raw

PATCH 11/13 ARM: dts: microchip: sama5d3_xplained: Remove the empty line 377

In reply to Mihai Sain

Remove the empty line 377 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts +0 -1
index 820033727088..185f8cf84735 100644
@@ -374,7 +374,6 @@ vcc_mmc0_reg: fixedregulator_mmc0 {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio>;
 
Signature · 1 line
2.44.0
author
#14 lore raw

PATCH 12/13 ARM: dts: microchip: sama5d4_xplained: Remove the empty line 247

In reply to Mihai Sain

Remove the empty line 247 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d4_xplained.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d4_xplained.dts +0 -1
index 95d701d13fef..a4c71dd96738 100644
@@ -244,7 +244,6 @@ rootfs@800000 {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio>;
 
Signature · 1 line
2.44.0
author
#15 lore raw

PATCH 13/13 ARM: dts: microchip: sama5d4ek: Remove the empty line 274

In reply to Mihai Sain

Remove the empty line 274 from gpio-keys node.

---
 arch/arm/boot/dts/microchip/at91-sama5d4ek.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/microchip/at91-sama5d4ek.dts +0 -1
index 20ac775059ca..6e59315249db 100644
@@ -271,7 +271,6 @@ rootfs@800000 {
 
 	gpio-keys {
 		compatible = "gpio-keys";
-
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_key_gpio>;
 
Signature · 1 line
2.44.0
#16 lore raw
In reply to Mihai Sain
Quoted 16 lines · Mihai Sain

This patch series removes the empty lines from sama5 and sama7 DT files.

Mihai Sain (13):
ARM: dts: microchip: sama7g5ek: Remove the empty line 50
ARM: dts: microchip: sama7g5: Remove the empty line 139
ARM: dts: microchip: sama5d2: Remove the empty lines 47 and 63
ARM: dts: microchip: sama5d27_som1_ek: Remove the empty lines
ARM: dts: microchip: sama5d27_wlsom1_ek: Remove the empty line 31
ARM: dts: microchip: sama5d29_curiosity: Remove the empty line 48
ARM: dts: microchip: sama5d2_icp: Remove the empty line 47
ARM: dts: microchip: sama5d2_ptc_ek: Remove the empty line 401
ARM: dts: microchip: sama5d2_xplained: Remove the empty line 710
ARM: dts: microchip: sama5d3_eds: Remove the empty line 24
ARM: dts: microchip: sama5d3_xplained: Remove the empty line 377
ARM: dts: microchip: sama5d4_xplained: Remove the empty line 247
ARM: dts: microchip: sama5d4ek: Remove the empty line 274

NAK for entire patchset.

Best regards,
Krzysztof

#17 lore raw
In reply to Mihai Sain
Quoted 17 lines · Mihai Sain

This patch series removes the empty lines from sama5 and sama7 DT files.

Mihai Sain (13):
ARM: dts: microchip: sama7g5ek: Remove the empty line 50
ARM: dts: microchip: sama7g5: Remove the empty line 139
ARM: dts: microchip: sama5d2: Remove the empty lines 47 and 63
ARM: dts: microchip: sama5d27_som1_ek: Remove the empty lines
ARM: dts: microchip: sama5d27_wlsom1_ek: Remove the empty line 31
ARM: dts: microchip: sama5d29_curiosity: Remove the empty line 48
ARM: dts: microchip: sama5d2_icp: Remove the empty line 47
ARM: dts: microchip: sama5d2_ptc_ek: Remove the empty line 401
ARM: dts: microchip: sama5d2_xplained: Remove the empty line 710
ARM: dts: microchip: sama5d3_eds: Remove the empty line 24
ARM: dts: microchip: sama5d3_xplained: Remove the empty line 377
ARM: dts: microchip: sama5d4_xplained: Remove the empty line 247
ARM: dts: microchip: sama5d4ek: Remove the empty line 274

Quoted 14 lines
 arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts   | 4 ----
 arch/arm/boot/dts/microchip/at91-sama5d27_wlsom1_ek.dts | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d29_curiosity.dts | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts        | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d2_ptc_ek.dts     | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d2_xplained.dts   | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts        | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d3_xplained.dts   | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d4_xplained.dts   | 1 -
 arch/arm/boot/dts/microchip/at91-sama5d4ek.dts          | 1 -
 arch/arm/boot/dts/microchip/at91-sama7g5ek.dts          | 1 -
 arch/arm/boot/dts/microchip/sama5d2.dtsi                | 2 --
 arch/arm/boot/dts/microchip/sama7g5.dtsi                | 1 -
 13 files changed, 17 deletions(-)

Please squash all of these in a single commit.

Quoted 6 lines

base-commit: e8c39d0f57f358950356a8e44ee5159f57f86ec5

Signature · 1 line
2.44.0
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com