Skip to contentSkip to conversation

jemalloc: Update to tip of dev branch

PATCH In review Khem Raj 2 participants 4 messages Apr 12, 2024 – Apr 16, 2024

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 jemalloc: Update to tip of dev branch

This fixes bunch of ptest failures
Failed ptests:
{'jemalloc': ['test_alignment_errors', 'test_oom_errors']}

---
 meta-oe/recipes-devtools/jemalloc/jemalloc_5.3.0.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta-oe/recipes-devtools/jemalloc/jemalloc_5.3.0.bb +3 -3
index df499fbe50..7e0272f898 100644
@@ -13,10 +13,10 @@ SECTION = "libs"
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=ea061f8731d5e6a5761dfad951ef5f5f"
 
-SRC_URI = "git://github.com/jemalloc/jemalloc.git;branch=master;protocol=https \
+SRC_URI = "git://github.com/jemalloc/jemalloc.git;branch=dev;protocol=https \
            file://run-ptest \
            "
-SRCREV = "54eaed1d8b56b1aa528be3bdd1877e59c56fa90c"
+SRCREV = "630434bb0ac619f7beec927569782d924c459385"
 
 S = "${WORKDIR}/git"
 
@@ -27,7 +27,7 @@ EXTRA_AUTORECONF += "--exclude=autoheader"
 EXTRA_OECONF:append:libc-musl = " --with-jemalloc-prefix=je_"
 # For some reason VERSION file populated only in tarball distribution.
 # Adding jemalloc version since this recipe is using source code from git tag
-EXTRA_OECONF:append = " --with-version=${PV}-0-g${SRCREV}"
+EXTRA_OECONF:append = " --with-version=${PV}-0-g${SRCREV} --enable-xmalloc"
 
 do_install:append() {
 	sed -i -e 's@${STAGING_DIR_HOST}@@g' \
Signature · 1 line
2.44.0
author
#2 lore raw
Quoted 7 lines · Peter

Hello,

Could we revert this patch together with related part of related commit?
https://git.openembedded.org/meta-openembedded/commit/?h=scarthgap&id=92bcaa8c1b5f7e2bdd607eafe59ea2d5799ba7d6

Dev branch is unstable and not really suitable for new LTS release.

Last few releases have come of dev branch, so it is mainstream AFAICT, secondly, this fixes otherwise failing ptests with older versions so unit test wise it should be more sound.

Are there any other reasons you have in mind that we may not want it ?

Quoted 3 lines

Thanks for considering this.
Peter

#3 lore raw

-----Original Message-----
From: Khem Raj <[email protected]>
Sent: Tuesday, April 16, 2024 19:57
To: Marko, Peter (ADV D EU SK BFS1) <[email protected]>
Cc: [email protected]
Subject: Re: [oe] [meta-oe][PATCH] jemalloc: Update to tip of dev branch

Quoted 8 lines · Peter
Quoted 7 lines

Hello,

Could we revert this patch together with related part of related commit?
https://git.openembedded.org/meta-openembedded/commit/?h=scarthgap&id=
92bcaa8c1b5f7e2bdd607eafe59ea2d5799ba7d6

Quoted 5 lines
Quoted 1 line

Dev branch is unstable and not really suitable for new LTS release.

Last few releases have come of dev branch, so it is mainstream AFAICT, secondly, this fixes otherwise failing ptests with older versions so unit test wise it should be more sound.

Are there any other reasons you have in mind that we may not want it ?

No, I'm just verifying versions during upgrade to new LTS.

Quoted 4 lines
Quoted 4 lines

Thanks for considering this.
Peter