Skip to contentSkip to conversation

misc: sgi_gru: fix Kconfig option text

PATCH New Prasad Pandit 1 participant 3 messages Apr 12, 2024 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

v3 cover misc: sgi_gru: fix Kconfig option text

From: Prasad Pandit <[email protected]>

Hi,

This patch series properly indents help text of config option and removes a redundant default value attribute.

Thank you.
---
Prasad Pandit (2):
misc: sgi_gru: indent SGI_GRU option help text
misc: sgi_gru: remove default attribute of LATTICE_ECP3_CONFIG

 drivers/misc/Kconfig | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)
Signature · 1 line
2.44.0
#1 lore raw

PATCH v3 1/2 misc: sgi_gru: indent SGI_GRU option help text

From: Prasad Pandit <[email protected]>

Fix indentation of SGI_GRU option's help text by adding leading spaces. Generally help text is indented by two more spaces beyond the leading tab <\t> character. It helps Kconfig parsers to read file without error.

---
 drivers/misc/Kconfig | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

v3:
- split patch in two, remove 'default n' attribute
v2:
- CC public mailing list
- https://lore.kernel.org/linux-kernel/[email protected]/T/#t
v1:
- s/\t/ / at line #431
- Private mail to maintainers in MAINTAINERS
v0:
- private mail to maintainers in MAINTAINERS

drivers/misc/Kconfig +9 -9
index 4fb291f0bf7c..04df5a0ee931 100644
@@ -293,21 +293,21 @@ config SGI_GRU
 	depends on X86_UV && SMP
 	select MMU_NOTIFIER
 	help
-	The GRU is a hardware resource located in the system chipset. The GRU
-	contains memory that can be mmapped into the user address space. This memory is
-	used to communicate with the GRU to perform functions such as load/store,
-	scatter/gather, bcopy, AMOs, etc.  The GRU is directly accessed by user
-	instructions using user virtual addresses. GRU instructions (ex., bcopy) use
-	user virtual addresses for operands.
+	  The GRU is a hardware resource located in the system chipset. The GRU
+	  contains memory that can be mmapped into the user address space.
+	  This memory is used to communicate with the GRU to perform functions
+	  such as load/store, scatter/gather, bcopy, AMOs, etc.  The GRU is
+	  directly accessed by user instructions using user virtual addresses.
+	  GRU instructions (ex., bcopy) use user virtual addresses for operands.
 
-	If you are not running on a SGI UV system, say N.
+	  If you are not running on a SGI UV system, say N.
 
 config SGI_GRU_DEBUG
 	bool  "SGI GRU driver debug"
 	depends on SGI_GRU
 	help
-	This option enables additional debugging code for the SGI GRU driver.
-	If you are unsure, say N.
+	  This option enables additional debugging code for the SGI GRU driver.
+	  If you are unsure, say N.
 
 config APDS9802ALS
 	tristate "Medfield Avago APDS9802 ALS Sensor module"
Signature · 1 line
2.44.0
#2 lore raw

PATCH v3 2/2 misc: sgi_gru: remove default attribute of LATTICE_ECP3_CONFIG

In reply to Prasad Pandit

From: Prasad Pandit <[email protected]>

Remove 'default n' attribute of 'LATTICE_ECP3_CONFIG' option because it is redundant. 'n' is automatic default value when one is not specified.

---
 drivers/misc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

v3:
- remove 'default n' attribute
- https://lore.kernel.org/linux-kernel/[email protected]/T/#t

drivers/misc/Kconfig +0 -1
index 04df5a0ee931..b8f8461edfed 100644
@@ -428,7 +428,6 @@ config LATTICE_ECP3_CONFIG
 	tristate "Lattice ECP3 FPGA bitstream configuration via SPI"
 	depends on SPI && SYSFS
 	select FW_LOADER
-	default	n
 	help
 	  This option enables support for bitstream configuration (programming
 	  or loading) of the Lattice ECP3 FPGA family via SPI.
Signature · 1 line
2.44.0