Skip to contentSkip to conversation

drm/amdgpu: Support setting reset_method at runtime

PATCH In review Stanley.Yang 2 participants 4 messages Apr 12, 2024 – Apr 17, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Support setting reset_method at runtime

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
index 80b9642f2bc4..5f5bf0c26b1f 100644
@@ -915,7 +915,7 @@ module_param_named(freesync_video, amdgpu_freesync_vid_mode, uint, 0444);
  * GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco)
  */
 MODULE_PARM_DESC(reset_method, "GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco/bamaco)");
-module_param_named(reset_method, amdgpu_reset_method, int, 0444);
+module_param_named(reset_method, amdgpu_reset_method, int, 0644);
 
 /**
  * DOC: bad_page_threshold (int) Bad page threshold is specifies the
Signature · 1 line
2.25.1
#1 lore raw

[AMD Official Use Only - General]

Ping...

Regards,
Stanley

Quoted 32 lines

-----Original Message-----
From: Yang, Stanley <[email protected]>
Sent: Friday, April 12, 2024 2:21 PM
To: [email protected]
Cc: Yang, Stanley <[email protected]>
Subject: [PATCH Review 1/1] drm/amdgpu: Support setting reset_method at runtime

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -0
index 80b9642f2bc4..5f5bf0c26b1f 100644
@@ -915,7 +915,7 @@ module_param_named(freesync_video,
 amdgpu_freesync_vid_mode, uint, 0444);
  * GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 =
 mode2, 4 = baco)
  */
 MODULE_PARM_DESC(reset_method, "GPU reset method (-1 = auto (default), 0

= legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco/bamaco)"); - module_param_named(reset_method, amdgpu_reset_method, int, 0444); +module_param_named(reset_method, amdgpu_reset_method, int, 0644);

/**
* DOC: bad_page_threshold (int) Bad page threshold is specifies the
--
2.25.1

#2 lore raw
In reply to Stanley.Yang

Am 12.04.24 um 08:21 schrieb Stanley.Yang:

Quoted 1 line

You are missing a commit message, without it the patch will automatically be rejected when you try to push it.

With that added Reviewed-by: Christian König <[email protected]>

Quoted 17 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
index 80b9642f2bc4..5f5bf0c26b1f 100644
@@ -915,7 +915,7 @@ module_param_named(freesync_video, amdgpu_freesync_vid_mode, uint, 0444);
   * GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco)
   */
  MODULE_PARM_DESC(reset_method, "GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco/bamaco)");
-module_param_named(reset_method, amdgpu_reset_method, int, 0444);
+module_param_named(reset_method, amdgpu_reset_method, int, 0644);
 
  /**
   * DOC: bad_page_threshold (int) Bad page threshold is specifies the
#3 lore raw

[AMD Official Use Only - General]

Quoted 7 lines

-----Original Message-----
From: Christian König <[email protected]>
Sent: Wednesday, April 17, 2024 8:46 PM
To: Yang, Stanley <[email protected]>; [email protected]
Subject: Re: [PATCH Review 1/1] drm/amdgpu: Support setting reset_method at runtime

Quoted 5 lines

Am 12.04.24 um 08:21 schrieb Stanley.Yang:

Quoted 1 line

You are missing a commit message, without it the patch will automatically be rejected when you try to push it.

Thank you Chris, will add it before push.

Regards,
Stanley

Quoted 26 lines

With that added Reviewed-by: Christian König <[email protected]>

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c module_param_named(freesync_video,

Quoted 10 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -0
index 80b9642f2bc4..5f5bf0c26b1f 100644
@@ -915,7 +915,7 @@ module_param_named(freesync_video,

amdgpu_freesync_vid_mode, uint, 0444);

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c module_param_named(freesync_video, · line 915

Quoted 1 line
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -0
   * GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1,

3 = mode2, 4 = baco)

Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -0
   */
  MODULE_PARM_DESC(reset_method, "GPU reset method (-1 = auto

(default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco/bamaco)"); -module_param_named(reset_method,

amdgpu_reset_method,

Quoted 5 lines

int, 0444);
+module_param_named(reset_method, amdgpu_reset_method, int, 0644);

/**
* DOC: bad_page_threshold (int) Bad page threshold is specifies the