Skip to contentSkip to conversation

drm/amdgpu: add missing vbios version from devcoredump

PATCH In review Sunil Khatri 2 participants 2 messages Apr 12, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: add missing vbios version from devcoredump

Add vbios version in the devcoredump along with formatting the information with proper alignment.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c +5 -4
index 1129e5e5fb42..64fe564b8036 100644
@@ -188,10 +188,11 @@ static void amdgpu_devcoredump_fw_info(struct amdgpu_device *adev,
 		   adev->vpe.feature_version, adev->vpe.fw_version);
 
 	drm_printf(p, "\nVBIOS Information\n");
-	drm_printf(p, "name: %s\n", ctx->name);
-	drm_printf(p, "pn %s\n", ctx->vbios_pn);
-	drm_printf(p, "version: %s\n", ctx->vbios_ver_str);
-	drm_printf(p, "date: %s\n", ctx->date);
+	drm_printf(p, "vbios name       : %s\n", ctx->name);
+	drm_printf(p, "vbios pn         : %s\n", ctx->vbios_pn);
+	drm_printf(p, "vbios version    : %d\n", ctx->version);
+	drm_printf(p, "vbios ver_str    : %s\n", ctx->vbios_ver_str);
+	drm_printf(p, "vbios date       : %s\n", ctx->date);
 }
 
 static ssize_t
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 32 lines · Sunil Khatri

Add vbios version in the devcoredump along with formatting the information with proper alignment.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c +5 -5
index 1129e5e5fb42..64fe564b8036 100644
@@ -188,10 +188,11 @@ static void amdgpu_devcoredump_fw_info(struct amdgpu_device *adev,
                   adev->vpe.feature_version, adev->vpe.fw_version);
 
        drm_printf(p, "\nVBIOS Information\n");
-       drm_printf(p, "name: %s\n", ctx->name);
-       drm_printf(p, "pn %s\n", ctx->vbios_pn);
-       drm_printf(p, "version: %s\n", ctx->vbios_ver_str);
-       drm_printf(p, "date: %s\n", ctx->date);
+       drm_printf(p, "vbios name       : %s\n", ctx->name);
+       drm_printf(p, "vbios pn         : %s\n", ctx->vbios_pn);
+       drm_printf(p, "vbios version    : %d\n", ctx->version);
+       drm_printf(p, "vbios ver_str    : %s\n", ctx->vbios_ver_str);
+       drm_printf(p, "vbios date       : %s\n", ctx->date);
 }
 
 static ssize_t
--

2.34.1