Skip to contentSkip to conversation

dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property

PATCH In review Robert Marko 5 participants 9 messages Apr 12, 2024 – Apr 16, 2024

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: net: wireless: ath11k: add ieee80211-freq-limit property

This is an existing optional property that ieee80211.yaml/cfg80211 provides. It's useful to further restrict supported frequencies for a specified device through device-tree.

---
 .../devicetree/bindings/net/wireless/qcom,ath11k.yaml          | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +3 -0
index 672282cdfc2f..907bbb646614 100644
@@ -55,6 +55,8 @@ properties:
       phandle to a node describing reserved memory (System RAM memory)
       used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt)
 
+  ieee80211-freq-limit: true
+
   iommus:
     minItems: 1
     maxItems: 2
@@ -88,6 +90,7 @@ required:
 additionalProperties: false
 
 allOf:
+  - $ref: ieee80211.yaml#
   - if:
       properties:
         compatible:
Signature · 1 line
2.44.0
#1 lore raw

PATCH 2/2 wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

The common DT property can be used to limit the available channels but ath11k has to manually call wiphy_read_of_freq_limits().

---
 drivers/net/wireless/ath/ath11k/mac.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath11k/mac.c +1 -0
index c32be587000d..59bde128d351 100644
@@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
 	if (ret)
 		goto err;
 
+	wiphy_read_of_freq_limits(ar->hw->wiphy);
 	ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
 	ath11k_mac_setup_he_cap(ar, cap);
 
Signature · 1 line
2.44.0
#2 lore raw

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

Quoted 4 lines · Robert Marko

The common DT property can be used to limit the available channels but ath11k has to manually call wiphy_read_of_freq_limits().

I've seen this before.

https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/

(dt-binding too. it has/had an ack)
https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/

sooo.... this is awkward.

Quoted 16 lines
---
  drivers/net/wireless/ath/ath11k/mac.c | 1 +
  1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath11k/mac.c +1 -0
index c32be587000d..59bde128d351 100644
@@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
  	if (ret)
  		goto err;
 
+	wiphy_read_of_freq_limits(ar->hw->wiphy);
  	ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
  	ath11k_mac_setup_he_cap(ar, cap);
 
#3 lore raw

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

Quoted 7 lines · Christian Lamparter
Quoted 4 lines · Robert Marko

The common DT property can be used to limit the available channels but ath11k has to manually call wiphy_read_of_freq_limits().

Quoted 8 lines

I've seen this before.

https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/

(dt-binding too. it has/had an ack)
https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/

sooo.... this is awkward.

Definitively,
I completely missed your patch set and we needed this in OpenWrt.

You were, first so your patch set should be applied.

Regards,
Robert

Quoted 18 lines
Quoted 17 lines
---
  drivers/net/wireless/ath/ath11k/mac.c | 1 +
  1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath11k/mac.c +1 -0
index c32be587000d..59bde128d351 100644
@@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
      if (ret)
              goto err;
 
+     wiphy_read_of_freq_limits(ar->hw->wiphy);
      ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
      ath11k_mac_setup_he_cap(ar, cap);
 
#4 lore raw

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

In reply to Christian Lamparter
Quoted 6 lines · Christian Lamparter
Quoted 4 lines · Robert Marko

The common DT property can be used to limit the available channels but ath11k has to manually call wiphy_read_of_freq_limits().

Quoted 8 lines

I've seen this before.

https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/

(dt-binding too. it has/had an ack)
https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/

sooo.... this is awkward.

Patchwork indicates Changes Requested
Any idea what changes Kalle is looking for?

#5 lore raw

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

Quoted 11 lines · Jeff Johnson
Quoted 10 lines · Christian Lamparter
Quoted 4 lines · Robert Marko

The common DT property can be used to limit the available channels but ath11k has to manually call wiphy_read_of_freq_limits().

I've seen this before.

https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/

Quoted 7 lines
Quoted 4 lines

(dt-binding too. it has/had an ack)
https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/

sooo.... this is awkward.

Patchwork indicates Changes Requested
Any idea what changes Kalle is looking for?

I can't remember anymore but most likely I assumed based on Krzysztof's comments there will be v3 and missed that Conor already had acked it. Sorry about that, I set Christian's patches to New state now so that they are back in queue. And I'll drop Robert patches. Does this sound ok to everyone?

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#6 lore raw

Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

Quoted 19 lines · Kalle Valo
Quoted 16 lines · Jeff Johnson
Quoted 14 lines · Christian Lamparter
Quoted 4 lines · Robert Marko

The common DT property can be used to limit the available channels but ath11k has to manually call wiphy_read_of_freq_limits().

I've seen this before.

https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/

(dt-binding too. it has/had an ack)
https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/

sooo.... this is awkward.

Quoted 8 lines
Quoted 2 lines

Patchwork indicates Changes Requested
Any idea what changes Kalle is looking for?

I can't remember anymore but most likely I assumed based on Krzysztof's comments there will be v3 and missed that Conor already had acked it. Sorry about that, I set Christian's patches to New state now so that they are back in queue. And I'll drop Robert patches. Does this sound ok to everyone?

Sounds good to me, thanks for looking into it.

Regards,
Robert

Quoted 5 lines

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

maintainer
#7 lore raw
In reply to Robert Marko
Quoted 14 lines · Robert Marko

This is an existing optional property that ieee80211.yaml/cfg80211 provides. It's useful to further restrict supported frequencies for a specified device through device-tree.

---
 .../devicetree/bindings/net/wireless/qcom,ath11k.yaml          | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +0 -0
index 672282cdfc2f..907bbb646614 100644

Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml properties: · line 59

Quoted 5 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +2 -0
@@ -55,6 +55,8 @@ properties:
       phandle to a node describing reserved memory (System RAM memory)
       used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt)
 
+  ieee80211-freq-limit: true
+

Drop this and change additionalProperties to unevaluatedProperties.

Quoted 14 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +1 -0
   iommus:
     minItems: 1
     maxItems: 2
@@ -88,6 +90,7 @@ required:
 additionalProperties: false
 
 allOf:
+  - $ref: ieee80211.yaml#
   - if:
       properties:
         compatible:
Signature · 1 line
2.44.0
#8 lore raw
Quoted 19 lines · Rob Herring
Quoted 17 lines · Robert Marko

This is an existing optional property that ieee80211.yaml/cfg80211 provides. It's useful to further restrict supported frequencies for a specified device through device-tree.

---
 .../devicetree/bindings/net/wireless/qcom,ath11k.yaml          | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +0 -0
index 672282cdfc2f..907bbb646614 100644
@@ -55,6 +55,8 @@ properties:
       phandle to a node describing reserved memory (System RAM memory)
       used by ath11k firmware (see bindings/reserved-memory/reserved-memory.txt)
 
Quoted 4 lines

Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml properties: · line 59

Quoted 2 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +2 -0
+  ieee80211-freq-limit: true
+

Drop this and change additionalProperties to unevaluatedProperties.

Hi Rob,
This patch series has been dropped as Christian already proposed the same before and it was reviewed.

Regards,
Robert

Quoted 15 lines
Quoted 15 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +1 -1
   iommus:
     minItems: 1
     maxItems: 2
@@ -88,6 +90,7 @@ required:
 additionalProperties: false
 
 allOf:
+  - $ref: ieee80211.yaml#
   - if:
       properties:
         compatible:
--

2.44.0