Skip to contentSkip to conversation

serial: 8250_dw: Hide a cast in dw8250_serial_inq()

PATCH New Andy Shevchenko 1 participant 1 message Apr 12, 2024

Subsystems (3)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 serial: 8250_dw: Hide a cast in dw8250_serial_inq()

dw8250_serial_inq() uses unsigned int variable to store 8-bit value. Due to that it needs a cast which can be avoided by switching to use u8 instead of unsigned int.

---
 drivers/tty/serial/8250/8250_dw.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/tty/serial/8250/8250_dw.c +1 -3
index 1e81024f8fd3..ba9f4dc4e71d 100644
@@ -185,9 +185,7 @@ static unsigned int dw8250_serial_in(struct uart_port *p, int offset)
 #ifdef CONFIG_64BIT
 static unsigned int dw8250_serial_inq(struct uart_port *p, int offset)
 {
-	unsigned int value;
-
-	value = (u8)__raw_readq(p->membase + (offset << p->regshift));
+	u8 value = __raw_readq(p->membase + (offset << p->regshift));
 
 	return dw8250_modify_msr(p, offset, value);
 }
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac