Skip to contentSkip to conversation

iio: adc: ad_sigma_delta: Clear pending interrupts before enable

PATCH In review Markus Burri 3 participants 4 messages Apr 4, 2024 – Apr 13, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: adc: ad_sigma_delta: Clear pending interrupts before enable

For device will enable and disable irq contiously like AD7195,
it use DOUT/RDY pin for both SPI transfer and data ready.
It will disable irq during SPI transfer, and re-eanble irq after SPI transfer. That may cause irq status bit set to 1 during spi transfer.

When the active condition has been detected, the corresponding bit remains set until cleared by software. Status flags are cleared by writing a 1 to the corresponding bit position.

---
 drivers/iio/adc/ad_sigma_delta.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/iio/adc/ad_sigma_delta.c +4 -0
index a602429cdde4..59544c39642a 100644
@@ -515,6 +515,10 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void *p)
 
 irq_handled:
 	iio_trigger_notify_done(indio_dev->trig);
+	/*
+	 * ACK pending interrupts from spi transfer.
+	 */
+	irq_gc_ack_set_bit(irq_get_irq_data(sigma_delta->spi->irq));
 	sigma_delta->irq_dis = false;
 	enable_irq(sigma_delta->spi->irq);
 
Signature · 1 line
2.39.2
maintainer
#1 lore raw

On Thu, 4 Apr 2024 19:51:26 +0200
Markus Burri <[email protected]> wrote:

Hi Markus,

Quoted 4 lines

For device will enable and disable irq contiously like AD7195,
it use DOUT/RDY pin for both SPI transfer and data ready.
It will disable irq during SPI transfer, and re-eanble irq after SPI transfer. That may cause irq status bit set to 1 during spi transfer.

Superficially that sounds like it might be an irq driver bug to me... Or just possibly an irq chip doing lazy disabling?

Quoted 6 lines

When the active condition has been detected, the corresponding bit remains set until cleared by software. Status flags are cleared by writing a 1 to the corresponding bit position.

I'll need an appropriate ADI ack for this one.

It seems highly unusual to be calling a generic irqchip related function in a driver (there are no other such users). So this seems unlikely to be the right fix for this particular problem.

Quoted 9 lines
---
 drivers/iio/adc/ad_sigma_delta.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/iio/adc/ad_sigma_delta.c +0 -0
index a602429cdde4..59544c39642a 100644

drivers/iio/adc/ad_sigma_delta.c static irqreturn_t ad_sd_trigger_handler(int irq, void *p) · line 519

Quoted 5 lines
drivers/iio/adc/ad_sigma_delta.c +2 -0
@@ -515,6 +515,10 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void *p)
 
 irq_handled:
 	iio_trigger_notify_done(indio_dev->trig);
+	/*
+	 * ACK pending interrupts from spi transfer.

Single line comment format would be fine here.

Quoted 5 lines
drivers/iio/adc/ad_sigma_delta.c +2 -0
+	 */
+	irq_gc_ack_set_bit(irq_get_irq_data(sigma_delta->spi->irq));
 	sigma_delta->irq_dis = false;
 	enable_irq(sigma_delta->spi->irq);
 
#2 lore raw
Quoted 6 lines · Jonathan Cameron

On Thu,  4 Apr 2024 19:51:26 +0200
Markus Burri <[email protected]> wrote:

Hi Markus,

Quoted 8 lines
Quoted 5 lines

For device will enable and disable irq contiously like AD7195, it use DOUT/RDY pin for both SPI transfer and data ready. It will disable irq during SPI transfer, and re-eanble irq after SPI transfer.
That may cause irq status bit set to 1 during spi transfer.

Superficially that sounds like it might be an irq driver bug to me... Or just possibly an irq chip doing lazy disabling?

Yes, this sounds odd as we are already explicitly disabling lazy disabling:

https://elixir.bootlin.com/linux/latest/source/drivers/iio/adc/ad_sigma_delta.c#L589

Quoted 10 lines
Quoted 7 lines

When the active condition has been detected, the corresponding bit remains set until cleared by software. Status flags are cleared by writing a 1 to the corresponding bit position.

I'll need an appropriate ADI ack for this one.

Yeah, I wanted to reply to this one Friday but then completely forgot. I can't really ack this one. I would need some insights from someone with more core IRQ knowledge. But...

Quoted 4 lines

It seems highly unusual to be calling a generic irqchip related function in a driver (there are no other such users).  So this seems unlikely to be the right fix for this particular problem.

Yes, and this (I think) would not even fix (if a fix is needed) this for all irqchips which to me already sounds not the way to go.

- Nuno Sá

Quoted 1 line
maintainer
#3 lore raw
Quoted 13 lines · On Mon, 08 Apr 2024 10:31:21 +0200 Nuno Sá <[email protected]> wrote:
Quoted 12 lines · Jonathan Cameron

On Thu,  4 Apr 2024 19:51:26 +0200
Markus Burri <[email protected]> wrote:

Hi Markus,

Quoted 5 lines

For device will enable and disable irq contiously like AD7195, it use DOUT/RDY pin for both SPI transfer and data ready. It will disable irq during SPI transfer, and re-eanble irq after SPI transfer.
That may cause irq status bit set to 1 during spi transfer.

Quoted 6 lines
Quoted 2 lines

Superficially that sounds like it might be an irq driver bug to me... Or just possibly an irq chip doing lazy disabling?

Yes, this sounds odd as we are already explicitly disabling lazy disabling:

https://elixir.bootlin.com/linux/latest/source/drivers/iio/adc/ad_sigma_delta.c#L589

Markus, can you confirm you are running no a kernel with that line present? Maybe this is just an old kernel not having the fix?

Quoted 26 lines
Quoted 11 lines
Quoted 8 lines

When the active condition has been detected, the corresponding bit remains set until cleared by software. Status flags are cleared by writing a 1 to the corresponding bit position.

I'll need an appropriate ADI ack for this one.

Yeah, I wanted to reply to this one Friday but then completely forgot. I can't really ack this one. I would need some insights from someone with more core IRQ knowledge. But...

Quoted 4 lines

It seems highly unusual to be calling a generic irqchip related function in a driver (there are no other such users).  So this seems unlikely to be the right fix for this particular problem.

Yes, and this (I think) would not even fix (if a fix is needed) this for all irqchips which to me already sounds not the way to go.

- Nuno Sá

Quoted 1 line