Skip to contentSkip to conversation

ASoC: wcd934x: Drop unneeded MODULE_ALIAS

PATCH In review Krzysztof Kozlowski 2 participants 3 messages Apr 14, 2024 – Apr 15, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ASoC: wcd934x: Drop unneeded MODULE_ALIAS

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated.

---
 sound/soc/codecs/wcd934x.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/wcd934x.c +0 -1
index 6813268e6a19..de870c7819ca 100644
@@ -5967,7 +5967,6 @@ static struct platform_driver wcd934x_codec_driver = {
 	}
 };
 
-MODULE_ALIAS("platform:wcd934x-codec");
 module_platform_driver(wcd934x_codec_driver);
 MODULE_DESCRIPTION("WCD934x codec driver");
 MODULE_LICENSE("GPL v2");
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 ASoC: samsung: i2s: Drop unneeded MODULE_ALIAS

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated.

---
 sound/soc/samsung/i2s.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/samsung/i2s.c +0 -1
index 9552748aea2e..1bcabb114e29 100644
@@ -1755,5 +1755,4 @@ module_platform_driver(samsung_i2s_driver);
 /* Module information */
 MODULE_AUTHOR("Jaswinder Singh, <[email protected]>");
 MODULE_DESCRIPTION("Samsung I2S Interface");
-MODULE_ALIAS("platform:samsung-i2s");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.34.1
maintainer
#2 lore raw
In reply to Krzysztof Kozlowski
Quoted 5 lines · Krzysztof Kozlowski

The ID table already has respective entry and MODULE_DEVICE_TABLE and creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: wcd934x: Drop unneeded MODULE_ALIAS

      commit: 615169c727b13ff4ec6c43b62501f73f9f88a11a
[2/2] ASoC: samsung: i2s: Drop unneeded MODULE_ALIAS
      commit: 9d85ec4e91e354ed2d8291e1ea3ba76e660205a0

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark