Skip to contentSkip to conversation

media: ov2680: Do not fail if data-lanes property is absent

PATCH In review Fabio Estevam 2 participants 2 messages Apr 14, 2024 – Apr 15, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: ov2680: Do not fail if data-lanes property is absent

From: Fabio Estevam <[email protected]>

Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification") the ov2680 driver no longer probes when the 'data-lanes' property is absent.

The OV2680 sensor has only one data lane, so there is no need for describing it the devicetree.

Remove the unnecessary data-lanes property check.

Fixes 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification")
---
 drivers/media/i2c/ov2680.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/media/i2c/ov2680.c +0 -7
index a857763c7984..4577a8977c85 100644
@@ -1116,13 +1116,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
 	sensor->pixel_rate = sensor->link_freq[0] * 2;
 	do_div(sensor->pixel_rate, 10);
 
-	/* Verify bus cfg */
-	if (bus_cfg.bus.mipi_csi2.num_data_lanes != 1) {
-		ret = dev_err_probe(dev, -EINVAL,
-				    "only a 1-lane CSI2 config is supported");
-		goto out_free_bus_cfg;
-	}
-
 	if (!bus_cfg.nr_of_link_frequencies) {
 		dev_warn(dev, "Consider passing 'link-frequencies' in DT\n");
 		goto skip_link_freq_validation;
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi.

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification") the ov2680 driver no longer probes when the 'data-lanes' property is absent.

Quoted 8 lines

The OV2680 sensor has only one data lane, so there is no need for describing it the devicetree.

Remove the unnecessary data-lanes property check.

Fixes 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification")

Thanks, patch looks good to me:

Regards,

Hans

Quoted 22 lines
---
 drivers/media/i2c/ov2680.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/media/i2c/ov2680.c +0 -7
index a857763c7984..4577a8977c85 100644
@@ -1116,13 +1116,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
 	sensor->pixel_rate = sensor->link_freq[0] * 2;
 	do_div(sensor->pixel_rate, 10);
 
-	/* Verify bus cfg */
-	if (bus_cfg.bus.mipi_csi2.num_data_lanes != 1) {
-		ret = dev_err_probe(dev, -EINVAL,
-				    "only a 1-lane CSI2 config is supported");
-		goto out_free_bus_cfg;
-	}
-
 	if (!bus_cfg.nr_of_link_frequencies) {
 		dev_warn(dev, "Consider passing 'link-frequencies' in DT\n");
 		goto skip_link_freq_validation;