media: ov2680: Do not fail if data-lanes property is absent
PATCH 1/1 media: ov2680: Do not fail if data-lanes property is absent
From: Fabio Estevam <[email protected]>
Since commit 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification") the ov2680 driver no longer probes when the 'data-lanes' property is absent.
The OV2680 sensor has only one data lane, so there is no need for describing it the devicetree.
Remove the unnecessary data-lanes property check.
--- drivers/media/i2c/ov2680.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/media/i2c/ov2680.c +0 -7
@@ -1116,13 +1116,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor) sensor->pixel_rate = sensor->link_freq[0 ] *2 ;do_div (sensor->pixel_rate,10 ); -/* Verify bus cfg */ -if (bus_cfg.bus.mipi_csi2.num_data_lanes !=1 ) { - ret =dev_err_probe (dev, -EINVAL , -"only a 1-lane CSI2 config is supported" ); - goto out_free_bus_cfg; - } -if (!bus_cfg.nr_of_link_frequencies) {dev_warn (dev,"Consider passing 'link-frequencies' in DT\n" ); goto skip_link_freq_validation;
Signature · 1 line
2.34.1
Hi.
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
63b0cd30b78e("media: ov2680: Add bus-cfg / endpoint property verification") the ov2680 driver no longer probes when the 'data-lanes' property is absent.
Quoted 8 lines
The OV2680 sensor has only one data lane, so there is no need for describing it the devicetree.
Remove the unnecessary data-lanes property check.
Suggested-by Sakari Ailus <[email protected]>Fixes 63b0cd30b78e ("media: ov2680: Add bus-cfg / endpoint property verification")Signed-off-by Fabio Estevam <[email protected]>
Thanks, patch looks good to me:
Regards,
Hans
Quoted 22 lines
--- drivers/media/i2c/ov2680.c | 7 ------- 1 file changed, 7 deletions(-)drivers/media/i2c/ov2680.c +0
-7@@ -1116,13 +1116,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor) sensor->pixel_rate = sensor->link_freq[0 ] *2 ;do_div (sensor->pixel_rate,10 ); -/* Verify bus cfg */ -if (bus_cfg.bus.mipi_csi2.num_data_lanes !=1 ) { - ret =dev_err_probe (dev, -EINVAL , -"only a 1-lane CSI2 config is supported" ); - goto out_free_bus_cfg; - } -if (!bus_cfg.nr_of_link_frequencies) {dev_warn (dev,"Consider passing 'link-frequencies' in DT\n" ); goto skip_link_freq_validation;