Skip to contentSkip to conversation

dt-bindings: power: supply: max8903: specify flt-gpios as input

PATCH Applied Herman van Hazendonk 3 participants 4 messages Apr 15, 2024 – Apr 30, 2024

Subsystems (2)
Device tree bindings Power supply
lore
Share & tools
lore

Herman van Hazendonk

author
#0 lore raw

PATCH 1/2 dt-bindings: power: supply: max8903: specify flt-gpios as input

The FLT pin was incorrected documented as an output. The MAX8903 uses it to signal to the processor that a charging fault has occurred.

Signed-off-by Herman van Hazendonk <[email protected]>
---
 .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml +1 -1
index a8d625f285f1..86af38378999 100644
@@ -34,7 +34,7 @@ properties:
 
   flt-gpios:
     maxItems: 1
-    description: Fault pin (active low, output)
+    description: Fault pin (active low, input)
 
   dcm-gpios:
     maxItems: 1
#1 lore raw
Quoted 2 lines · Herman van Hazendonk

The FLT pin was incorrected documented as an output. The MAX8903 uses it to signal to the processor that a charging fault has occurred.

I guess this is just a matter of framing? Input to the hardware running the OS but an output from the max8903?

I'm okay with whatever wording causing less confusion, which may mean something that specifics what this is relative to?

Quoted 2 lines
Signed-off-by Herman van Hazendonk <[email protected]>

The SoB email should match the from email fyi.
Cheers,
Conor.

Quoted 17 lines
---
 .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml +1 -1
index a8d625f285f1..86af38378999 100644
@@ -34,7 +34,7 @@ properties:
 
   flt-gpios:
     maxItems: 1
-    description: Fault pin (active low, output)
+    description: Fault pin (active low, input)
 
   dcm-gpios:
     maxItems: 1
#2 lore raw

Hi,

Quoted 9 lines · Conor Dooley
Quoted 2 lines · Herman van Hazendonk

The FLT pin was incorrected documented as an output. The MAX8903 uses it to signal to the processor that a charging fault has occurred.

I guess this is just a matter of framing? Input to the hardware running the OS but an output from the max8903?

I'm okay with whatever wording causing less confusion, which may mean something that specifics what this is relative to?

well, this definitely improves things, since the other GPIOs from the same file are all described with the hardware running the OS being the reference. So this makes things at least uniform.

Quoted 4 lines
Quoted 2 lines
Signed-off-by Herman van Hazendonk <[email protected]>

The SoB email should match the from email fyi.

It does for this patch, so I took it.

Greetings,

-- Sebastian

Quoted 20 lines

Cheers,
Conor.

Quoted 17 lines
---
 .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml +1 -1
index a8d625f285f1..86af38378999 100644
@@ -34,7 +34,7 @@ properties:
 
   flt-gpios:
     maxItems: 1
-    description: Fault pin (active low, output)
+    description: Fault pin (active low, input)
 
   dcm-gpios:
     maxItems: 1
Applied
#3 lore raw
In reply to Herman van Hazendonk
Quoted 4 lines · Herman van Hazendonk

The FLT pin was incorrected documented as an output. The MAX8903 uses it to signal to the processor that a charging fault has occurred.

Applied, thanks!

[1/2] dt-bindings: power: supply: max8903: specify flt-gpios as input

      commit: 55f7073f6f59ef2c9e98b70f74118dba62e1aabc

Best regards,

Signature · 1 line
Sebastian Reichel <[email protected]>