Skip to contentSkip to conversation

Kconfig: some cleanups

PATCH Superseded Michal Simek 5 participants 18 messages Apr 15, 2024 – Apr 16, 2024

Subsystems (8)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Kconfig: some cleanups

I looked as cleaning up some dependencies and I found that qconfig is reporting some issues. This series is fixing some of them. But there are still some other pending. That's why please go and fix them if they are related to your board.

Thanks,
Michal

drivers/pinctrl/intel/Kconfig:12: warning: style: quotes recommended around 'n' in 'bool n'
warning: the choice symbol CPU_ARCEM6 (defined at arch/arc/Kconfig:46) is selected by the following symbols, but select/imply has no effect on choice symbols
- TARGET_EMSDP (defined at arch/arc/Kconfig:173)
- TARGET_IOT_DEVKIT (defined at arch/arc/Kconfig:180)
warning: the choice symbol ARC_MMU_ABSENT (defined at arch/arc/Kconfig:77) is selected by the following symbols, but select/imply has no effect on choice symbols
- CPU_ARCEM6 (defined at arch/arc/Kconfig:46)
- CPU_ARCHS36 (defined at arch/arc/Kconfig:53)
warning: the choice symbol ARC_MMU_V2 (defined at arch/arc/Kconfig:82) is selected by the following symbols, but select/imply has no effect on choice symbols
- CPU_ARC750D (defined at arch/arc/Kconfig:32)
warning: the choice symbol ARC_MMU_V3 (defined at arch/arc/Kconfig:89) is selected by the following symbols, but select/imply has no effect on choice symbols
- CPU_ARC770D (defined at arch/arc/Kconfig:39)
warning: the choice symbol ARC_MMU_V4 (defined at arch/arc/Kconfig:97) is selected by the following symbols, but select/imply has no effect on choice symbols
- CPU_ARCHS38 (defined at arch/arc/Kconfig:60)
warning: the choice symbol FSP_VERSION2 (defined at arch/x86/Kconfig:396) is selected by the following symbols, but select/imply has no effect on choice symbols
- INTEL_APOLLOLAKE (defined at arch/x86/cpu/apollolake/Kconfig:6)
warning: the choice symbol SPL_RISCV_MMODE (defined at arch/riscv/Kconfig:184) is implied by the following symbols, but select/imply has no effect on choice symbols
- BOARD_SPECIFIC_OPTIONS (defined at board/bsh/imx8mn_smm_s2/Kconfig:21, board/bsh/imx8mn_smm_s2/Kconfig:41, board/engicam/px30_core/Kconfig:12, board/theobroma-systems/ringneck_px30/Kconfig:12, board/radxa/rockpi4-rk3399/Kconfig:12, board/theobroma-systems/puma_rk3399/Kconfig:12, board/theobroma-systems/jaguar_rk3588/Kconfig:12, board/edgeble/neural-compute-module-2/Kconfig:12, board/itead/sonoff-ihost/Kconfig:12, board/emulation/qemu-arm/Kconfig:6, board/emulation/qemu-arm/Kconfig:22, board/freescale/ls1012aqds/Kconfig:27, board/freescale/ls1012ardb/Kconfig:27, board/freescale/ls1012ardb/Kconfig:76, board/freescale/ls1012afrdm/Kconfig:27, board/advantech/som-db5800-som-6867/Kconfig:18, board/congatec/conga-qeval20-qa3-e3845/Kconfig:17, board/coreboot/coreboot/Kconfig:15, board/dfi/dfi-bt700/Kconfig:17, board/efi/efi-x86_app/Kconfig:12, board/efi/efi-x86_payload/Kconfig:15, board/emulation/qemu-x86/Kconfig:16, board/google/chromebook_coral/Kconfig:18, board/google/chromebook_link/Kconfig:19, board/google/chromebox_panther/Kconfig:19, board/google/chromebook_samus/Kconfig:19, board/intel/bayleybay/Kconfig:15, board/intel/cherryhill/Kconfig:15, board/intel/cougarcanyon2/Kconfig:15, board/intel/crownbay/Kconfig:15, board/intel/edison/Kconfig:24, board/intel/galileo/Kconfig:15, board/intel/minnowmax/Kconfig:15, board/intel/slimbootloader/Kconfig:19, board/AndesTech/ae350/Kconfig:34, board/emulation/qemu-riscv/Kconfig:32, board/microchip/mpfs_icicle/Kconfig:19, board/openpiton/riscv64/Kconfig:26, board/sifive/unleashed/Kconfig:26, board/sifive/unmatched/Kconfig:26, board/sipeed/maix/Kconfig:30, board/sophgo/milkv_duo/Kconfig:24, board/starfive/visionfive2/Kconfig:26, board/thead/th1520_lpi4a/Kconfig:30, board/xilinx/mbv/Kconfig:22, board/keymile/km83xx/Kconfig:34, board/keymile/km83xx/Kconfig:54, board/keymile/km83xx/Kconfig:74, board/keymile/km83xx/Kconfig:93, board/keymile/km83xx/Kconfig:112, board/keymile/km83xx/Kconfig:131, board/keymile/km83xx/Kconfig:150, board/keymile/kmcent2/Kconfig:12, board/keymile/pg-wcom-ls102xa/Kconfig:15, board/keymile/pg-wcom-ls102xa/Kconfig:35)
warning: the choice symbol SYS_BIG_ENDIAN (defined at arch/Kconfig:528) is selected by the following symbols, but select/imply has no effect on choice symbols
- ARC (defined at arch/Kconfig:53)
warning: the choice symbol SYS_LITTLE_ENDIAN (defined at arch/Kconfig:532) is selected by the following symbols, but select/imply has no effect on choice symbols
- ARC (defined at arch/Kconfig:53)
warning: the choice symbol OF_SEPARATE (defined at dts/Kconfig:108) is selected by the following symbols, but select/imply has no effect on choice symbols
- ARCH_MVEBU (defined at arch/arm/Kconfig:620)
- ARCH_SNAPDRAGON (defined at arch/arm/Kconfig:1074)
- ARCH_SUNXI (defined at arch/arm/Kconfig:1143)
- ARCH_S5P4418 (defined at arch/arm/mach-nexell/Kconfig:3)
warning: the choice symbol MULTI_DTB_FIT_USER_DEFINED_AREA (defined at dts/Kconfig:242) is implied by the following symbols, but select/imply has no effect on choice symbols
- RZG2L (defined at arch/arm/mach-renesas/Kconfig:70)
- TARGET_BEACON_RZG2M (defined at arch/arm/mach-renesas/Kconfig.rcar3:82)
- TARGET_HIHOPE_RZG2 (defined at arch/arm/mach-renesas/Kconfig.rcar3:130)
- TARGET_SALVATOR_X (defined at arch/arm/mach-renesas/Kconfig.rcar3:149)
- TARGET_ULCB (defined at arch/arm/mach-renesas/Kconfig.rcar3:160)
warning: the choice symbol SYS_NAND_SOFT_ECC (defined at drivers/mtd/nand/raw/Kconfig:184) is selected by the following symbols, but select/imply has no effect on choice symbols
- NAND_SANDBOX (defined at drivers/mtd/nand/raw/Kconfig:450)
warning: the choice symbol USB_ULPI_VIEWPORT (defined at drivers/usb/ulpi/Kconfig:11) is selected by the following symbols, but select/imply has no effect on choice symbols
- USB_EHCI_MSM (defined at drivers/usb/host/Kconfig:263)
warning: the choice symbol LIB_RAND (defined at lib/Kconfig:275) is selected by the following symbols, but select/imply has no effect on choice symbols
- CMD_LINK_LOCAL (defined at cmd/Kconfig:1994)
warning: the choice symbol EFI_APP (defined at lib/efi/Kconfig:15) is selected by the following symbols, but select/imply has no effect on choice symbols
- TARGET_EFI_APP32 (defined at board/efi/Kconfig:7)
- TARGET_EFI_APP64 (defined at board/efi/Kconfig:16)

Michal Simek (4):
Kconfig: Remove trailing whitespace in its prompt
Kconfig: Add missing quotes around source file
Kconfig: Add missing quotes around default string value
Kconfig: Make all Kconfig encoding ascii

 arch/arm/mach-rockchip/px30/Kconfig   |  4 ++--
 arch/arm/mach-rockchip/rk3588/Kconfig | 24 ++++++++++++------------
 arch/arm/mach-rockchip/rv1108/Kconfig |  4 ++--
 arch/arm/mach-rockchip/rv1126/Kconfig |  8 ++++----
 cmd/Kconfig                           |  2 +-
 drivers/clk/Kconfig                   | 10 +++++-----
 drivers/crypto/Kconfig                |  8 ++++----
 drivers/ddr/imx/imx8ulp/Kconfig       |  2 +-
 drivers/mtd/spi/Kconfig               |  2 +-
 lib/Kconfig                           | 18 +++++++++---------
 lib/efi_loader/Kconfig                |  2 +-
 11 files changed, 42 insertions(+), 42 deletions(-)
Signature · 1 line
2.44.0
#1 lore raw

PATCH 1/4 Kconfig: Remove trailing whitespace in its prompt

All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this:
warning: SPL_CLK_CCF (defined at drivers/clk/Kconfig:59) has leading or trailing whitespace in its prompt

---

 drivers/clk/Kconfig             | 10 +++++-----
 drivers/ddr/imx/imx8ulp/Kconfig |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/clk/Kconfig +5 -5
index 017dd260a544..bda6873be331 100644
@@ -57,27 +57,27 @@ config CLK_BOSTON
 	  Enable this to support the clocks
 
 config SPL_CLK_CCF
-	bool "SPL Common Clock Framework [CCF] support "
+	bool "SPL Common Clock Framework [CCF] support"
 	depends on SPL
 	help
 	  Enable this option if you want to (re-)use the Linux kernel's Common
 	  Clock Framework [CCF] code in U-Boot's SPL.
 
 config SPL_CLK_COMPOSITE_CCF
-	bool "SPL Common Clock Framework [CCF] composite clk support "
+	bool "SPL Common Clock Framework [CCF] composite clk support"
 	depends on SPL_CLK_CCF
 	help
 	  Enable this option if you want to (re-)use the Linux kernel's Common
 	  Clock Framework [CCF] composite code in U-Boot's SPL.
 
 config CLK_CCF
-	bool "Common Clock Framework [CCF] support "
+	bool "Common Clock Framework [CCF] support"
 	help
 	  Enable this option if you want to (re-)use the Linux kernel's Common
 	  Clock Framework [CCF] code in U-Boot's clock driver.
 
 config CLK_COMPOSITE_CCF
-	bool "Common Clock Framework [CCF] composite clk support "
+	bool "Common Clock Framework [CCF] composite clk support"
 	depends on CLK_CCF
 	help
 	  Enable this option if you want to (re-)use the Linux kernel's Common
@@ -164,7 +164,7 @@ config CLK_OCTEON
 	  Enable this to support the clocks on Octeon MIPS platforms.
 
 config SANDBOX_CLK_CCF
-	bool "Sandbox Common Clock Framework [CCF] support "
+	bool "Sandbox Common Clock Framework [CCF] support"
 	depends on SANDBOX
 	select CLK_CCF
 	help
drivers/ddr/imx/imx8ulp/Kconfig +1 -1
index 5448c33838ce..005f581f4baa 100644
@@ -5,7 +5,7 @@ config IMX8ULP_DRAM
 	bool "imx8m dram"
 
 config IMX8ULP_DRAM_PHY_PLL_BYPASS
-	bool "Enable the DDR PHY PLL bypass mode, so PHY clock is from DDR_CLK "
+	bool "Enable the DDR PHY PLL bypass mode, so PHY clock is from DDR_CLK"
 	depends on IMX8ULP_DRAM
 
 config SAVED_DRAM_TIMING_BASE
Signature · 1 line
2.44.0
#2 lore raw

PATCH 2/4 Kconfig: Add missing quotes around source file

In reply to Michal Simek

All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this:
drivers/crypto/Kconfig:9: warning: style: quotes recommended around 'drivers/crypto/nuvoton/Kconfig' in 'source drivers/crypto/nuvoton/Kconfig'

---

 arch/arm/mach-rockchip/rk3588/Kconfig | 18 +++++++++---------
 arch/arm/mach-rockchip/rv1108/Kconfig |  4 ++--
 arch/arm/mach-rockchip/rv1126/Kconfig |  4 ++--
 cmd/Kconfig                           |  2 +-
 drivers/crypto/Kconfig                |  8 ++++----
 lib/Kconfig                           | 18 +++++++++---------
 6 files changed, 27 insertions(+), 27 deletions(-)
arch/arm/mach-rockchip/rk3588/Kconfig +9 -9
index d7e4af31f24c..eb956b097c74 100644
@@ -221,14 +221,14 @@ config ROCKCHIP_COMMON_STACK_ADDR
 config TEXT_BASE
 	default 0x00a00000
 
-source board/edgeble/neural-compute-module-6/Kconfig
-source board/friendlyelec/nanopc-t6-rk3588/Kconfig
-source board/pine64/quartzpro64-rk3588/Kconfig
-source board/turing/turing-rk1-rk3588/Kconfig
-source board/radxa/rock5a-rk3588s/Kconfig
-source board/radxa/rock5b-rk3588/Kconfig
-source board/rockchip/evb_rk3588/Kconfig
-source board/rockchip/toybrick_rk3588/Kconfig
-source board/theobroma-systems/jaguar_rk3588/Kconfig
+source "board/edgeble/neural-compute-module-6/Kconfig"
+source "board/friendlyelec/nanopc-t6-rk3588/Kconfig"
+source "board/pine64/quartzpro64-rk3588/Kconfig"
+source "board/turing/turing-rk1-rk3588/Kconfig"
+source "board/radxa/rock5a-rk3588s/Kconfig"
+source "board/radxa/rock5b-rk3588/Kconfig"
+source "board/rockchip/evb_rk3588/Kconfig"
+source "board/rockchip/toybrick_rk3588/Kconfig"
+source "board/theobroma-systems/jaguar_rk3588/Kconfig"
 
 endif
arch/arm/mach-rockchip/rv1108/Kconfig +2 -2
index a12216dccf66..28ed0b245812 100644
@@ -36,7 +36,7 @@ config SYS_SOC
 config SYS_MALLOC_F_LEN
 	default 0x400
 
-source board/rockchip/evb_rv1108/Kconfig
-source board/elgin/elgin_rv1108/Kconfig
+source "board/rockchip/evb_rv1108/Kconfig"
+source "board/elgin/elgin_rv1108/Kconfig"
 
 endif
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
index 55b11121203b..ae323ee91235 100644
@@ -64,7 +64,7 @@ config SYS_MALLOC_F_LEN
 config TEXT_BASE
 	default 0x600000
 
-source board/edgeble/neural-compute-module-2/Kconfig
-source board/itead/sonoff-ihost/Kconfig
+source "board/edgeble/neural-compute-module-2/Kconfig"
+source "board/itead/sonoff-ihost/Kconfig"
 
 endif
cmd/Kconfig +1 -1
index 8eeb99eea5ed..45c206369518 100644
@@ -398,7 +398,7 @@ config CMD_BOOTEFI_HELLO
 	  for testing that EFI is working at a basic level, and for bringing
 	  up EFI support on a new architecture.
 
-source lib/efi_selftest/Kconfig
+source "lib/efi_selftest/Kconfig"
 endif
 
 config CMD_BOOTMENU
drivers/crypto/Kconfig +4 -4
index 12ef84ca05ca..8b49997030b4 100644
@@ -1,11 +1,11 @@
 menu "Hardware crypto devices"
 
-source drivers/crypto/hash/Kconfig
+source "drivers/crypto/hash/Kconfig"
 
-source drivers/crypto/fsl/Kconfig
+source "drivers/crypto/fsl/Kconfig"
 
-source drivers/crypto/aspeed/Kconfig
+source "drivers/crypto/aspeed/Kconfig"
 
-source drivers/crypto/nuvoton/Kconfig
+source "drivers/crypto/nuvoton/Kconfig"
 
 endmenu
lib/Kconfig +9 -9
index efb77978a652..189e6eb31aa1 100644
@@ -416,7 +416,7 @@ config TRACE_EARLY_ADDR
 config CIRCBUF
 	bool "Enable circular buffer support"
 
-source lib/dhry/Kconfig
+source "lib/dhry/Kconfig"
 
 menu "Security support"
 
@@ -429,10 +429,10 @@ config AES
 	  supported by the algorithm but only a 128-bit key is supported at
 	  present.
 
-source lib/ecdsa/Kconfig
-source lib/rsa/Kconfig
-source lib/crypto/Kconfig
-source lib/crypt/Kconfig
+source "lib/ecdsa/Kconfig"
+source "lib/rsa/Kconfig"
+source "lib/crypto/Kconfig"
+source "lib/crypt/Kconfig"
 
 config TPM
 	bool "Trusted Platform Module (TPM) Support"
@@ -1081,9 +1081,9 @@ config SMBIOS_PARSER
 	help
 	  A simple parser for SMBIOS data.
 
-source lib/efi/Kconfig
-source lib/efi_loader/Kconfig
-source lib/optee/Kconfig
+source "lib/efi/Kconfig"
+source "lib/efi_loader/Kconfig"
+source "lib/optee/Kconfig"
 
 config TEST_FDTDEC
 	bool "enable fdtdec test"
@@ -1148,4 +1148,4 @@ config PHANDLE_CHECK_SEQ
 
 endmenu
 
-source lib/fwu_updates/Kconfig
+source "lib/fwu_updates/Kconfig"
Signature · 1 line
2.44.0
#3 lore raw

Re: [PATCH 2/4] Kconfig: Add missing quotes around source file

Quoted 4 lines · Michal Simek

All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this:
drivers/crypto/Kconfig:9: warning: style: quotes recommended around 'drivers/crypto/nuvoton/Kconfig' in 'source drivers/crypto/nuvoton/Kconfig'

Should we add a qconfig.py test to our CI?

Best regards

Heinrich

Quoted 148 lines

---

  arch/arm/mach-rockchip/rk3588/Kconfig | 18 +++++++++---------
  arch/arm/mach-rockchip/rv1108/Kconfig |  4 ++--
  arch/arm/mach-rockchip/rv1126/Kconfig |  4 ++--
  cmd/Kconfig                           |  2 +-
  drivers/crypto/Kconfig                |  8 ++++----
  lib/Kconfig                           | 18 +++++++++---------
  6 files changed, 27 insertions(+), 27 deletions(-)
arch/arm/mach-rockchip/rk3588/Kconfig +9 -9
index d7e4af31f24c..eb956b097c74 100644
@@ -221,14 +221,14 @@ config ROCKCHIP_COMMON_STACK_ADDR
  config TEXT_BASE
  	default 0x00a00000
 
-source board/edgeble/neural-compute-module-6/Kconfig
-source board/friendlyelec/nanopc-t6-rk3588/Kconfig
-source board/pine64/quartzpro64-rk3588/Kconfig
-source board/turing/turing-rk1-rk3588/Kconfig
-source board/radxa/rock5a-rk3588s/Kconfig
-source board/radxa/rock5b-rk3588/Kconfig
-source board/rockchip/evb_rk3588/Kconfig
-source board/rockchip/toybrick_rk3588/Kconfig
-source board/theobroma-systems/jaguar_rk3588/Kconfig
+source "board/edgeble/neural-compute-module-6/Kconfig"
+source "board/friendlyelec/nanopc-t6-rk3588/Kconfig"
+source "board/pine64/quartzpro64-rk3588/Kconfig"
+source "board/turing/turing-rk1-rk3588/Kconfig"
+source "board/radxa/rock5a-rk3588s/Kconfig"
+source "board/radxa/rock5b-rk3588/Kconfig"
+source "board/rockchip/evb_rk3588/Kconfig"
+source "board/rockchip/toybrick_rk3588/Kconfig"
+source "board/theobroma-systems/jaguar_rk3588/Kconfig"
 
  endif
arch/arm/mach-rockchip/rv1108/Kconfig +2 -2
index a12216dccf66..28ed0b245812 100644
@@ -36,7 +36,7 @@ config SYS_SOC
  config SYS_MALLOC_F_LEN
  	default 0x400
 
-source board/rockchip/evb_rv1108/Kconfig
-source board/elgin/elgin_rv1108/Kconfig
+source "board/rockchip/evb_rv1108/Kconfig"
+source "board/elgin/elgin_rv1108/Kconfig"
 
  endif
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
index 55b11121203b..ae323ee91235 100644
@@ -64,7 +64,7 @@ config SYS_MALLOC_F_LEN
  config TEXT_BASE
  	default 0x600000
 
-source board/edgeble/neural-compute-module-2/Kconfig
-source board/itead/sonoff-ihost/Kconfig
+source "board/edgeble/neural-compute-module-2/Kconfig"
+source "board/itead/sonoff-ihost/Kconfig"
 
  endif
cmd/Kconfig +1 -1
index 8eeb99eea5ed..45c206369518 100644
@@ -398,7 +398,7 @@ config CMD_BOOTEFI_HELLO
  	  for testing that EFI is working at a basic level, and for bringing
  	  up EFI support on a new architecture.
 
-source lib/efi_selftest/Kconfig
+source "lib/efi_selftest/Kconfig"
  endif
 
  config CMD_BOOTMENU
drivers/crypto/Kconfig +4 -4
index 12ef84ca05ca..8b49997030b4 100644
@@ -1,11 +1,11 @@
  menu "Hardware crypto devices"
 
-source drivers/crypto/hash/Kconfig
+source "drivers/crypto/hash/Kconfig"
 
-source drivers/crypto/fsl/Kconfig
+source "drivers/crypto/fsl/Kconfig"
 
-source drivers/crypto/aspeed/Kconfig
+source "drivers/crypto/aspeed/Kconfig"
 
-source drivers/crypto/nuvoton/Kconfig
+source "drivers/crypto/nuvoton/Kconfig"
 
  endmenu
lib/Kconfig +9 -9
index efb77978a652..189e6eb31aa1 100644
@@ -416,7 +416,7 @@ config TRACE_EARLY_ADDR
  config CIRCBUF
  	bool "Enable circular buffer support"
 
-source lib/dhry/Kconfig
+source "lib/dhry/Kconfig"
 
  menu "Security support"
 
@@ -429,10 +429,10 @@ config AES
  	  supported by the algorithm but only a 128-bit key is supported at
  	  present.
 
-source lib/ecdsa/Kconfig
-source lib/rsa/Kconfig
-source lib/crypto/Kconfig
-source lib/crypt/Kconfig
+source "lib/ecdsa/Kconfig"
+source "lib/rsa/Kconfig"
+source "lib/crypto/Kconfig"
+source "lib/crypt/Kconfig"
 
  config TPM
  	bool "Trusted Platform Module (TPM) Support"
@@ -1081,9 +1081,9 @@ config SMBIOS_PARSER
  	help
  	  A simple parser for SMBIOS data.
 
-source lib/efi/Kconfig
-source lib/efi_loader/Kconfig
-source lib/optee/Kconfig
+source "lib/efi/Kconfig"
+source "lib/efi_loader/Kconfig"
+source "lib/optee/Kconfig"
 
  config TEST_FDTDEC
  	bool "enable fdtdec test"
@@ -1148,4 +1148,4 @@ config PHANDLE_CHECK_SEQ
 
  endmenu
 
-source lib/fwu_updates/Kconfig
+source "lib/fwu_updates/Kconfig"
#4 lore raw

Re: [PATCH 2/4] Kconfig: Add missing quotes around source file

Quoted 7 lines · Heinrich Schuchardt
Quoted 4 lines · Michal Simek

All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this:
drivers/crypto/Kconfig:9: warning: style: quotes recommended around 'drivers/crypto/nuvoton/Kconfig' in 'source drivers/crypto/nuvoton/Kconfig'

Should we add a qconfig.py test to our CI?

When things are without warnings that would be the best.

M

#5 lore raw

PATCH 3/4 Kconfig: Add missing quotes around default string value

In reply to Michal Simek

All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this:
warning: style: quotes recommended around default value for string symbol EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130)

---

 lib/efi_loader/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/efi_loader/Kconfig +1 -1
index e13a6f9f4c3a..a5ab7d1b262f 100644
@@ -129,7 +129,7 @@ if EFI_VARIABLES_PRESEED
 
 config EFI_VAR_SEED_FILE
 	string "File with initial values of non-volatile UEFI variables"
-	default ubootefi.var
+	default "ubootefi.var"
 	help
 	  File with initial values of non-volatile UEFI variables. The file must
 	  be in the same format as the storage in the EFI system partition. The
Signature · 1 line
2.44.0
Reviewed-by on v1 3/4
#6 lore raw

Re: [PATCH 3/4] Kconfig: Add missing quotes around default string value

Quoted 16 lines · Michal Simek

All errors are generated by ./tools/qconfig.py -b -j8 -i whatever. Error look like this:
warning: style: quotes recommended around default value for string symbol EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130)

---

  lib/efi_loader/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
lib/efi_loader/Kconfig +0 -0
index e13a6f9f4c3a..a5ab7d1b262f 100644

lib/efi_loader/Kconfig if EFI_VARIABLES_PRESEED · line 135

Quoted 8 lines
lib/efi_loader/Kconfig +1 -1
@@ -129,7 +129,7 @@ if EFI_VARIABLES_PRESEED
 
  config EFI_VAR_SEED_FILE
  	string "File with initial values of non-volatile UEFI variables"
-	default ubootefi.var
+	default "ubootefi.var"
  	help
  	  File with initial values of non-volatile UEFI variables. The file must
  	  be in the same format as the storage in the EFI system partition. The
#7 lore raw

PATCH 4/4 Kconfig: Make all Kconfig encoding ascii

In reply to Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

---

There are other files which are using utf-8 enconding and pretty much I think we should convert all of them because there is no reason to use utf-8 encoding.

---
 arch/arm/mach-rockchip/px30/Kconfig   | 4 ++--
 arch/arm/mach-rockchip/rk3588/Kconfig | 6 +++---
 arch/arm/mach-rockchip/rv1126/Kconfig | 4 ++--
 drivers/mtd/spi/Kconfig               | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/mach-rockchip/px30/Kconfig +2 -2
index 41893920cb4d..23f8f430c4ae 100644
@@ -36,9 +36,9 @@ config TARGET_PX30_CORE
             10.1" OF for creating complete PX30.Core C.TOUCH 2.0 10.1" Open Frame.
 
 config TARGET_RINGNECK_PX30
-	bool "Theobroma Systems PX30-µQ7 (Ringneck)"
+	bool "Theobroma Systems PX30-uQ7 (Ringneck)"
 	help
-	  The PX30-uQ7 (Ringneck) SoM is a µQseven-compatible (40mmx70mm,
+	  The PX30-uQ7 (Ringneck) SoM is a uQseven-compatible (40mmx70mm,
           MXM-230 connector) system-on-module from Theobroma Systems[1],
 	  featuring the Rockchip PX30.
 
arch/arm/mach-rockchip/rk3588/Kconfig +3 -3
index eb956b097c74..39049ab35a9c 100644
@@ -66,7 +66,7 @@ config TARGET_NANOPCT6_RK3588
 	                HDMI2.0, and HDMI1.4
 	  2x 4-lane MIPI-DSI, compatible with MIPI DPHY 2.0 or CPHY 1.1
 	  USB-A: USB 3.0, Type A
-	  USB-C: Full function USB Type‑C port, DP display up to 4Kp60, USB 3.0
+	  USB-C: Full function USB Type-C port, DP display up to 4Kp60, USB 3.0
 	  40-pin 2.54mm header connector: up to 2x SPIs, 6x UARTs, 1x I2Cs,
 	                                  8x PWMs, 2x I2Ss, 28x GPIOs
 	  Debug UART: 3 Pin 2.54mm header, 3V level, 1500000bps
@@ -117,7 +117,7 @@ config TARGET_ROCK5A_RK3588
 	  Mali G610MC4 GPU
 	  MIPI CSI 2 multiple lanes connector
 	  4-lane MIPI DSI connector
-	  Audio – 3.5mm earphone jack
+	  Audio - 3.5mm earphone jack
 	  eMMC module connector
 	  uSD slot (up to 128GB)
 	  2x USB 2.0, 2x USB 3.0
@@ -197,7 +197,7 @@ config TARGET_TOYBRICK_RK3588
 	  4x ARM Cortex-A76, 4x ARM Cortex-A55
 	  8/16GB Memory LPDDR4x
 	  Mali G610MC4 GPU
-	  2× MIPI-CSI0 Connector
+	  2x MIPI-CSI0 Connector
 	  1x 2Lanes PCIe3.0 Connector
 	  1x SATA3.0 Connector
 	  32GB eMMC Module
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
index ae323ee91235..64a70f61f894 100644
@@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
 	  Neu2:
 	  Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
 	  based on Rockchip RV1126 from Edgeble AI.
-	  Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
-	  Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
+	  Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
+	  Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.
 
 	  Neu2-IO:
 	  Neural Compute Module 2(Neu2) IO board is an industrial form factor
drivers/mtd/spi/Kconfig +1 -1
index d068b7860e1c..bedc4e970e43 100644
@@ -246,7 +246,7 @@ config SPI_FLASH_USE_4K_SECTORS
 	  to erasing whole blocks (32/64 KiB).
 	  Changing a small part of the flash's contents is usually faster with
 	  small sectors. On the other hand erasing should be faster when using
-	  64 KiB block instead of 16 × 4 KiB sectors.
+	  64 KiB block instead of 16 x 4 KiB sectors.
 
 	  Please note that some tools/drivers/filesystems may not work with
 	  4096 B erase size (e.g. UBIFS requires 15 KiB as a minimum).
Signature · 1 line
2.44.0
#8 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 9 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

---

There are other files which are using utf-8 enconding and pretty much I think we should convert all of them because there is no reason to use utf-8 encoding.

Hello Michal,

The commit message does not explain why we should refrain from using UTF-8.

Quoted 60 lines
---
  arch/arm/mach-rockchip/px30/Kconfig   | 4 ++--
  arch/arm/mach-rockchip/rk3588/Kconfig | 6 +++---
  arch/arm/mach-rockchip/rv1126/Kconfig | 4 ++--
  drivers/mtd/spi/Kconfig               | 2 +-
  4 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/mach-rockchip/px30/Kconfig +2 -2
index 41893920cb4d..23f8f430c4ae 100644
@@ -36,9 +36,9 @@ config TARGET_PX30_CORE
              10.1" OF for creating complete PX30.Core C.TOUCH 2.0 10.1" Open Frame.
 
  config TARGET_RINGNECK_PX30
-	bool "Theobroma Systems PX30-µQ7 (Ringneck)"
+	bool "Theobroma Systems PX30-uQ7 (Ringneck)"
  	help
-	  The PX30-uQ7 (Ringneck) SoM is a µQseven-compatible (40mmx70mm,
+	  The PX30-uQ7 (Ringneck) SoM is a uQseven-compatible (40mmx70mm,
            MXM-230 connector) system-on-module from Theobroma Systems[1],
  	  featuring the Rockchip PX30.
 
arch/arm/mach-rockchip/rk3588/Kconfig +3 -3
index eb956b097c74..39049ab35a9c 100644
@@ -66,7 +66,7 @@ config TARGET_NANOPCT6_RK3588
  	                HDMI2.0, and HDMI1.4
  	  2x 4-lane MIPI-DSI, compatible with MIPI DPHY 2.0 or CPHY 1.1
  	  USB-A: USB 3.0, Type A
-	  USB-C: Full function USB Type‑C port, DP display up to 4Kp60, USB 3.0
+	  USB-C: Full function USB Type-C port, DP display up to 4Kp60, USB 3.0
  	  40-pin 2.54mm header connector: up to 2x SPIs, 6x UARTs, 1x I2Cs,
  	                                  8x PWMs, 2x I2Ss, 28x GPIOs
  	  Debug UART: 3 Pin 2.54mm header, 3V level, 1500000bps
@@ -117,7 +117,7 @@ config TARGET_ROCK5A_RK3588
  	  Mali G610MC4 GPU
  	  MIPI CSI 2 multiple lanes connector
  	  4-lane MIPI DSI connector
-	  Audio – 3.5mm earphone jack
+	  Audio - 3.5mm earphone jack
  	  eMMC module connector
  	  uSD slot (up to 128GB)
  	  2x USB 2.0, 2x USB 3.0
@@ -197,7 +197,7 @@ config TARGET_TOYBRICK_RK3588
  	  4x ARM Cortex-A76, 4x ARM Cortex-A55
  	  8/16GB Memory LPDDR4x
  	  Mali G610MC4 GPU
-	  2× MIPI-CSI0 Connector
+	  2x MIPI-CSI0 Connector
  	  1x 2Lanes PCIe3.0 Connector
  	  1x SATA3.0 Connector
  	  32GB eMMC Module
arch/arm/mach-rockchip/rv1126/Kconfig +0 -0
index ae323ee91235..64a70f61f894 100644

arch/arm/mach-rockchip/rv1126/Kconfig config TARGET_RV1126_NEU2 · line 10

Quoted 7 lines
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
@@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
  	  Neu2:
  	  Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
  	  based on Rockchip RV1126 from Edgeble AI.
-	  Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
-	  Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
+	  Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
+	  Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.

C is the sign for coulomb which is the unit of electric charge. How about 'deg C'?

Best regards

Heinrich

Quoted 16 lines
arch/arm/mach-rockchip/rv1126/Kconfig +0 -0
  	  Neu2-IO:
  	  Neural Compute Module 2(Neu2) IO board is an industrial form factor
drivers/mtd/spi/Kconfig +1 -1
index d068b7860e1c..bedc4e970e43 100644
@@ -246,7 +246,7 @@ config SPI_FLASH_USE_4K_SECTORS
  	  to erasing whole blocks (32/64 KiB).
  	  Changing a small part of the flash's contents is usually faster with
  	  small sectors. On the other hand erasing should be faster when using
-	  64 KiB block instead of 16 × 4 KiB sectors.
+	  64 KiB block instead of 16 x 4 KiB sectors.
 
  	  Please note that some tools/drivers/filesystems may not work with
  	  4096 B erase size (e.g. UBIFS requires 15 KiB as a minimum).
#9 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 7 lines · Heinrich Schuchardt
Quoted 6 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

---

Quoted 7 lines
Quoted 3 lines

There are other files which are using utf-8 enconding and pretty much I think we should convert all of them because there is no reason to use utf-8 encoding.

Hello Michal,

The commit message does not explain why we should refrain from using UTF-8.

that's a good point. I was thinking about the reason for it and pretty much wanted to get feedback from Tom about it.

In doc/develop/sending_patches.rst is said that patches should be sent as plain text but encoding is not specified. Traditionally this was ASCII and I pretty much don't see the reason to use UTF encoding (even my name has special czech char which I am not using, the same is for Marek Vasut).

Thanks,
Michal

#10 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 18 lines · Michal Simek
Quoted 7 lines · Heinrich Schuchardt
Quoted 6 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

---

Quoted 7 lines
Quoted 3 lines

There are other files which are using utf-8 enconding and pretty much I think we should convert all of them because there is no reason to use utf-8 encoding.

Hello Michal,

The commit message does not explain why we should refrain from using UTF-8.

Quoted 7 lines

that's a good point. I was thinking about the reason for it and pretty much wanted to get feedback from Tom about it.

In doc/develop/sending_patches.rst is said that patches should be sent as plain text but encoding is not specified. Traditionally this was ASCII and I pretty much don't see the reason to use UTF encoding (even my name has special czech char which I am not using, the same is for Marek Vasut).

My point of view is that I think ASCII should be used in general, with the exception being names (I won't force people to ASCII-ize their names, modern systems handle UTF-8 just fine). I actually don't know if we should also exclude rST doc files from this rule as well as UTF-8 should render fine and for example "°C" reads nicely in web/PDF/etc.

Signature · 1 line
Tom
#11 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 27 lines · Tom Rini
Quoted 18 lines · Michal Simek
Quoted 7 lines · Heinrich Schuchardt
Quoted 6 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

---

Quoted 7 lines
Quoted 3 lines

There are other files which are using utf-8 enconding and pretty much I think we should convert all of them because there is no reason to use utf-8 encoding.

Hello Michal,

The commit message does not explain why we should refrain from using UTF-8.

Quoted 7 lines

that's a good point. I was thinking about the reason for it and pretty much wanted to get feedback from Tom about it.

In doc/develop/sending_patches.rst is said that patches should be sent as plain text but encoding is not specified. Traditionally this was ASCII and I pretty much don't see the reason to use UTF encoding (even my name has special czech char which I am not using, the same is for Marek Vasut).

Quoted 6 lines

My point of view is that I think ASCII should be used in general, with the exception being names (I won't force people to ASCII-ize their names, modern systems handle UTF-8 just fine). I actually don't know if we should also exclude rST doc files from this rule as well as UTF-8 should render fine and for example "°C" reads nicely in web/PDF/etc.

I think that people the most of time just simply don't know that they are using non ASCII chars. Anyway let me send v2 with also patch for .c and .h when appropriate.

Thanks,
Michal

#12 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

In reply to Heinrich Schuchardt
Quoted 5 lines · Heinrich Schuchardt
Quoted 4 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

[snip]

Quoted 7 lines
Quoted 7 lines
arch/arm/mach-rockchip/rv1126/Kconfig +0 -0
index ae323ee91235..64a70f61f894 100644
@@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
  	  Neu2:
  	  Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
Quoted 8 lines

arch/arm/mach-rockchip/rv1126/Kconfig config TARGET_RV1126_NEU2 · line 10

Quoted 5 lines
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
  	  based on Rockchip RV1126 from Edgeble AI.
-	  Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
-	  Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
+	  Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
+	  Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.

C is the sign for coulomb which is the unit of electric charge. How about 'deg C'?

I'll note that in Linux there's seemingly nothing consistent, and I'm fine with any of "deg C" or "degrees C" or "temperature range (-40 C to +85 C)" as all of those should be clear in context.

Signature · 1 line
Tom
#13 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 23 lines · Tom Rini
Quoted 5 lines · Heinrich Schuchardt
Quoted 4 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

[snip]

Quoted 7 lines
Quoted 7 lines
arch/arm/mach-rockchip/rv1126/Kconfig +0 -0
index ae323ee91235..64a70f61f894 100644
@@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
  	  Neu2:
  	  Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
Quoted 8 lines

arch/arm/mach-rockchip/rv1126/Kconfig config TARGET_RV1126_NEU2 · line 10

Quoted 5 lines
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
  	  based on Rockchip RV1126 from Edgeble AI.
-	  Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
-	  Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
+	  Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
+	  Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.

C is the sign for coulomb which is the unit of electric charge. How about 'deg C'?

Quoted 3 lines

I'll note that in Linux there's seemingly nothing consistent, and I'm fine with any of "deg C" or "degrees C" or "temperature range (-40 C to +85 C)" as all of those should be clear in context.

My 2 cents ... while I agree with Tom that the context will make it clear, it is not making it correct nor nice. Using just "C" for Celsius degrees is horrible ...

Francesco

#14 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 24 lines · Francesco Dolcini
Quoted 23 lines · Tom Rini
Quoted 5 lines · Heinrich Schuchardt
Quoted 4 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

[snip]

Quoted 15 lines

arch/arm/mach-rockchip/rv1126/Kconfig config TARGET_RV1126_NEU2 · line 10

Quoted 12 lines
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
index ae323ee91235..64a70f61f894 100644
@@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
   	  Neu2:
   	  Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
   	  based on Rockchip RV1126 from Edgeble AI.
-	  Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
-	  Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
+	  Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
+	  Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.

C is the sign for coulomb which is the unit of electric charge. How about 'deg C'?

Quoted 7 lines
Quoted 3 lines

I'll note that in Linux there's seemingly nothing consistent, and I'm fine with any of "deg C" or "degrees C" or "temperature range (-40 C to +85 C)" as all of those should be clear in context.

My 2 cents ... while I agree with Tom that the context will make it clear, it is not making it correct nor nice. Using just "C" for Celsius degrees is horrible ...

I used deg C in v2 version.

Thanks,
Michal

#15 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

In reply to Francesco Dolcini
Quoted 24 lines · Francesco Dolcini
Quoted 23 lines · Tom Rini
Quoted 5 lines · Heinrich Schuchardt
Quoted 4 lines · Michal Simek

Some of Kconfigs are using utf-8 encoding because of used chars. Convert all of them to ascii enconging.

[snip]

Quoted 15 lines

arch/arm/mach-rockchip/rv1126/Kconfig config TARGET_RV1126_NEU2 · line 10

Quoted 12 lines
arch/arm/mach-rockchip/rv1126/Kconfig +2 -2
index ae323ee91235..64a70f61f894 100644
@@ -6,8 +6,8 @@ config TARGET_RV1126_NEU2
  	  Neu2:
  	  Neural Compute Module 2(Neu2) is a 96boards SoM-CB compute module
  	  based on Rockchip RV1126 from Edgeble AI.
-	  Neu2 powered with Consumer grade (0 to +80 °C) RV1126 SoC.
-	  Neu2k powered with Industrial grade (-40 °C to +85 °C) RV1126K SoC.
+	  Neu2 powered with Consumer grade (0 to +80 C) RV1126 SoC.
+	  Neu2k powered with Industrial grade (-40 C to +85 C) RV1126K SoC.

C is the sign for coulomb which is the unit of electric charge. How about 'deg C'?

Quoted 7 lines
Quoted 3 lines

I'll note that in Linux there's seemingly nothing consistent, and I'm fine with any of "deg C" or "degrees C" or "temperature range (-40 C to +85 C)" as all of those should be clear in context.

My 2 cents ... while I agree with Tom that the context will make it clear, it is not making it correct nor nice. Using just "C" for Celsius degrees is horrible ...

FWIW, I usually use "oC", which is far from perfect, but IMHO also far from horrible. :)

#16 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 10 lines · Dragan Simic
Quoted 9 lines · Francesco Dolcini
Quoted 7 lines · Tom Rini
Quoted 2 lines · Heinrich Schuchardt

C is the sign for coulomb which is the unit of electric charge. How about 'deg C'?

I'll note that in Linux there's seemingly nothing consistent, and I'm fine with any of "deg C" or "degrees C" or "temperature range (-40 C to +85 C)" as all of those should be clear in context.

Quoted 6 lines
Quoted 3 lines

My 2 cents ... while I agree with Tom that the context will make it clear, it is not making it correct nor nice. Using just "C" for Celsius degrees is horrible ...

FWIW, I usually use "oC", which is far from perfect, but IMHO also far from horrible. :)

"oC" is also horrible, "deg C" or "degrees C" that Heinrich proposed are the way to go if you need something 7-bit ascii :-).

Francesco

#17 lore raw

Re: [PATCH 4/4] Kconfig: Make all Kconfig encoding ascii

Quoted 15 lines · Francesco Dolcini
Quoted 14 lines · Dragan Simic
Quoted 12 lines · Francesco Dolcini
Quoted 7 lines · Tom Rini
Quoted 2 lines · Heinrich Schuchardt

C is the sign for coulomb which is the unit of electric charge. How about 'deg C'?

I'll note that in Linux there's seemingly nothing consistent, and I'm fine with any of "deg C" or "degrees C" or "temperature range (-40 C to +85 C)" as all of those should be clear in context.

My 2 cents ... while I agree with Tom that the context will make it clear, it is not making it correct nor nice. Using just "C" for Celsius degrees is horrible ...

Quoted 5 lines
Quoted 2 lines

FWIW, I usually use "oC", which is far from perfect, but IMHO also far from horrible. :)

"oC" is also horrible, "deg C" or "degrees C" that Heinrich proposed are the way to go if you need something 7-bit ascii :-).

I agree, "deg C" or "degrees C" is the way to go, and my vote goes to "degrees C". Just to clarify, I use "oC" as some kind of a shorthand when having less to type outweighs the correctness. :)