test/dma: update the sg test to verify wrap around case
PATCH 1/2 test/dma: update the sg test to verify wrap around case
Run the sg test in a loop to verify wrap around case.
Total number commands submitted to be more than the number descriptors allocated to verify the scenario.
app/test/test_dmadev.c +29 -16
@@ -393,34 +393,26 @@ test_stop_start(int16_t dev_id, uint16_t vchan) }static int -test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +test_enqueue_sg (int16_t dev_id,uint16_t vchan,unsigned int n_sge,unsigned int test_len) { -unsigned int src_len, dst_len, n_sge, len, i, j, k;char orig_src[COPY_LEN ], orig_dst[COPY_LEN ]; -struct rte_dma_info info = {0 }; +unsigned int src_len, dst_len, i, j, k;enum rte_dma_status_code status;uint16_t id, n_src, n_dst; -if (rte_dma_info_get (dev_id, &info) <0 ) -ERR_RETURN ("Failed to get dev info" ); - -if (info.max_sges <2 ) -ERR_RETURN ("Test needs minimum 2 SG pointers" ); - - n_sge = info.max_sges; -for (n_src =1 ; n_src <= n_sge; n_src++) {for (n_dst =1 ; n_dst <= n_sge; n_dst++) {/* Normalize SG buffer lengths */ - len =COPY_LEN ; - len -= (len % (n_src * n_dst)); - dst_len = len / n_dst; - src_len = len / n_src; - +unsigned int len = test_len - (test_len % (n_src * n_dst));struct rte_dma_sge sg_src[n_sge], sg_dst[n_sge];struct rte_mbuf *src[n_sge], *dst[n_sge];char *src_data[n_sge], *dst_data[n_sge]; + dst_len = len / n_dst; + src_len = len / n_src; +if (dst_len ==0 || src_len ==0 ) +continue ; +for (i =0 ; i < len; i++) orig_src[i] =rte_rand () &0xFF ;
@@ -511,6 +503,27 @@ test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan)return 0 ; } +static int +test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +{ +struct rte_dma_info info = {0 }; +unsigned int n_sge, len; +int loop_count =0 ; + +if (rte_dma_info_get (dev_id, &info) <0 ) +ERR_RETURN ("Failed to get dev info" ); + + n_sge =RTE_MIN (info.max_sges,TEST_SG_MAX ); + len =COPY_LEN ; + +do { +test_enqueue_sg (dev_id, vchan, n_sge, len); + loop_count++; + }while (loop_count * n_sge * n_sge <TEST_RINGSIZE *3 ); + +return 0 ; +} +/* Failure handling test cases - global macros and variables for those tests*/ #define COMP_BURST_SZ 16#define OPT_FENCE (idx) ((fence && idx == 8) ? RTE_DMA_OP_FLAG_FENCE : 0)
app/test/test_dmadev_api.c +0 -1
@@ -16,7 +16,6 @@ extern int test_dma_api(uint16_t dev_id);#define TEST_MEMCPY_SIZE 1024#define TEST_WAIT_US_VAL 50000 -#define TEST_SG_MAX 64static int16_t test_dev_id;static int16_t invalid_dev_id;
app/test/test_dmadev_api.h +2 -0
@@ -2,4 +2,6 @@* Copyright(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 +int test_dma_api (uint16_t dev_id);
Signature · 1 line
2.25.1
PATCH 2/2 test/dma: add functions to verify zero and one fill
Add test cases to verify zero fill and one fill
app/test/test.h +4 -0
@@ -27,6 +27,10 @@#include <rte_test.h> +#ifndef ARRAY_SIZE +#define ARRAY_SIZE (x) (sizeof(x) / sizeof((x)[0])) +#endif +#define TEST_ASSERT RTE_TEST_ASSERT#define TEST_ASSERT_EQUAL RTE_TEST_ASSERT_EQUAL
app/test/test_dmadev.c +34 -24
76 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH v2 1/2 test/dma: update the sg test to verify wrap around case
In reply to Vidya Sagar VelumuriRun the sg test in a loop to verify wrap around case.
Total number commands submitted to be more than the number descriptors allocated to verify the scenario.
app/test/test_dmadev.c +29 -16
@@ -393,34 +393,26 @@ test_stop_start(int16_t dev_id, uint16_t vchan) }static int -test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +test_enqueue_sg (int16_t dev_id,uint16_t vchan,unsigned int n_sge,unsigned int test_len) { -unsigned int src_len, dst_len, n_sge, len, i, j, k;char orig_src[COPY_LEN ], orig_dst[COPY_LEN ]; -struct rte_dma_info info = {0 }; +unsigned int src_len, dst_len, i, j, k;enum rte_dma_status_code status;uint16_t id, n_src, n_dst; -if (rte_dma_info_get (dev_id, &info) <0 ) -ERR_RETURN ("Failed to get dev info" ); - -if (info.max_sges <2 ) -ERR_RETURN ("Test needs minimum 2 SG pointers" ); - - n_sge = info.max_sges; -for (n_src =1 ; n_src <= n_sge; n_src++) {for (n_dst =1 ; n_dst <= n_sge; n_dst++) {/* Normalize SG buffer lengths */ - len =COPY_LEN ; - len -= (len % (n_src * n_dst)); - dst_len = len / n_dst; - src_len = len / n_src; - +unsigned int len = test_len - (test_len % (n_src * n_dst));struct rte_dma_sge sg_src[n_sge], sg_dst[n_sge];struct rte_mbuf *src[n_sge], *dst[n_sge];char *src_data[n_sge], *dst_data[n_sge]; + dst_len = len / n_dst; + src_len = len / n_src; +if (dst_len ==0 || src_len ==0 ) +continue ; +for (i =0 ; i < len; i++) orig_src[i] =rte_rand () &0xFF ;
@@ -511,6 +503,27 @@ test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan)return 0 ; } +static int +test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +{ +struct rte_dma_info info = {0 }; +unsigned int n_sge, len; +int loop_count =0 ; + +if (rte_dma_info_get (dev_id, &info) <0 ) +ERR_RETURN ("Failed to get dev info" ); + + n_sge =RTE_MIN (info.max_sges,TEST_SG_MAX ); + len =COPY_LEN ; + +do { +test_enqueue_sg (dev_id, vchan, n_sge, len); + loop_count++; + }while (loop_count * n_sge * n_sge <TEST_RINGSIZE *3 ); + +return 0 ; +} +/* Failure handling test cases - global macros and variables for those tests*/ #define COMP_BURST_SZ 16#define OPT_FENCE (idx) ((fence && idx == 8) ? RTE_DMA_OP_FLAG_FENCE : 0)
app/test/test_dmadev_api.c +0 -1
@@ -16,7 +16,6 @@ extern int test_dma_api(uint16_t dev_id);#define TEST_MEMCPY_SIZE 1024#define TEST_WAIT_US_VAL 50000 -#define TEST_SG_MAX 64static int16_t test_dev_id;static int16_t invalid_dev_id;
app/test/test_dmadev_api.h +2 -0
@@ -2,4 +2,6 @@* Copyright(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 +int test_dma_api (uint16_t dev_id);
Signature · 1 line
2.25.1
PATCH v2 2/2 test/dma: add functions to verify zero and one fill
Add test cases to verify zero fill and one fill
app/test/test.h +4 -0
@@ -27,6 +27,10 @@#include <rte_test.h> +#ifndef ARRAY_SIZE +#define ARRAY_SIZE (x) (sizeof(x) / sizeof((x)[0])) +#endif +#define TEST_ASSERT RTE_TEST_ASSERT#define TEST_ASSERT_EQUAL RTE_TEST_ASSERT_EQUAL
app/test/test_dmadev.c +33 -24
75 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [EXTERNAL] [PATCH v2 2/2] test/dma: add functions to verify zero and one fill
________________________________
From: Vidya Sagar Velumuri <[email protected]>
Sent: Friday, April 19, 2024 2:37 PM
To: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Cc: Jerin Jacob <[email protected]>; Anoob Joseph <[email protected]>; Vidya Sagar Velumuri <[email protected]>; Aakash Sasidharan <[email protected]>; Tejasree Kondoj <[email protected]>; Gowrishankar Muthukrishnan <[email protected]>; [email protected] <[email protected]>
Subject: [EXTERNAL] [PATCH v2 2/2] test/dma: add functions to verify zero and one fill
Prioritize security for external emails: Confirm sender and content safety before clicking links or opening attachments
----------------------------------------------------------------------
Add test cases to verify zero fill and one fill
app/test/test.h +4 -0
@@ -27,6 +27,10 @@#include <rte_test.h> +#ifndef ARRAY_SIZE +#define ARRAY_SIZE (x) (sizeof(x) / sizeof((x)[0])) +#endif +#define TEST_ASSERT RTE_TEST_ASSERT#define TEST_ASSERT_EQUAL RTE_TEST_ASSERT_EQUAL
app/test/test_dmadev.c +33 -24
75 lines not on this page · raw message
--
2.25.1
Thanks
RE: [EXTERNAL] [PATCH v2 2/2] test/dma: add functions to verify zero and one fill
In reply to Vidya Sagar VelumuriQuoted 126 lines
-----Original Message-----
From: Vidya Sagar Velumuri <[email protected]>
Sent: Friday, April 19, 2024 2:38 PM
To: [email protected]; [email protected]; [email protected]
Cc: Jerin Jacob <[email protected]>; Anoob Joseph <[email protected]>; Vidya Sagar Velumuri <[email protected]>; Aakash Sasidharan <[email protected]>; Tejasree Kondoj <[email protected]>; Gowrishankar Muthukrishnan <[email protected]>; [email protected]
Subject: [EXTERNAL] [PATCH v2 2/2] test/dma: add functions to verify zero and one fillPrioritize security for external emails: Confirm sender and content safety before clicking links or opening attachments
----------------------------------------------------------------------
Add test cases to verify zero fill and one fillSigned-off-by Vidya Sagar Velumuri <[email protected]> diff --git
a/app/test/test.hb/app/test/test.hindex15e23d297f..0ca6519f6e100644app/test/test.h +3
-0@@ -27,6 +27,10 @@#include <rte_test.h> +#ifndef ARRAY_SIZE +#define ARRAY_SIZE (x) (sizeof(x) / sizeof((x)[0])) #endif +#define TEST_ASSERT RTE_TEST_ASSERT#define TEST_ASSERT_EQUAL RTE_TEST_ASSERT_EQUAL diff --git
a/app/test/test_dmadev.cb/app/test/test_dmadev.cindex7462e90831..ec896a4905100644app/test/test_dmadev.c +29
-19@@ -869,42 +869,51 @@ test_completion_handling(int16_t dev_id, uint16_t vchan) static int test_enqueue_fill(int16_t dev_id, uint16_t vchan) { +uint64_t pattern[3 ] = {0x0 ,0xfedcba9876543210 ,0xffffffffffffffff };const unsigned int lengths[] = {8 ,64 ,1024 ,50 ,100 ,89 }; +unsigned int i, j, k;struct rte_mbuf *dst;char *dst_data; -uint64_t pattern =0xfedcba9876543210 ; -unsigned int i, j; dst =rte_pktmbuf_alloc (pool);if (dst ==NULL )ERR_RETURN ("Failed to allocate mbuf\n" ); dst_data = rte_pktmbuf_mtod(dst, char *); -for (i =0 ; i <RTE_DIM (lengths); i++) { -/* reset dst_data */ -memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); +for (k =0 ; k <ARRAY_SIZE (pattern); k++) { +for (i =0 ; i <RTE_DIM (lengths); i++) { +/* reset dst_data */ +memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); + +/* perform the fill operation */ +int id =rte_dma_fill (dev_id, vchan, pattern[k], +rte_pktmbuf_iova (dst), lengths[i],RTE_DMA_OP_FLAG_SUBMIT ); +if (id <0 ) { +if (id == -ENOTSUP ) { +rte_pktmbuf_free (dst); +break ; + } +ERR_RETURN ("Error with rte_dma_fill\n" ); + } +await_hw (dev_id, vchan); -/* perform the fill operation */ -int id =rte_dma_fill (dev_id, vchan, pattern, -rte_pktmbuf_iova (dst), lengths[i], RTE_DMA_OP_FLAG_SUBMIT); -if (id <0 ) -ERR_RETURN ("Error with rte_dma_fill\n" ); -await_hw (dev_id, vchan); +if (rte_dma_completed (dev_id, vchan,1 ,NULL ,NULL ) !=1 ) + ERR_RETURN("Error: fill operation failed (length: %u)\n", + lengths[i]); +/* check the data from the fill operation is correct */ +for (j =0 ; j < lengths[i]; j++) { +char pat_byte = ((char *)&pattern[k])[j %8 ]; - if (rte_dma_completed(dev_id, vchan, 1, NULL, NULL) != 1) - ERR_RETURN("Error: fill operation failed (length: %u)\n", lengths[i]); - /* check the data from the fill operation is correct */ - for (j = 0; j < lengths[i]; j++) { -char pat_byte = ((char *)&pattern)[j %8 ]; -if (dst_data[j] != pat_byte) - ERR_RETURN("Error with fill operation (lengths = %u): got (%x), not (%x)\n", - lengths[i], dst_data[j], pat_byte); +if (dst_data[j] != pat_byte) + ERR_RETURN("Error with fill operation (lengths = %u): got (%x), not (%x)\n", + lengths[i], dst_data[j], pat_byte); + } +/* check that the data after the fill operation was not written to */
app/test/test_dmadev.c +3
-0+for (; j <rte_pktmbuf_data_len (dst); j++) +if (dst_data[j] !=0 ) + ERR_RETURN("Error, fill operationwrote too far (lengths = %u): got (%x), not (%x)\n",
app/test/test_dmadev.c +1
-0+ lengths[i], dst_data[j],0);
app/test/test_dmadev.c +0
-1} -/* check that the data after the fill operation was not written to */
app/test/test_dmadev.c +0
-3-for (; j <rte_pktmbuf_data_len (dst); j++) -if (dst_data[j] !=0 ) - ERR_RETURN("Error, fill operation wrote toofar (lengths = %u): got (%x), not (%x)\n",
app/test/test_dmadev.c +0
-2- lengths[i], dst_data[j], 0); }rte_pktmbuf_free (dst); --
Quoted 1 line
2.25.1
Thanks
Re: [PATCH v2 2/2] test/dma: add functions to verify zero and one fill
In reply to Vidya Sagar Velumuri19/04/2024 11:07, Vidya Sagar Velumuri:
Quoted 3 lines
Add test cases to verify zero fill and one fill
Signed-off-by Vidya Sagar Velumuri <[email protected]>
Waiting for review from DMA maintainers.
app/test/test.h line 32
Quoted 11 lines
app/test/test.h +3
-0@@ -27,6 +27,10 @@#include <rte_test.h> +#ifndef ARRAY_SIZE +#define ARRAY_SIZE (x) (sizeof(x) / sizeof((x)[0])) +#endif
Just one comment about this one: please use RTE_DIM.
________________________________
From: Vidya Sagar Velumuri <[email protected]>
Sent: Friday, April 19, 2024 2:37 PM
To: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Cc: Jerin Jacob <[email protected]>; Anoob Joseph <[email protected]>; Vidya Sagar Velumuri <[email protected]>; Aakash Sasidharan <[email protected]>; Tejasree Kondoj <[email protected]>; Gowrishankar Muthukrishnan <[email protected]>; [email protected] <[email protected]>
Subject: [EXTERNAL] [PATCH v2 1/2] test/dma: update the sg test to verify wrap around case
Prioritize security for external emails: Confirm sender and content safety before clicking links or opening attachments
----------------------------------------------------------------------
Run the sg test in a loop to verify wrap around case.
Total number commands submitted to be more than the number descriptors allocated to verify the scenario.
app/test/test_dmadev.c +29 -16
@@ -393,34 +393,26 @@ test_stop_start(int16_t dev_id, uint16_t vchan) }static int -test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +test_enqueue_sg (int16_t dev_id,uint16_t vchan,unsigned int n_sge,unsigned int test_len) { -unsigned int src_len, dst_len, n_sge, len, i, j, k;char orig_src[COPY_LEN ], orig_dst[COPY_LEN ]; -struct rte_dma_info info = {0 }; +unsigned int src_len, dst_len, i, j, k;enum rte_dma_status_code status;uint16_t id, n_src, n_dst; -if (rte_dma_info_get (dev_id, &info) <0 ) -ERR_RETURN ("Failed to get dev info" ); - -if (info.max_sges <2 ) -ERR_RETURN ("Test needs minimum 2 SG pointers" ); - - n_sge = info.max_sges; -for (n_src =1 ; n_src <= n_sge; n_src++) {for (n_dst =1 ; n_dst <= n_sge; n_dst++) {/* Normalize SG buffer lengths */ - len =COPY_LEN ; - len -= (len % (n_src * n_dst)); - dst_len = len / n_dst; - src_len = len / n_src; - +unsigned int len = test_len - (test_len % (n_src * n_dst));struct rte_dma_sge sg_src[n_sge], sg_dst[n_sge];struct rte_mbuf *src[n_sge], *dst[n_sge];char *src_data[n_sge], *dst_data[n_sge]; + dst_len = len / n_dst; + src_len = len / n_src; +if (dst_len ==0 || src_len ==0 ) +continue ; +for (i =0 ; i < len; i++) orig_src[i] =rte_rand () &0xFF ;
@@ -511,6 +503,27 @@ test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan)return 0 ; } +static int +test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +{ +struct rte_dma_info info = {0 }; +unsigned int n_sge, len; +int loop_count =0 ; + +if (rte_dma_info_get (dev_id, &info) <0 ) +ERR_RETURN ("Failed to get dev info" ); + + n_sge =RTE_MIN (info.max_sges,TEST_SG_MAX ); + len =COPY_LEN ; + +do { +test_enqueue_sg (dev_id, vchan, n_sge, len); + loop_count++; + }while (loop_count * n_sge * n_sge <TEST_RINGSIZE *3 ); + +return 0 ; +} +/* Failure handling test cases - global macros and variables for those tests*/ #define COMP_BURST_SZ 16#define OPT_FENCE (idx) ((fence && idx == 8) ? RTE_DMA_OP_FLAG_FENCE : 0)
app/test/test_dmadev_api.c +0 -1
@@ -16,7 +16,6 @@ extern int test_dma_api(uint16_t dev_id);#define TEST_MEMCPY_SIZE 1024#define TEST_WAIT_US_VAL 50000 -#define TEST_SG_MAX 64static int16_t test_dev_id;static int16_t invalid_dev_id;
app/test/test_dmadev_api.h +2 -0
@@ -2,4 +2,6 @@* Copyright(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 +int test_dma_api (uint16_t dev_id);
--
2.25.1
Thanks
Quoted 122 lines
-----Original Message-----
From: Vidya Sagar Velumuri <[email protected]>
Sent: Friday, April 19, 2024 2:38 PM
To: [email protected]; [email protected]; [email protected]
Cc: Jerin Jacob <[email protected]>; Anoob Joseph <[email protected]>; Vidya Sagar Velumuri <[email protected]>; Aakash Sasidharan <[email protected]>; Tejasree Kondoj <[email protected]>; Gowrishankar Muthukrishnan <[email protected]>; [email protected]
Subject: [EXTERNAL] [PATCH v2 1/2] test/dma: update the sg test to verify wrap around casePrioritize security for external emails: Confirm sender and content safety before clicking links or opening attachments
----------------------------------------------------------------------
Run the sg test in a loop to verify wrap around case.
Total number commands submitted to be more than the number descriptors allocated to verify the scenario.Signed-off-by Vidya Sagar Velumuri <[email protected]> diff --git
a/app/test/test_dmadev.cb/app/test/test_dmadev.cindex143e1bcd68..7462e90831100644app/test/test_dmadev.c +29
-16@@ -393,34 +393,26 @@ test_stop_start(int16_t dev_id, uint16_t vchan) }static int -test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +test_enqueue_sg (int16_t dev_id,uint16_t vchan,unsigned int n_sge, +unsigned int test_len) { -unsigned int src_len, dst_len, n_sge, len, i, j, k;char orig_src[COPY_LEN ], orig_dst[COPY_LEN ]; -struct rte_dma_info info = {0 }; +unsigned int src_len, dst_len, i, j, k;enum rte_dma_status_code status;uint16_t id, n_src, n_dst; -if (rte_dma_info_get (dev_id, &info) <0 ) -ERR_RETURN ("Failed to get dev info" ); - -if (info.max_sges <2 ) -ERR_RETURN ("Test needs minimum 2 SG pointers" ); - - n_sge = info.max_sges; -for (n_src =1 ; n_src <= n_sge; n_src++) {for (n_dst =1 ; n_dst <= n_sge; n_dst++) {/* Normalize SG buffer lengths */ - len =COPY_LEN ; - len -= (len % (n_src * n_dst)); - dst_len = len / n_dst; - src_len = len / n_src; - +unsigned int len = test_len - (test_len % (n_src * n_dst));struct rte_dma_sge sg_src[n_sge], sg_dst[n_sge];struct rte_mbuf *src[n_sge], *dst[n_sge];char *src_data[n_sge], *dst_data[n_sge]; + dst_len = len / n_dst; + src_len = len / n_src; +if (dst_len ==0 || src_len ==0 ) +continue ; +for (i =0 ; i < len; i++) orig_src[i] =rte_rand () &0xFF ;@@ -511,6 +503,27 @@ test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan)return 0 ; } +static int +test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) { +struct rte_dma_info info = {0 }; +unsigned int n_sge, len; +int loop_count =0 ; + +if (rte_dma_info_get (dev_id, &info) <0 ) +ERR_RETURN ("Failed to get dev info" ); + + n_sge =RTE_MIN (info.max_sges,TEST_SG_MAX ); + len =COPY_LEN ; + +do { +test_enqueue_sg (dev_id, vchan, n_sge, len); + loop_count++; + }while (loop_count * n_sge * n_sge <TEST_RINGSIZE *3 ); + +return 0 ; +} +/* Failure handling test cases - global macros and variables for those tests*/ #define COMP_BURST_SZ 16#define OPT_FENCE (idx) ((fence && idx == 8) ? RTE_DMA_OP_FLAG_FENCE :0) diff --git
a/app/test/test_dmadev_api.cb/app/test/test_dmadev_api.cindexd40c05cfbf..6a07ed593b100644app/test/test_dmadev_api.c +0
-1@@ -16,7 +16,6 @@ extern int test_dma_api(uint16_t dev_id);#define TEST_MEMCPY_SIZE 1024#define TEST_WAIT_US_VAL 50000 -#define TEST_SG_MAX 64static int16_t test_dev_id;static int16_t invalid_dev_id;app/test/test_dmadev_api.h index renamed from app/test/test_dmadev_api.h +0
-0
33fbc5bd41..a03f7acd4f100644app/test/test_dmadev_api.h +2
-1@@ -2,4 +2,6 @@* Copyright(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 +int test_dma_api (uint16_t dev_id); --
Quoted 1 line
2.25.1
Thanks
PATCH v3 1/2 test/dma: update the sg test to verify wrap around case
In reply to Vidya Sagar VelumuriRun the sg test in a loop to verify wrap around case.
Total number commands submitted to be more than the number descriptors allocated to verify the scenario.
app/test/test_dmadev.c +29 -16
@@ -393,36 +393,28 @@ test_stop_start(int16_t dev_id, uint16_t vchan) }static int -test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +test_enqueue_sg (int16_t dev_id,uint16_t vchan,unsigned int n_sge,unsigned int test_len) { -unsigned int src_len, dst_len, n_sge, len, i, j, k;char orig_src[COPY_LEN ], orig_dst[COPY_LEN ]; -struct rte_dma_info info = {0 }; +unsigned int src_len, dst_len, i, j, k;enum rte_dma_status_code status;uint16_t id, n_src, n_dst; -if (rte_dma_info_get (dev_id, &info) <0 ) -ERR_RETURN ("Failed to get dev info" ); - -if (info.max_sges <2 ) -ERR_RETURN ("Test needs minimum 2 SG pointers" ); - - n_sge = info.max_sges; -for (n_src =1 ; n_src <= n_sge; n_src++) {for (n_dst =1 ; n_dst <= n_sge; n_dst++) {/* Normalize SG buffer lengths */ - len =COPY_LEN ; - len -= (len % (n_src * n_dst)); - dst_len = len / n_dst; - src_len = len / n_src; -struct rte_dma_sge *sg_src =alloca (sizeof (struct rte_dma_sge ) * n_sge);struct rte_dma_sge *sg_dst =alloca (sizeof (struct rte_dma_sge ) * n_sge);struct rte_mbuf **src =alloca (sizeof (struct rte_mbuf *) * n_sge);struct rte_mbuf **dst =alloca (sizeof (struct rte_mbuf *) * n_sge);char **src_data =alloca (sizeof (char *) * n_sge);char **dst_data =alloca (sizeof (char *) * n_sge); +unsigned int len = test_len - (test_len % (n_src * n_dst)); + + dst_len = len / n_dst; + src_len = len / n_src; +if (dst_len ==0 || src_len ==0 ) +continue ;for (i =0 ; i < len; i++) orig_src[i] =rte_rand () &0xFF ;
@@ -514,6 +506,27 @@ test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan)return 0 ; } +static int +test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +{ +struct rte_dma_info info = {0 }; +unsigned int n_sge, len; +int loop_count =0 ; + +if (rte_dma_info_get (dev_id, &info) <0 ) +ERR_RETURN ("Failed to get dev info" ); + + n_sge =RTE_MIN (info.max_sges,TEST_SG_MAX ); + len =COPY_LEN ; + +do { +test_enqueue_sg (dev_id, vchan, n_sge, len); + loop_count++; + }while (loop_count * n_sge * n_sge <TEST_RINGSIZE *3 ); + +return 0 ; +} +/* Failure handling test cases - global macros and variables for those tests*/ #define COMP_BURST_SZ 16#define OPT_FENCE (idx) ((fence && idx == 8) ? RTE_DMA_OP_FLAG_FENCE : 0)
app/test/test_dmadev_api.c +0 -1
@@ -16,7 +16,6 @@ extern int test_dma_api(uint16_t dev_id);#define TEST_MEMCPY_SIZE 1024#define TEST_WAIT_US_VAL 50000 -#define TEST_SG_MAX 64static int16_t test_dev_id;static int16_t invalid_dev_id;
app/test/test_dmadev_api.h +2 -0
@@ -2,4 +2,6 @@* Copyright(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 +int test_dma_api (uint16_t dev_id);
Signature · 1 line
2.25.1
PATCH v3 2/2 test/dma: add functions to verify zero and one fill
Add test cases to verify zero fill and one fill
app/test/test_dmadev.c +34 -24
@@ -872,42 +872,52 @@ test_completion_handling(int16_t dev_id, uint16_t vchan)static int test_enqueue_fill (int16_t dev_id,uint16_t vchan) { +uint64_t pattern[3 ] = {0x0 ,0xfedcba9876543210 ,0xffffffffffffffff };const unsigned int lengths[] = {8 ,64 ,1024 ,50 ,100 ,89 }; +unsigned int i, j, k;struct rte_mbuf *dst;char *dst_data; -uint64_t pattern =0xfedcba9876543210 ; -unsigned int i, j; dst =rte_pktmbuf_alloc (pool);if (dst ==NULL )ERR_RETURN ("Failed to allocate mbuf\n" ); dst_data = rte_pktmbuf_mtod(dst, char *); -for (i =0 ; i <RTE_DIM (lengths); i++) { -/* reset dst_data */ -memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); +for (k =0 ; k <RTE_DIM (pattern); k++) { +printf ("Test fill pattern: 0x%016lx\n" , pattern[k]); +for (i =0 ; i <RTE_DIM (lengths); i++) { +/* reset dst_data */ +memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); + +/* perform the fill operation */ +int id =rte_dma_fill (dev_id, vchan, pattern[k], +rte_pktmbuf_iova (dst), lengths[i],RTE_DMA_OP_FLAG_SUBMIT ); +if (id <0 ) { +if (id == -ENOTSUP ) { +rte_pktmbuf_free (dst); +break ; + } +ERR_RETURN ("Error with rte_dma_fill\n" ); + } +await_hw (dev_id, vchan); -/* perform the fill operation */ -int id =rte_dma_fill (dev_id, vchan, pattern, -rte_pktmbuf_iova (dst), lengths[i],RTE_DMA_OP_FLAG_SUBMIT ); -if (id <0 ) -ERR_RETURN ("Error with rte_dma_fill\n" ); -await_hw (dev_id, vchan); +if (rte_dma_completed (dev_id, vchan,1 ,NULL ,NULL ) !=1 ) +ERR_RETURN ("Error: fill operation failed (length: %u)\n" , + lengths[i]); +/* check the data from the fill operation is correct */ +for (j =0 ; j < lengths[i]; j++) { +char pat_byte = ((char *)&pattern[k])[j %8 ]; -if (rte_dma_completed (dev_id, vchan,1 ,NULL ,NULL ) !=1 ) -ERR_RETURN ("Error: fill operation failed (length: %u)\n" , lengths[i]); -/* check the data from the fill operation is correct */ -for (j =0 ; j < lengths[i]; j++) { -char pat_byte = ((char *)&pattern)[j %8 ]; -if (dst_data[j] != pat_byte) -ERR_RETURN ("Error with fill operation (lengths = %u): got (%x), not (%x)\n" , - lengths[i], dst_data[j], pat_byte); +if (dst_data[j] != pat_byte) +ERR_RETURN ("Error with fill operation (lengths = %u): got (%x), not (%x)\n" , + lengths[i], dst_data[j], pat_byte); + } +/* check that the data after the fill operation was not written to */ +for (; j <rte_pktmbuf_data_len (dst); j++) +if (dst_data[j] !=0 ) +ERR_RETURN ("Error, fill operation wrote too far (lengths = %u): got (%x), not (%x)\n" , + lengths[i], dst_data[j],0 ); } -/* check that the data after the fill operation was not written to */ -for (; j <rte_pktmbuf_data_len (dst); j++) -if (dst_data[j] !=0 ) -ERR_RETURN ("Error, fill operation wrote too far (lengths = %u): got (%x), not (%x)\n" , - lengths[i], dst_data[j],0 ); }rte_pktmbuf_free (dst);
Signature · 1 line
2.25.1
PATCH v4 1/2 test/dma: update the sg test to verify wrap around case
In reply to Vidya Sagar VelumuriRun the sg test in a loop to verify wrap around case.
Total number commands submitted to be more than the number descriptors allocated to verify the scenario.
app/test/test_dmadev.c +29 -16
@@ -393,36 +393,28 @@ test_stop_start(int16_t dev_id, uint16_t vchan) }static int -test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +test_enqueue_sg (int16_t dev_id,uint16_t vchan,unsigned int n_sge,unsigned int test_len) { -unsigned int src_len, dst_len, n_sge, len, i, j, k;char orig_src[COPY_LEN ], orig_dst[COPY_LEN ]; -struct rte_dma_info info = {0 }; +unsigned int src_len, dst_len, i, j, k;enum rte_dma_status_code status;uint16_t id, n_src, n_dst; -if (rte_dma_info_get (dev_id, &info) <0 ) -ERR_RETURN ("Failed to get dev info" ); - -if (info.max_sges <2 ) -ERR_RETURN ("Test needs minimum 2 SG pointers" ); - - n_sge = info.max_sges; -for (n_src =1 ; n_src <= n_sge; n_src++) {for (n_dst =1 ; n_dst <= n_sge; n_dst++) {/* Normalize SG buffer lengths */ - len =COPY_LEN ; - len -= (len % (n_src * n_dst)); - dst_len = len / n_dst; - src_len = len / n_src; -struct rte_dma_sge *sg_src =alloca (sizeof (struct rte_dma_sge ) * n_sge);struct rte_dma_sge *sg_dst =alloca (sizeof (struct rte_dma_sge ) * n_sge);struct rte_mbuf **src =alloca (sizeof (struct rte_mbuf *) * n_sge);struct rte_mbuf **dst =alloca (sizeof (struct rte_mbuf *) * n_sge);char **src_data =alloca (sizeof (char *) * n_sge);char **dst_data =alloca (sizeof (char *) * n_sge); +unsigned int len = test_len - (test_len % (n_src * n_dst)); + + dst_len = len / n_dst; + src_len = len / n_src; +if (dst_len ==0 || src_len ==0 ) +continue ;for (i =0 ; i < len; i++) orig_src[i] =rte_rand () &0xFF ;
@@ -514,6 +506,27 @@ test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan)return 0 ; } +static int +test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +{ +struct rte_dma_info info = {0 }; +unsigned int n_sge, len; +int loop_count =0 ; + +if (rte_dma_info_get (dev_id, &info) <0 ) +ERR_RETURN ("Failed to get dev info" ); + + n_sge =RTE_MIN (info.max_sges,TEST_SG_MAX ); + len =COPY_LEN ; + +do { +test_enqueue_sg (dev_id, vchan, n_sge, len); + loop_count++; + }while (loop_count * n_sge * n_sge <TEST_RINGSIZE *3 ); + +return 0 ; +} +/* Failure handling test cases - global macros and variables for those tests*/ #define COMP_BURST_SZ 16#define OPT_FENCE (idx) ((fence && idx == 8) ? RTE_DMA_OP_FLAG_FENCE : 0)
app/test/test_dmadev_api.c +0 -1
@@ -16,7 +16,6 @@ extern int test_dma_api(uint16_t dev_id);#define TEST_MEMCPY_SIZE 1024#define TEST_WAIT_US_VAL 50000 -#define TEST_SG_MAX 64static int16_t test_dev_id;static int16_t invalid_dev_id;
app/test/test_dmadev_api.h +2 -0
@@ -2,4 +2,6 @@* Copyright(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 +int test_dma_api (uint16_t dev_id);
Signature · 1 line
2.25.1
PATCH v4 2/2 test/dma: add functions to verify zero and one fill
Add test cases to verify zero fill and one fill
app/test/test_dmadev.c +33 -24
@@ -872,42 +872,51 @@ test_completion_handling(int16_t dev_id, uint16_t vchan)static int test_enqueue_fill (int16_t dev_id,uint16_t vchan) { +uint64_t pattern[3 ] = {0x0 ,0xfedcba9876543210 ,0xffffffffffffffff };const unsigned int lengths[] = {8 ,64 ,1024 ,50 ,100 ,89 }; +unsigned int i, j, k;struct rte_mbuf *dst;char *dst_data; -uint64_t pattern =0xfedcba9876543210 ; -unsigned int i, j; dst =rte_pktmbuf_alloc (pool);if (dst ==NULL )ERR_RETURN ("Failed to allocate mbuf\n" ); dst_data = rte_pktmbuf_mtod(dst, char *); -for (i =0 ; i <RTE_DIM (lengths); i++) { -/* reset dst_data */ -memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); +for (k =0 ; k <RTE_DIM (pattern); k++) { +for (i =0 ; i <RTE_DIM (lengths); i++) { +/* reset dst_data */ +memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); + +/* perform the fill operation */ +int id =rte_dma_fill (dev_id, vchan, pattern[k], +rte_pktmbuf_iova (dst), lengths[i],RTE_DMA_OP_FLAG_SUBMIT ); +if (id <0 ) { +if (id == -ENOTSUP ) { +rte_pktmbuf_free (dst); +break ; + } +ERR_RETURN ("Error with rte_dma_fill\n" ); + } +await_hw (dev_id, vchan); -/* perform the fill operation */ -int id =rte_dma_fill (dev_id, vchan, pattern, -rte_pktmbuf_iova (dst), lengths[i],RTE_DMA_OP_FLAG_SUBMIT ); -if (id <0 ) -ERR_RETURN ("Error with rte_dma_fill\n" ); -await_hw (dev_id, vchan); +if (rte_dma_completed (dev_id, vchan,1 ,NULL ,NULL ) !=1 ) +ERR_RETURN ("Error: fill operation failed (length: %u)\n" , + lengths[i]); +/* check the data from the fill operation is correct */ +for (j =0 ; j < lengths[i]; j++) { +char pat_byte = ((char *)&pattern[k])[j %8 ]; -if (rte_dma_completed (dev_id, vchan,1 ,NULL ,NULL ) !=1 ) -ERR_RETURN ("Error: fill operation failed (length: %u)\n" , lengths[i]); -/* check the data from the fill operation is correct */ -for (j =0 ; j < lengths[i]; j++) { -char pat_byte = ((char *)&pattern)[j %8 ]; -if (dst_data[j] != pat_byte) -ERR_RETURN ("Error with fill operation (lengths = %u): got (%x), not (%x)\n" , - lengths[i], dst_data[j], pat_byte); +if (dst_data[j] != pat_byte) +ERR_RETURN ("Error with fill operation (lengths = %u): got (%x), not (%x)\n" , + lengths[i], dst_data[j], pat_byte); + } +/* check that the data after the fill operation was not written to */ +for (; j <rte_pktmbuf_data_len (dst); j++) +if (dst_data[j] !=0 ) +ERR_RETURN ("Error, fill operation wrote too far (lengths = %u): got (%x), not (%x)\n" , + lengths[i], dst_data[j],0 ); } -/* check that the data after the fill operation was not written to */ -for (; j <rte_pktmbuf_data_len (dst); j++) -if (dst_data[j] !=0 ) -ERR_RETURN ("Error, fill operation wrote too far (lengths = %u): got (%x), not (%x)\n" , - lengths[i], dst_data[j],0 ); }rte_pktmbuf_free (dst);
Signature · 1 line
2.25.1
Re: [PATCH v4 2/2] test/dma: add functions to verify zero and one fill
Hi Vidya,
How about add a wrap function and keep this function (could modify it's name).
static int
test_enqueue_fill() {
uint64_t pattern[3] = {0x0, 0xfedcba9876543210, 0xffffffffffffffff};
int i;
for (i = 0; i < RTE_DIM(pattern); i++) {
ret = test_enqueue_fill_patter(dev_id, vchan, pattern[i]);
if (ret)
return ret;
}
return 0;
}Quoted 85 lines · Vidya Sagar Velumuri
Add test cases to verify zero fill and one fill
Signed-off-by Vidya Sagar Velumuri <[email protected]>app/test/test_dmadev.c +33
-24@@ -872,42 +872,51 @@ test_completion_handling(int16_t dev_id, uint16_t vchan)static int test_enqueue_fill (int16_t dev_id,uint16_t vchan) { +uint64_t pattern[3 ] = {0x0 ,0xfedcba9876543210 ,0xffffffffffffffff };const unsigned int lengths[] = {8 ,64 ,1024 ,50 ,100 ,89 }; +unsigned int i, j, k;struct rte_mbuf *dst;char *dst_data; -uint64_t pattern =0xfedcba9876543210 ; -unsigned int i, j; dst =rte_pktmbuf_alloc (pool);if (dst ==NULL )ERR_RETURN ("Failed to allocate mbuf\n" ); dst_data = rte_pktmbuf_mtod(dst, char *); -for (i =0 ; i <RTE_DIM (lengths); i++) { -/* reset dst_data */ -memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); +for (k =0 ; k <RTE_DIM (pattern); k++) { +for (i =0 ; i <RTE_DIM (lengths); i++) { +/* reset dst_data */ +memset (dst_data,0 ,rte_pktmbuf_data_len (dst)); + +/* perform the fill operation */ +int id =rte_dma_fill (dev_id, vchan, pattern[k], +rte_pktmbuf_iova (dst), lengths[i],RTE_DMA_OP_FLAG_SUBMIT ); +if (id <0 ) { +if (id == -ENOTSUP ) { +rte_pktmbuf_free (dst); +break ; + } +ERR_RETURN ("Error with rte_dma_fill\n" ); + } +await_hw (dev_id, vchan); -/* perform the fill operation */ -int id =rte_dma_fill (dev_id, vchan, pattern, -rte_pktmbuf_iova (dst), lengths[i],RTE_DMA_OP_FLAG_SUBMIT ); -if (id <0 ) -ERR_RETURN ("Error with rte_dma_fill\n" ); -await_hw (dev_id, vchan); +if (rte_dma_completed (dev_id, vchan,1 ,NULL ,NULL ) !=1 ) +ERR_RETURN ("Error: fill operation failed (length: %u)\n" , + lengths[i]); +/* check the data from the fill operation is correct */ +for (j =0 ; j < lengths[i]; j++) { +char pat_byte = ((char *)&pattern[k])[j %8 ]; -if (rte_dma_completed (dev_id, vchan,1 ,NULL ,NULL ) !=1 ) -ERR_RETURN ("Error: fill operation failed (length: %u)\n" , lengths[i]); -/* check the data from the fill operation is correct */ -for (j =0 ; j < lengths[i]; j++) { -char pat_byte = ((char *)&pattern)[j %8 ]; -if (dst_data[j] != pat_byte) -ERR_RETURN ("Error with fill operation (lengths = %u): got (%x), not (%x)\n" , - lengths[i], dst_data[j], pat_byte); +if (dst_data[j] != pat_byte) +ERR_RETURN ("Error with fill operation (lengths = %u): got (%x), not (%x)\n" , + lengths[i], dst_data[j], pat_byte); + } +/* check that the data after the fill operation was not written to */ +for (; j <rte_pktmbuf_data_len (dst); j++) +if (dst_data[j] !=0 ) +ERR_RETURN ("Error, fill operation wrote too far (lengths = %u): got (%x), not (%x)\n" , + lengths[i], dst_data[j],0 ); } -/* check that the data after the fill operation was not written to */ -for (; j <rte_pktmbuf_data_len (dst); j++) -if (dst_data[j] !=0 ) -ERR_RETURN ("Error, fill operation wrote too far (lengths = %u): got (%x), not (%x)\n" , - lengths[i], dst_data[j],0 ); }rte_pktmbuf_free (dst);
Re: [PATCH v4 2/2] test/dma: add functions to verify zero and one fill
Any news?
10/06/2025 08:48, fengchengwen:
Quoted 15 lines
Hi Vidya,
How about add a wrap function and keep this function (could modify it's name).
static int
test_enqueue_fill() { uint64_t pattern[3] = {0x0, 0xfedcba9876543210, 0xffffffffffffffff}; int i; for (i = 0; i < RTE_DIM(pattern); i++) { ret = test_enqueue_fill_patter(dev_id, vchan, pattern[i]); if (ret) return ret; } return 0; }
Hi Vidya,
Quoted 28 lines · Vidya Sagar Velumuri
Run the sg test in a loop to verify wrap around case.
Total number commands submitted to be more than the number descriptors allocated to verify the scenario.Signed-off-by Vidya Sagar Velumuri <[email protected]>app/test/test_dmadev.c +2
-6@@ -393,36 +393,28 @@ test_stop_start(int16_t dev_id, uint16_t vchan) }static int -test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +test_enqueue_sg (int16_t dev_id,uint16_t vchan,unsigned int n_sge,unsigned int test_len) { -unsigned int src_len, dst_len, n_sge, len, i, j, k;char orig_src[COPY_LEN ], orig_dst[COPY_LEN ]; -struct rte_dma_info info = {0 }; +unsigned int src_len, dst_len, i, j, k;enum rte_dma_status_code status;uint16_t id, n_src, n_dst; -if (rte_dma_info_get (dev_id, &info) <0 ) -ERR_RETURN ("Failed to get dev info" ); -
app/test/test_dmadev.c test_stop_start(int16_t dev_id, uint16_t vchan) · line 416
Quoted 10 lines
app/test/test_dmadev.c +0
-7-if (info.max_sges <2 ) -ERR_RETURN ("Test needs minimum 2 SG pointers" ); - - n_sge = info.max_sges; -for (n_src =1 ; n_src <= n_sge; n_src++) {for (n_dst =1 ; n_dst <= n_sge; n_dst++) {/* Normalize SG buffer lengths */ - len =COPY_LEN ; - len -= (len % (n_src * n_dst));
Please keep this line.
Quoted 27 lines
app/test/test_dmadev.c +11
-3- dst_len = len / n_dst; - src_len = len / n_src; -struct rte_dma_sge *sg_src =alloca (sizeof (struct rte_dma_sge ) * n_sge);struct rte_dma_sge *sg_dst =alloca (sizeof (struct rte_dma_sge ) * n_sge);struct rte_mbuf **src =alloca (sizeof (struct rte_mbuf *) * n_sge);struct rte_mbuf **dst =alloca (sizeof (struct rte_mbuf *) * n_sge);char **src_data =alloca (sizeof (char *) * n_sge);char **dst_data =alloca (sizeof (char *) * n_sge); +unsigned int len = test_len - (test_len % (n_src * n_dst)); + + dst_len = len / n_dst; + src_len = len / n_src; +if (dst_len ==0 || src_len ==0 ) +continue ;for (i =0 ; i < len; i++) orig_src[i] =rte_rand () &0xFF ;@@ -514,6 +506,27 @@ test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan)return 0 ; } +static int +test_enqueue_sg_copies (int16_t dev_id,uint16_t vchan) +{ +struct rte_dma_info info = {0 }; +unsigned int n_sge, len;
app/test/test_dmadev.c test_enqueue_sg_copies(int16_t dev_id, uint16_t vchan) · line 523
Quoted 10 lines
app/test/test_dmadev.c +10
-0+int loop_count =0 ; + +if (rte_dma_info_get (dev_id, &info) <0 ) +ERR_RETURN ("Failed to get dev info" ); + + n_sge =RTE_MIN (info.max_sges,TEST_SG_MAX ); + len =COPY_LEN ; + + do { + test_enqueue_sg(dev_id, vchan, n_sge, len);
Need check the function return, return retcode if this function failed.
Quoted 14 lines
app/test/test_dmadev.c +6
-0+ loop_count++; + }while (loop_count * n_sge * n_sge <TEST_RINGSIZE *3 ); + +return 0 ; +} +/* Failure handling test cases - global macros and variables for those tests*/ #define COMP_BURST_SZ 16#define OPT_FENCE (idx) ((fence && idx == 8) ? RTE_DMA_OP_FLAG_FENCE : 0)app/test/test_dmadev_api.c +0
-0
app/test/test_dmadev_api.c extern int test_dma_api(uint16_t dev_id); · line 19
Quoted 4 lines
app/test/test_dmadev_api.c +0
-1@@ -16,7 +16,6 @@ extern int test_dma_api(uint16_t dev_id);#define TEST_MEMCPY_SIZE 1024#define TEST_WAIT_US_VAL 50000 -#define TEST_SG_MAX 64
No need to public this macro, because test_enqueue_sg already use alloca to hold the dynamic size of sglist.
Quoted 14 lines
app/test/test_dmadev_api.c +0
-0static int16_t test_dev_id;static int16_t invalid_dev_id;app/test/test_dmadev_api.h +2
-0@@ -2,4 +2,6 @@* Copyright(c) 2021 HiSilicon Limited */ +#define TEST_SG_MAX 64 +int test_dma_api (uint16_t dev_id);