Skip to contentSkip to conversation

package/petitboot: add libxcrypt optional dependency

PATCH Applied Reza Arbab 2 participants 3 messages Apr 16, 2024 – May 2, 2024

lore
Share & tools
lore

Reza Arbab

author
#0 lore raw

PATCH 1/1 package/petitboot: add libxcrypt optional dependency

Fix the following build failure raised since bump of glibc to version 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97:

checking for crypt in -lcrypt... no
configure: error: in `/home/arbab/src/buildroot/output/build/petitboot-1.15':
configure: error: shadow/crypt libs required

---
 package/petitboot/Config.in    | 1 +
 package/petitboot/petitboot.mk | 1 +
 2 files changed, 2 insertions(+)
package/petitboot/Config.in +1 -0
index 533c7a9f2980..66836f31acd8 100644
@@ -14,6 +14,7 @@ config BR2_PACKAGE_PETITBOOT
 	# run-time dependencies
 	select BR2_PACKAGE_KEXEC if !BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS
 	select BR2_PACKAGE_KEXEC_LITE if BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS && !BR2_PACKAGE_KEXEC
+	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
 	select BR2_PACKAGE_NVME if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le )
 	select BR2_PACKAGE_POWERPC_UTILS if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le )
 	help
package/petitboot/petitboot.mk +1 -0
index cd7631fa5cae..2eb6461144cd 100644
@@ -14,6 +14,7 @@ PETITBOOT_DEPENDENCIES = \
 	host-bison \
 	host-flex \
 	lvm2 \
+	$(if $(BR2_PACKAGE_LIBXCRYPT),libxcrypt) \
 	$(TARGET_NLS_DEPENDENCIES)
 PETITBOOT_LICENSE = GPL-2.0
 PETITBOOT_LICENSE_FILES = COPYING
Signature · 6 lines
2.39.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Reza, All,

On 2024-04-16 09:48 -0500, Reza Arbab spake thusly:

Quoted 8 lines

Fix the following build failure raised since bump of glibc to version 2.39 in commit b5680f53d60acf8ff6010082f873438a39bd5d97:

checking for crypt in -lcrypt... no
configure: error: in `/home/arbab/src/buildroot/output/build/petitboot-1.15':
configure: error: shadow/crypt libs required

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 36 lines
---
 package/petitboot/Config.in    | 1 +
 package/petitboot/petitboot.mk | 1 +
 2 files changed, 2 insertions(+)
package/petitboot/Config.in +1 -0
index 533c7a9f2980..66836f31acd8 100644
@@ -14,6 +14,7 @@ config BR2_PACKAGE_PETITBOOT
 	# run-time dependencies
 	select BR2_PACKAGE_KEXEC if !BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS
 	select BR2_PACKAGE_KEXEC_LITE if BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS && !BR2_PACKAGE_KEXEC
+	select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
 	select BR2_PACKAGE_NVME if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le )
 	select BR2_PACKAGE_POWERPC_UTILS if ( BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le )
 	help
package/petitboot/petitboot.mk +1 -0
index cd7631fa5cae..2eb6461144cd 100644
@@ -14,6 +14,7 @@ PETITBOOT_DEPENDENCIES = \
 	host-bison \
 	host-flex \
 	lvm2 \
+	$(if $(BR2_PACKAGE_LIBXCRYPT),libxcrypt) \
 	$(TARGET_NLS_DEPENDENCIES)
 PETITBOOT_LICENSE = GPL-2.0
 PETITBOOT_LICENSE_FILES = COPYING
Signature · 6 lines
2.39.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
author
#2 lore raw
Quoted 1 line · Yann E. MORIN

Applied to master, thanks.

Thanks Yann!

Do you have any comments on the three remaining patches in this series?
https://patchwork.ozlabs.org/project/buildroot/list/?series=394036

Patch 3/5 is a required fix for petitboot to work properly, and the others would be nice to have.

Signature · 5 lines
Reza Arbab
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot