Skip to contentSkip to conversation

Secure Boot Advanced Targeting (SBAT) support on powerpc

PATCH In review Sudhakar Kuppusamy 2 participants 4 messages Apr 16, 2024 – May 10, 2024

lore
Share & tools
lore
#0 lore raw

cover Secure Boot Advanced Targeting (SBAT) support on powerpc

This patch set contains the v0 for Secure Boot Advanced Targeting (SBAT) support on powerpc secure boot.

In powerpc, PE format Binary are not supported and can't use shim (https://github.com/rhboot/shim/blob/main/SBAT.md).
However, ELF binary are supported. So, we created new ELF note for SBAT in ELF binary which store the SBAT data and SBAT verifier will be there in firmware to read SBAT data from ELF note and validate it.

this patch series consists of 2 parts:

1) Patch 1: create new ELF Note for SBAT

we add a new ELF note for SBAT which store the SBAT data.
The name field of shall be the string "Secure-Boot-Advanced-Targeting", zero-padded to 4 byte alignment. The type field shall be 0x41536967 (the ASCII values for the string "sbat").

2) Patch 2: adding sbat data into sbat ELF Note

it reads the SBAT data from sbat.csv and create the ELF Note for it then store the SBAT data on it while generate image with -s option

Sudhakar Kuppusamy and Daniel Axtens (2):
mkimage: create new ELF Note for SBAT
mkimage: adding sbat data into sbat ELF Note on powerpc

 include/grub/util/mkimage.h |  4 +--
 util/grub-mkimagexx.c       | 61 ++++++++++++++++++++++++++++++++++---
 util/mkimage.c              | 21 ++++++++++---
 3 files changed, 74 insertions(+), 12 deletions(-)
Signature · 7 lines
2.39.3


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#1 lore raw

PATCH 1/2 mkimage: create new ELF Note for SBAT

we add a new ELF note for SBAT which store the SBAT data.
The name field of shall be the string "Secure-Boot-Advanced-Targeting", zero-padded to 4 byte alignment. The type field shall be 0x41536967 (the ASCII values for the string "sbat").

---
 include/grub/util/mkimage.h |  4 +--
 util/grub-mkimagexx.c       | 61 ++++++++++++++++++++++++++++++++++---
 2 files changed, 58 insertions(+), 7 deletions(-)
include/grub/util/mkimage.h +2 -2
index 6f1da89b9..881e3031f 100644
@@ -51,12 +51,12 @@ grub_mkimage_load_image64 (const char *kernel_path,
 			   const struct grub_install_image_target_desc *image_target);
 void
 grub_mkimage_generate_elf32 (const struct grub_install_image_target_desc *image_target,
-			     int note, size_t appsig_size, char **core_img, size_t *core_size,
+			     int note, size_t appsig_size, char *sbat, char **core_img, size_t *core_size,
 			     Elf32_Addr target_addr,
 			     struct grub_mkimage_layout *layout);
 void
 grub_mkimage_generate_elf64 (const struct grub_install_image_target_desc *image_target,
-			     int note, size_t appsig_size, char **core_img, size_t *core_size,
+			     int note, size_t appsig_size, char *sbat, char **core_img, size_t *core_size,
 			     Elf64_Addr target_addr,
 			     struct grub_mkimage_layout *layout);
 
util/grub-mkimagexx.c +56 -5

117 lines not on this page · raw message

Signature · 7 lines
2.39.3


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#2 lore raw

PATCH 2/2 mkimage: adding sbat data into sbat ELF Note on powerpc

In reply to Sudhakar Kuppusamy

it reads the SBAT data from sbat.csv and create the ELF Note for it then store the SBAT data on it while generate image with -s option

---
 util/mkimage.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
util/mkimage.c +16 -5
index 0737935fd..e8d7dcc23 100644
@@ -958,8 +958,8 @@ grub_install_generate_image (const char *dir, const char *prefix,
       total_module_size += dtb_size + sizeof (struct grub_module_header);
     }
 
-  if (sbat_path != NULL && image_target->id != IMAGE_EFI)
-    grub_util_error (_(".sbat section can be embedded into EFI images only"));
+  if (sbat_path != NULL && (image_target->id != IMAGE_EFI && image_target->id != IMAGE_PPC))
+    grub_util_error (_(".sbat section can be embedded into EFI/sbat ELF Note cab be added into powerpc-ieee1275 images only"));
 
   if (disable_shim_lock)
     total_module_size += sizeof (struct grub_module_header);
@@ -1835,7 +1835,18 @@ grub_install_generate_image (const char *dir, const char *prefix,
     case IMAGE_I386_IEEE1275:
       {
 	grub_uint64_t target_addr;
-	if (image_target->id == IMAGE_LOONGSON_ELF)
+        char *sbat = NULL;
+
+	if (sbat_path != NULL)
+	  {
+	    sbat_size = grub_util_get_image_size (sbat_path);
+            sbat = xmalloc (sbat_size);
+	    grub_util_load_image (sbat_path, sbat);
+            layout.sbat_size = sbat_size;
+	  }
+
+
+        if (image_target->id == IMAGE_LOONGSON_ELF)
 	  {
 	    if (comp == GRUB_COMPRESSION_NONE)
 	      target_addr = (image_target->link_addr - decompress_size);
@@ -1846,10 +1857,10 @@ grub_install_generate_image (const char *dir, const char *prefix,
 	else
 	  target_addr = image_target->link_addr;
 	if (image_target->voidp_sizeof == 4)
-	  grub_mkimage_generate_elf32 (image_target, note, appsig_size, &core_img,
+          grub_mkimage_generate_elf32 (image_target, note, appsig_size, sbat, &core_img,
 				       &core_size, target_addr, &layout);
 	else
-	  grub_mkimage_generate_elf64 (image_target, note, appsig_size, &core_img,
+	  grub_mkimage_generate_elf64 (image_target, note, appsig_size, sbat, &core_img,
 				       &core_size, target_addr, &layout);
       }
       break;
Signature · 7 lines
2.39.3


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#3 lore raw
In reply to Sudhakar Kuppusamy
Quoted 1 line · Sudhakar Kuppusamy

This patch set contains the v0 for Secure Boot Advanced Targeting (SBAT) support on powerpc secure boot.

Hi Sudhakar,

This patch series cannot be applied to the upstream master because the prerequisites patch series for powerpc secure boot support have not been merged. You should probably consider adding sbat to the powerpc secure boot patches and repost here for review.

Thanks,
Michael

Quoted 19 lines

In powerpc, PE format Binary are not supported and can't use shim (https://github.com/rhboot/shim/blob/main/SBAT.md).
However, ELF binary are supported. So, we created new ELF note for SBAT in ELF binary which store the SBAT data and SBAT verifier will be there in firmware to read SBAT data from ELF note and validate it.

this patch series consists of 2 parts:

1) Patch 1: create new ELF Note for SBAT

we add a new ELF note for SBAT which store the SBAT data.
The name field of shall be the string "Secure-Boot-Advanced-Targeting", zero-padded to 4 byte alignment. The type field shall be 0x41536967 (the ASCII values for the string "sbat").

2) Patch 2: adding sbat data into sbat ELF Note

it reads the SBAT data from sbat.csv and create the ELF Note for it then store the SBAT data on it while generate image with -s option

Quoted 17 lines

Sudhakar Kuppusamy and Daniel Axtens (2):
mkimage: create new ELF Note for SBAT
mkimage: adding sbat data into sbat ELF Note on powerpc

 include/grub/util/mkimage.h |  4 +--
 util/grub-mkimagexx.c       | 61 ++++++++++++++++++++++++++++++++++---
 util/mkimage.c              | 21 ++++++++++---
 3 files changed, 74 insertions(+), 12 deletions(-)
Signature · 7 lines
2.39.3


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel