Skip to contentSkip to conversation

modules: Drop the .export_symbol section from the final modules

PATCH In review [email protected] 4 participants 6 messages Apr 17, 2024 – May 13, 2024 Module support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 modules: Drop the .export_symbol section from the final modules

From: Wang Yao <[email protected]>

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") forget drop the .export_symbol section from the final modules.

---
 scripts/module.lds.S | 1 +
 1 file changed, 1 insertion(+)
scripts/module.lds.S +1 -0
index bf5bcf2836d8..89ff01a22634 100644
@@ -13,6 +13,7 @@ SECTIONS {
 	/DISCARD/ : {
 		*(.discard)
 		*(.discard.*)
+		*(.export_symbol)
 	}
 
 	__ksymtab		0 : { *(SORT(___ksymtab+*)) }
Signature · 1 line
2.27.0
#1 lore raw

Hi, everyone:
Could someone review this patch?
Best regards,
Ainux Wang.

Quoted 26 lines · <[email protected]> 于2024年4月17日周三 13:35写道:

From: Wang Yao <[email protected]>

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") forget drop the .export_symbol section from the final modules.

---
 scripts/module.lds.S | 1 +
 1 file changed, 1 insertion(+)
scripts/module.lds.S +1 -1
index bf5bcf2836d8..89ff01a22634 100644
@@ -13,6 +13,7 @@ SECTIONS {
        /DISCARD/ : {
                *(.discard)
                *(.discard.*)
+               *(.export_symbol)
        }
 
        __ksymtab               0 : { *(SORT(___ksymtab+*)) }
--

2.27.0

#2 lore raw
In reply to [email protected]

Hi, everyone:

Could someone review this patch?

Best regards,
Ainux Wang.

Quoted 26 lines · <[email protected]> 于2024年4月17日周三 13:35写道:

From: Wang Yao <[email protected]>

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") forget drop the .export_symbol section from the final modules.

---
 scripts/module.lds.S | 1 +
 1 file changed, 1 insertion(+)
scripts/module.lds.S +1 -1
index bf5bcf2836d8..89ff01a22634 100644
@@ -13,6 +13,7 @@ SECTIONS {
        /DISCARD/ : {
                *(.discard)
                *(.discard.*)
+               *(.export_symbol)
        }
 
        __ksymtab               0 : { *(SORT(___ksymtab+*)) }
--

2.27.0

#3 lore raw

Hi, everyone:

Could someone help to review this patch?

Best regards,
Ainux Wang.

Quoted 36 lines · Ainux Wang <[email protected]> 于2024年5月7日周二 13:15写道:

Hi, everyone:

Could someone review this patch?

Best regards,
Ainux Wang.

Quoted 26 lines · <[email protected]> 于2024年4月17日周三 13:35写道:

From: Wang Yao <[email protected]>

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") forget drop the .export_symbol section from the final modules.

---
 scripts/module.lds.S | 1 +
 1 file changed, 1 insertion(+)
scripts/module.lds.S +1 -1
index bf5bcf2836d8..89ff01a22634 100644
@@ -13,6 +13,7 @@ SECTIONS {
        /DISCARD/ : {
                *(.discard)
                *(.discard.*)
+               *(.export_symbol)
        }
 
        __ksymtab               0 : { *(SORT(___ksymtab+*)) }
--

2.27.0

maintainer
#4 lore raw
In reply to [email protected]
Quoted 6 lines · On Wed, Apr 17, 2024 at 01:35:30PM +0800, [email protected] wrote:

From: Wang Yao <[email protected]>

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") forget drop the .export_symbol section from the final modules.

Masahiro, commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") was your change, wanna address / take it through your tree? It makes sense to me though.

Luis

Quoted 19 lines
---
 scripts/module.lds.S | 1 +
 1 file changed, 1 insertion(+)
scripts/module.lds.S +1 -0
index bf5bcf2836d8..89ff01a22634 100644
@@ -13,6 +13,7 @@ SECTIONS {
 	/DISCARD/ : {
 		*(.discard)
 		*(.discard.*)
+		*(.export_symbol)
 	}
 
 	__ksymtab		0 : { *(SORT(___ksymtab+*)) }
Signature · 1 line
2.27.0
#5 lore raw
Quoted 4 lines · Luis Chamberlain
Quoted 2 lines · On Wed, Apr 17, 2024 at 01:35:30PM +0800, [email protected] wrote:

From: Wang Yao <[email protected]>

Quoted 8 lines
Quoted 4 lines

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") forget drop the .export_symbol section from the final modules.

Masahiro, commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost") was your change, wanna address / take it through your tree? It makes sense to me though.

Yes, applied now.

Thanks for the reminder.

Quoted 22 lines

Luis

Quoted 19 lines
---
 scripts/module.lds.S | 1 +
 1 file changed, 1 insertion(+)
scripts/module.lds.S +1 -1
index bf5bcf2836d8..89ff01a22634 100644
@@ -13,6 +13,7 @@ SECTIONS {
      /DISCARD/ : {
              *(.discard)
              *(.discard.*)
+             *(.export_symbol)
      }
 
      __ksymtab               0 : { *(SORT(___ksymtab+*)) }
--

2.27.0

Signature · 2 lines
Best Regards
Masahiro Yamada