Skip to contentSkip to conversation

mm: fix the comment error of memcontrol.h

PATCH In review [email protected] 2 participants 3 messages Apr 17, 2024 – Apr 18, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: fix the comment error of memcontrol.h

From: Peifeng Li <[email protected]>

---
 include/linux/memcontrol.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/memcontrol.h +2 -2
index 394fd0a887ae..07d08be706bf 100644
@@ -1679,7 +1679,7 @@ static inline bool folio_matches_lruvec(struct folio *folio,
 	       lruvec_memcg(lruvec) == folio_memcg(folio);
 }
 
-/* Don't lock again iff page's lruvec locked */
+/* Don't lock again if page's lruvec locked */
 static inline struct lruvec *folio_lruvec_relock_irq(struct folio *folio,
 		struct lruvec *locked_lruvec)
 {
@@ -1693,7 +1693,7 @@ static inline struct lruvec *folio_lruvec_relock_irq(struct folio *folio,
 	return folio_lruvec_lock_irq(folio);
 }
 
-/* Don't lock again iff folio's lruvec locked */
+/* Don't lock again if folio's lruvec locked */
 static inline void folio_lruvec_relock_irqsave(struct folio *folio,
 		struct lruvec **lruvecp, unsigned long *flags)
 {
Signature · 1 line
2.34.1
#1 lore raw
Quoted 12 lines · On Wed 17-04-24 20:16:45, [email protected] wrote:

From: Peifeng Li <[email protected]>

---
 include/linux/memcontrol.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/memcontrol.h +0 -0
index 394fd0a887ae..07d08be706bf 100644

include/linux/memcontrol.h static inline bool folio_matches_lruvec(struct folio *folio, · line 1682

Quoted 5 lines
include/linux/memcontrol.h +1 -1
@@ -1679,7 +1679,7 @@ static inline bool folio_matches_lruvec(struct folio *folio,
 	       lruvec_memcg(lruvec) == folio_memcg(folio);
 }
 
-/* Don't lock again iff page's lruvec locked */
+/* Don't lock again if page's lruvec locked */

Not a typo. iff stands for if and only if

Signature · 2 lines
Michal Hocko
SUSE Labs
author
#2 lore raw
Quoted 16 lines · Michal Hocko
Quoted 15 lines · On Wed 17-04-24 20:16:45, [email protected] wrote:

From: Peifeng Li <[email protected]>

---
  include/linux/memcontrol.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/memcontrol.h +0 -0
index 394fd0a887ae..07d08be706bf 100644
@@ -1679,7 +1679,7 @@ static inline bool folio_matches_lruvec(struct folio *folio,
  	       lruvec_memcg(lruvec) == folio_memcg(folio);
  }
 
Quoted 3 lines

include/linux/memcontrol.h static inline bool folio_matches_lruvec(struct folio *folio, · line 1682

Quoted 2 lines
include/linux/memcontrol.h +1 -1
-/* Don't lock again iff page's lruvec locked */
+/* Don't lock again if page's lruvec locked */

Not a typo. iff stands for if and only if

Allright, thank for your response.