Skip to contentSkip to conversation

gpiolib: swnode: Remove wrong header inclusion

PATCH Applied Andy Shevchenko 2 participants 2 messages Apr 17, 2024 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: swnode: Remove wrong header inclusion

The flags in the software node properties are supposed to be the GPIO lookup flags, which are provided by gpio/machine.h, as the software nodes are the kernel internal thing and doesn't need to rely to any of ABIs.

Fixes e7f9ff5dc90c ("gpiolib: add support for software nodes")
---
 include/linux/gpio/property.h | 1 -
 1 file changed, 1 deletion(-)
include/linux/gpio/property.h +0 -1
index 6c75c8bd44a0..1a14e239221f 100644
@@ -2,7 +2,6 @@
 #ifndef __LINUX_GPIO_PROPERTY_H
 #define __LINUX_GPIO_PROPERTY_H
 
-#include <dt-bindings/gpio/gpio.h> /* for GPIO_* flags */
 #include <linux/property.h>
 
 #define PROPERTY_ENTRY_GPIO(_name_, _chip_node_, _idx_, _flags_) \
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
#1 lore raw
Quoted 25 lines · Andy Shevchenko

The flags in the software node properties are supposed to be the GPIO lookup flags, which are provided by gpio/machine.h, as the software nodes are the kernel internal thing and doesn't need to rely to any of ABIs.

Fixes e7f9ff5dc90c ("gpiolib: add support for software nodes")
---
 include/linux/gpio/property.h | 1 -
 1 file changed, 1 deletion(-)
include/linux/gpio/property.h +0 -2
index 6c75c8bd44a0..1a14e239221f 100644
@@ -2,7 +2,6 @@
 #ifndef __LINUX_GPIO_PROPERTY_H
 #define __LINUX_GPIO_PROPERTY_H
 
-#include <dt-bindings/gpio/gpio.h> /* for GPIO_* flags */
 #include <linux/property.h>
 
 #define PROPERTY_ENTRY_GPIO(_name_, _chip_node_, _idx_, _flags_) \
--
Quoted 2 lines

2.43.0.rc1.1336.g36b5255a03ac

Applied, thanks!

Bart