Skip to contentSkip to conversation

rust-target-config: fix featrue for vfpv4f16

PATCH In review Willy Tu 2 participants 2 messages Apr 17, 2024 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20240417181159.100583-1-wltu@...

Willy Tu

author
#1 lore raw

PATCH 1/1 rust-target-config: fix featrue for vfpv4f16

Based on [1] which fixed the target for vfpv3d16. Adding the support for vfpv4d16 with the same set of changes.

Tested with running tokio which hit coredump before the change. It worked fine after this change.

[1] https://lists.openembedded.org/g/openembedded-core/message/185702

---
 meta/classes-recipe/rust-target-config.bbclass | 3 +++
 1 file changed, 3 insertions(+)
meta/classes-recipe/rust-target-config.bbclass +3 -0
index 926b0630b1..330ad8a3f5 100644
@@ -21,6 +21,9 @@ def llvm_features_from_tune(d):
 
     if 'vfpv4' in feat:
         f.append("+vfp4")
+    elif 'vfpv4d16' in feat:
+        f.append("+vfp4")
+        f.append("-d32")
     elif 'vfpv3' in feat:
         f.append("+vfp3")
     elif 'vfpv3d16' in feat:
Signature · 1 line
2.44.0.769.g3c40516874-goog
#2 lore raw
Quoted 3 lines · Willy Tu via lists.openembedded.org

Based on [1] which fixed the target for vfpv3d16. Adding the support for vfpv4d16 with the same set of changes.

Lgtm

Quoted 40 lines

Tested with running tokio which hit coredump before the change. It worked fine after this change.

[1] https://lists.openembedded.org/g/openembedded-core/message/185702

---
 meta/classes-recipe/rust-target-config.bbclass | 3 +++
 1 file changed, 3 insertions(+)
meta/classes-recipe/rust-target-config.bbclass +3 -1
index 926b0630b1..330ad8a3f5 100644
@@ -21,6 +21,9 @@ def llvm_features_from_tune(d):
 
     if 'vfpv4' in feat:
         f.append("+vfp4")
+    elif 'vfpv4d16' in feat:
+        f.append("+vfp4")
+        f.append("-d32")
     elif 'vfpv3' in feat:
         f.append("+vfp3")
     elif 'vfpv3d16' in feat:
--

2.44.0.769.g3c40516874-goog

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#198473):
https://lists.openembedded.org/g/openembedded-core/message/198473
Mute This Topic: https://lists.openembedded.org/mt/105583303/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-