Skip to contentSkip to conversation

erofs-utils: dump: print filesystem blocksize

PATCH In review Sandeep Dhavale via Linux-erofs 2 participants 2 messages Apr 18, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 erofs-utils: dump: print filesystem blocksize

mkfs.erofs supports creating filesystem images with different blocksizes. Add filesystem blocksize in super block dump so its easier to inspect the filesystem.

The field is added after FS magic, so the output now looks like:

Filesystem magic number:                      0xE0F5E1E2
Filesystem blocksize:                         65536
Filesystem blocks:                            21
Filesystem inode metadata start block:        0
Filesystem shared xattr metadata start block: 0
Filesystem root nid:                          36
Filesystem lz4_max_distance:                  65535
Filesystem sb_extslots:                       0
Filesystem inode count:                       10
Filesystem created:                           Wed Apr 17 16:53:10 2024
Filesystem features:                          sb_csum mtime 0padding
Filesystem UUID:                              e66f6dd1-6882-48c3-9770-fee7c4841a93

---
Changes since v2:
- Use %u to print the FS blocksize as we don't expect it to be very large as suggested by Gao
Changes since v1:
- Moved the field after FS magic as suggested by Gao

 dump/main.c | 2 ++
 1 file changed, 2 insertions(+)
dump/main.c +2 -0
index a89fc6b..dd2c620 100644
@@ -633,6 +633,8 @@ static void erofsdump_show_superblock(void)
 
 	fprintf(stdout, "Filesystem magic number:                      0x%04X\n",
 			EROFS_SUPER_MAGIC_V1);
+	fprintf(stdout, "Filesystem blocksize:                         %u\n",
+			erofs_blksiz(&sbi));
 	fprintf(stdout, "Filesystem blocks:                            %llu\n",
 			sbi.total_blocks | 0ULL);
 	fprintf(stdout, "Filesystem inode metadata start block:        %u\n",
Signature · 1 line
2.44.0.683.g7961c838ac-goog
Reviewed-by on v3 1/1
#1 lore raw
Quoted 19 lines · Sandeep Dhavale

mkfs.erofs supports creating filesystem images with different blocksizes. Add filesystem blocksize in super block dump so its easier to inspect the filesystem.

The field is added after FS magic, so the output now looks like:

Filesystem magic number:                      0xE0F5E1E2
Filesystem blocksize:                         65536
Filesystem blocks:                            21
Filesystem inode metadata start block:        0
Filesystem shared xattr metadata start block: 0
Filesystem root nid:                          36
Filesystem lz4_max_distance:                  65535
Filesystem sb_extslots:                       0
Filesystem inode count:                       10
Filesystem created:                           Wed Apr 17 16:53:10 2024
Filesystem features:                          sb_csum mtime 0padding
Filesystem UUID:                              e66f6dd1-6882-48c3-9770-fee7c4841a93
Quoted 1 line

Thanks,
Gao Xiang