kunit: fix minor error path mistakes
v2 cover kunit: fix minor error path mistakes
Hi,
These two patches fix some minor error path mistakes in the device module.
Changes:
--------
v1->v2:
* Add fixes tag.
* Add an imperative statement in the first commit descripton.
Wander Lairson Costa (2):
kunit: unregister the device on error
kunit: avoid memory leak on device register error
lib/kunit/device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.44.0
PATCH v2 1/2 kunit: unregister the device on error
kunit_init_device() should unregister the device on bus register error, but mistakenly it tries to unregister the bus.
Unregister the device instead of the bus.
--- lib/kunit/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/kunit/device.c +1 -1
@@ -51,7 +51,7 @@ int kunit_bus_init(void) error =bus_register (&kunit_bus_type);if (error) -bus_unregister (&kunit_bus_type); +root_device_unregister (kunit_bus_device);return error; }
Signature · 1 line
2.44.0
PATCH v2 2/2 kunit: avoid memory leak on device register error
In reply to Wander Lairson CostaIf the device register fails, free the allocated memory before returning.
--- lib/kunit/device.c | 1 + 1 file changed, 1 insertion(+)
lib/kunit/device.c +1 -0
@@ -131,6 +131,7 @@ static struct kunit_device *kunit_device_register_internal(struct kunit *test, err =device_register (&kunit_dev->dev);if (err) {put_device (&kunit_dev->dev); +kfree (kunit_dev);return ERR_PTR (err); }
Signature · 1 line
2.44.0
Quoted 7 lines · Wander Lairson Costa
Hi,
These two patches fix some minor error path mistakes in the device module.
[ ... ]
Thanks!
Maxime