dpaa2-switch: flower: validate control flags
Subsystems (3)
PATCH 1/1 dpaa2-switch: flower: validate control flags
This driver currently doesn't support any control flags.
Use flow_rule_match_has_control_flags() to check for control flags, such as can be set through tc flower ... ip_flags frag.
In case any control flags are masked, flow_rule_match_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP.
Only compile-tested.
--- drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c +6 -0
@@ -33,6 +33,9 @@ static int dpaa2_switch_flower_parse_key(struct flow_cls_offload *cls, acl_h = &acl_key->match; acl_m = &acl_key->mask; +if (flow_rule_match_has_control_flags (rule, extack)) +return -EOPNOTSUPP ; +if (flow_rule_match_key (rule,FLOW_DISSECTOR_KEY_BASIC )) {struct flow_match_basic match;
@@ -548,6 +551,9 @@ static int dpaa2_switch_flower_parse_mirror_key(struct flow_cls_offload *cls,return -EOPNOTSUPP ; } +if (flow_rule_match_has_control_flags (rule, extack)) +return -EOPNOTSUPP ; +if (flow_rule_match_key (rule,FLOW_DISSECTOR_KEY_VLAN )) {struct flow_match_vlan match;
Signature · 1 line
2.43.0
Quoted 11 lines · Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags.
Use
flow_rule_match_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_match_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>
Quoted 11 lines · Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags.
Use
flow_rule_match_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_match_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 18 Apr 2024 16:18:01 +0000 you wrote:
This driver currently doesn't support any control flags.
Use
flow_rule_match_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_match_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.[...]
Here is the summary with links:
- [net-next] dpaa2-switch: flower: validate control flags
https://git.kernel.org/netdev/net-next/c/af7dfa94c2f9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html