Skip to contentSkip to conversation

Allwinner H616 NMI Controller

PATCH Applied Chris Morgan 4 participants 7 messages Apr 18, 2024 – Apr 26, 2024

Subsystems (3)
Device tree bindings Arm/Allwinner sunXi SoC support irqchip drivers
lore
Share & tools
lore

Chris Morgan

author
#0 lore raw

v2 cover Allwinner H616 NMI Controller

From: Chris Morgan <[email protected]>

Add support for the Allwinner H616 NMI controller, which appears to be common IP with previous generations of the NMI. The NMI is required to support interrupts from the PMIC among other functions.

Changes since V1:
- Update dt binding documentation to collapse multiple compatible strings into an enum list.
- Added note in commit message about NMI pad exposure for the H616.

Chris Morgan (2):
dt-bindings: irq: sun7i-nmi: Add binding for the H616 NMI controller
arm64: dts: allwinner: h616: Add NMI device node

 .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 8 ++++----
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi           | 9 +++++++++
 2 files changed, 13 insertions(+), 4 deletions(-)
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v2 1/2 dt-bindings: irq: sun7i-nmi: Add binding for the H616 NMI controller

From: Chris Morgan <[email protected]>

Add binding for the H616 NMI controller.

Signed-off-by Chris Morgan <[email protected]>
---
 .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml  | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml +4 -4
index 83603180d8d9..f49b43f45f3d 100644
@@ -25,12 +25,12 @@ properties:
       - const: allwinner,sun6i-a31-sc-nmi
         deprecated: true
       - const: allwinner,sun7i-a20-sc-nmi
-      - items:
-          - const: allwinner,sun8i-v3s-nmi
-          - const: allwinner,sun9i-a80-nmi
       - const: allwinner,sun9i-a80-nmi
       - items:
-          - const: allwinner,sun50i-a100-nmi
+          - enum:
+              - allwinner,sun8i-v3s-nmi
+              - allwinner,sun50i-a100-nmi
+              - allwinner,sun50i-h616-nmi
           - const: allwinner,sun9i-a80-nmi
 
   reg:
Signature · 1 line
2.34.1
author
#4 lore raw

PATCH v2 2/2 arm64: dts: allwinner: h616: Add NMI device node

In reply to Chris Morgan

From: Chris Morgan <[email protected]>

Add device node for the H616 Non Maskable Interrupt (NMI) controller. This controller is present on all H616 boards and derivatives such as the T507 and H700. Note that on the H616 no NMI pad is exposed.

Reviewed-by Andre Przywara <[email protected]>
Signed-off-by Chris Morgan <[email protected]>
---
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +9 -0
index b2e85e52d1a1..1e066f3057be 100644
@@ -775,6 +775,15 @@ r_ccu: clock@7010000 {
 			#reset-cells = <1>;
 		};
 
+		nmi_intc: interrupt-controller@7010320 {
+			compatible = "allwinner,sun50i-h616-nmi",
+				     "allwinner,sun9i-a80-nmi";
+			reg = <0x07010320 0xc>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
 		r_pio: pinctrl@7022000 {
 			compatible = "allwinner,sun50i-h616-r-pinctrl";
 			reg = <0x07022000 0x400>;
Signature · 1 line
2.34.1
maintainer Acked-by on v2 2/2
#5 lore raw

Re: [PATCH V2 2/2] arm64: dts: allwinner: h616: Add NMI device node

Dne četrtek, 18. april 2024 ob 20:16:15 GMT +2 je Chris Morgan napisal(a):

Quoted 8 lines

From: Chris Morgan <[email protected]>

Add device node for the H616 Non Maskable Interrupt (NMI) controller. This controller is present on all H616 boards and derivatives such as the T507 and H700. Note that on the H616 no NMI pad is exposed.

Reviewed-by Andre Przywara <[email protected]>
Signed-off-by Chris Morgan <[email protected]>
Acked-by Jernej Skrabec <[email protected]>

Best regards,
Jernej

Quoted 25 lines
---
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +9 -0
index b2e85e52d1a1..1e066f3057be 100644
@@ -775,6 +775,15 @@ r_ccu: clock@7010000 {
 			#reset-cells = <1>;
 		};
 
+		nmi_intc: interrupt-controller@7010320 {
+			compatible = "allwinner,sun50i-h616-nmi",
+				     "allwinner,sun9i-a80-nmi";
+			reg = <0x07010320 0xc>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
 		r_pio: pinctrl@7022000 {
 			compatible = "allwinner,sun50i-h616-r-pinctrl";
 			reg = <0x07022000 0x400>;
maintainer Applied
#6 lore raw

Re: [PATCH V2 2/2] arm64: dts: allwinner: h616: Add NMI device node

In reply to Chris Morgan

Dne četrtek, 18. april 2024 ob 20:16:15 GMT +2 je Chris Morgan napisal(a):

Quoted 8 lines

From: Chris Morgan <[email protected]>

Add device node for the H616 Non Maskable Interrupt (NMI) controller. This controller is present on all H616 boards and derivatives such as the T507 and H700. Note that on the H616 no NMI pad is exposed.

Reviewed-by Andre Przywara <[email protected]>
Signed-off-by Chris Morgan <[email protected]>

Applied, thanks!

Best regards,
Jernej

Quoted 25 lines
---
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +9 -0
index b2e85e52d1a1..1e066f3057be 100644
@@ -775,6 +775,15 @@ r_ccu: clock@7010000 {
 			#reset-cells = <1>;
 		};
 
+		nmi_intc: interrupt-controller@7010320 {
+			compatible = "allwinner,sun50i-h616-nmi",
+				     "allwinner,sun9i-a80-nmi";
+			reg = <0x07010320 0xc>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
 		r_pio: pinctrl@7022000 {
 			compatible = "allwinner,sun50i-h616-r-pinctrl";
 			reg = <0x07022000 0x400>;