Skip to contentSkip to conversation

igb: flower: validate control flags

PATCH In review Asbjørn Sloth Tønnesen 3 participants 3 messages Apr 16, 2024 – Apr 26, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igb: flower: validate control flags

This driver currently doesn't support any control flags.

Use flow_rule_match_has_control_flags() to check for control flags, such as can be set through tc flower ... ip_flags frag.

In case any control flags are masked, flow_rule_match_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP.

Only compile-tested.

---
 drivers/net/ethernet/intel/igb/igb_main.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/igb/igb_main.c +3 -0
index 74a998fcaa6f..e4c65d3819d7 100644
@@ -2597,6 +2597,9 @@ static int igb_parse_cls_flower(struct igb_adapter *adapter,
 		return -EOPNOTSUPP;
 	}
 
+	if (flow_rule_match_has_control_flags(rule, extack))
+		return -EOPNOTSUPP;
+
 	if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
 		struct flow_match_eth_addrs match;
 
Signature · 1 line
2.43.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Asbjørn Sloth Tønnesen

This driver currently doesn't support any control flags.

Use flow_rule_match_has_control_flags() to check for control flags, such as can be set through tc flower ... ip_flags frag.

In case any control flags are masked, flow_rule_match_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP.

Only compile-tested.

Tested-by on v1 1/1
#2 lore raw
In reply to Asbjørn Sloth Tønnesen
Quoted 14 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Asbjørn Sloth Tønnesen
Sent: Tuesday, April 16, 2024 8:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Eric Dumazet <[email protected]>; Nguyen, Anthony L <[email protected]>; Asbjørn Sloth Tønnesen <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next] igb: flower: validate control flags

This driver currently doesn't support any control flags.

Use flow_rule_match_has_control_flags() to check for control flags, such as can be set through tc flower ... ip_flags frag.

In case any control flags are masked, flow_rule_match_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP.

Quoted 7 lines

Only compile-tested.

---
 drivers/net/ethernet/intel/igb/igb_main.c | 3 +++
 1 file changed, 3 insertions(+)