ALSA: seq: ump: Fix conversion from MIDI2 to MIDI1 UMP messages
PATCH 1/1 ALSA: seq: ump: Fix conversion from MIDI2 to MIDI1 UMP messages
The conversion from MIDI2 to MIDI1 UMP messages had a leftover artifact (superfluous bit shift), and this resulted in the bogus type check, leading to empty outputs. Let's fix it.
Fixes e9e02819a98a ("ALSA: seq: Automatic conversion of UMP events")
Cc <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
--- sound/core/seq/seq_ump_convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/seq/seq_ump_convert.c +1 -1
@@ -428,7 +428,7 @@ static int cvt_ump_midi2_to_midi1(struct snd_seq_client *dest, midi1->note.group = midi2->note.group; midi1->note.status = midi2->note.status; midi1->note.channel = midi2->note.channel; -switch (midi2->note.status <<4 ) { +switch (midi2->note.status) {case UMP_MSG_STATUS_NOTE_ON :case UMP_MSG_STATUS_NOTE_OFF : midi1->note.note = midi2->note.note;
Signature · 1 line
2.43.0