ice: flower: validate control flags
Subsystems (3)
PATCH 1/1 ice: flower: validate control flags
This driver currently doesn't support any control flags.
Use flow_rule_has_control_flags() to check for control flags, such as can be set through tc flower ... ip_flags frag.
In case any control flags are masked, flow_rule_has_control_flags() sets a NL extended error message, and we return -EOPNOTSUPP.
Only compile-tested.
--- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/ice/ice_tc_lib.c +4 -0
@@ -1673,6 +1673,10 @@ ice_parse_cls_flower(struct net_device *filter_dev, struct ice_vsi *vsi,flow_rule_match_control (rule, &match); addr_type = match.key->addr_type; + +if (flow_rule_has_control_flags (match.mask->flags, + fltr->extack)) +return -EOPNOTSUPP ; }if (addr_type ==FLOW_DISSECTOR_KEY_IPV4_ADDRS ) {
Signature · 1 line
2.43.0
Quoted 20 lines · Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags.
Use
flow_rule_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>--- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/ethernet/intel/ice/ice_tc_lib.c +0
-0
drivers/net/ethernet/intel/ice/ice_tc_lib.c ice_parse_cls_flower(struct net_device *filter_dev, struct ice_vsi *vsi, · line 1681
Quoted 9 lines
drivers/net/ethernet/intel/ice/ice_tc_lib.c +4
-0@@ -1673,6 +1673,10 @@ ice_parse_cls_flower(struct net_device *filter_dev, struct ice_vsi *vsi,flow_rule_match_control (rule, &match); addr_type = match.key->addr_type; + +if (flow_rule_has_control_flags (match.mask->flags, + fltr->extack)) +return -EOPNOTSUPP ; }
Thanks,
Quoted 4 lines
drivers/net/ethernet/intel/ice/ice_tc_lib.c +0
-0if (addr_type ==FLOW_DISSECTOR_KEY_IPV4_ADDRS ) {Signature · 1 line
2.43.0
Quoted 11 lines · Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags.
Use
flow_rule_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>
Quoted 20 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Asbjørn Sloth Tønnesen
Sent: Tuesday, April 16, 2024 8:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Eric Dumazet <[email protected]>; Nguyen, Anthony L <[email protected]>; Asbjørn Sloth Tønnesen <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flagsThis driver currently doesn't support any control flags.
Use
flow_rule_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.
Quoted 7 lines
Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>--- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++++ 1 file changed, 4 insertions(+)
Hi,
I have tested this patch in upstream kernel - 6.9.0-rc5+ and observing no effect while adding tc flow rule with control flags. 'Not supported' error is not shown while adding the below tc rule.
[root@cbl-mariner ~]# tc qdisc add dev ens5f0np0 ingress
[root@cbl-mariner ~]#
[root@cbl-mariner ~]# tc filter add dev ens5f0np0 ingress protocol ip flower ip_flags frag/firstfrag action drop [root@cbl-mariner ~]#
[root@cbl-mariner ~]# ethtool -i ens5f0np0
driver: ice
version: 6.9.0-rc5+
firmware-version: 4.40 0x8001c967 1.3534.0
expansion-rom-version:
bus-info: 0000:b1:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes
Same behavior is observed with iavf driver on VF as well.
Regards,
Sujai B
Hi Sujai,
Quoted 28 lines · Sujai
Quoted 20 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Asbjørn Sloth Tønnesen
Sent: Tuesday, April 16, 2024 8:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Eric Dumazet <[email protected]>; Nguyen, Anthony L <[email protected]>; Asbjørn Sloth Tønnesen <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flagsThis driver currently doesn't support any control flags.
Use
flow_rule_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.Quoted 7 lines
Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>--- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++++ 1 file changed, 4 insertions(+)
Quoted 8 lines
Hi,
I have tested this patch in upstream kernel - 6.9.0-rc5+ and observing no effect while adding tc flow rule with control flags. 'Not supported' error is not shown while adding the below tc rule.
[root@cbl-mariner ~]# tc qdisc add dev ens5f0np0 ingress
[root@cbl-mariner ~]#
[root@cbl-mariner ~]# tc filter add dev ens5f0np0 ingress protocol ip flowerip_flagsfrag/firstfrag action drop
Thank you for testing!
I think the issue you are observing, is because you are missing "skip_sw":
tc filter add dev ens5f0np0 ingress protocol ip flower skip_sw \
ip_flags frag/firstfrag action drop
Without skip_sw, then the hardware offload is opportunistic, and therefore the error in hardware offloading doesn't bubble through to user space.
Without skip_sw, you should still be able to observe a change in tc filter show dev ens5f0np0 ingress. Without the patch you should see "in_hw", and with it you should see "not_in_hw".
With skip_sw, then the error in hardware offloading causes the tc command to fail, with the -EOPNOTSUPP error and associated extended Netlink error message.
Also see Ido's testing for mlxsw in this other thread:
https://lore.kernel.org/netdev/ZiABPNMbOOYGiHCq@shredder/#t
Signature · 4 lines
Best regards Asbjørn Sloth Tønnesen Network Engineer Fiberby - AS42541
Hi Asbjørn,
Thanks for providing more information about this patch. We were able to test this patch with 'skip_sw' parameter on ice PF interface. It is working as expected. Error is displayed when tc rule added with control flags.
[root@cbl-mariner ~]# tc filter add dev ens5f0np0 ingress protocol ip flower skip_sw ip_flags frag/firstfrag action drop
Error: ice: Unsupported match on control.flags 0x3.
We have an error talking to the kernel
Without this patch, this rule is getting installed in the HW.
Regards,
Sujai B
Quoted 80 lines
-----Original Message-----
From: Asbjørn Sloth Tønnesen <[email protected]>
Sent: Friday, May 3, 2024 11:38 PM
To: Buvaneswaran, Sujai <[email protected]>
Cc: [email protected]; [email protected]; Eric Dumazet <[email protected]>; Nguyen, Anthony L <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller <[email protected]>; [email protected]
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flagsHi Sujai,
Quoted 29 lines · Sujai
Quoted 21 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Asbjørn Sloth Tønnesen
Sent: Tuesday, April 16, 2024 8:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Eric Dumazet <[email protected]>; Nguyen, Anthony L <[email protected]>; Asbjørn Sloth Tønnesen <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flagsThis driver currently doesn't support any control flags.
Use
flow_rule_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.Quoted 7 lines
Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>--- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++++ 1 file changed, 4 insertions(+)Quoted 3 lines
Hi,
I have tested this patch in upstream kernel - 6.9.0-rc5+ and observing no
effect while adding tc flow rule with control flags.
Quoted 6 lines
'Not supported' error is not shown while adding the below tc rule.
[root@cbl-mariner ~]# tc qdisc add dev ens5f0np0 ingress [root@cbl-mariner ~]# [root@cbl-mariner ~]# tc filter add dev ens5f0np0 ingress protocol ip flower
ip_flagsfrag/firstfrag action dropThank you for testing!
I think the issue you are observing, is because you are missing "
skip_sw":
tc filter add dev ens5f0np0 ingress protocol ip flowerskip_sw\
ip_flagsfrag/firstfrag action dropWithout
skip_sw, then the hardware offload is opportunistic, and therefore the error in hardware offloading doesn't bubble through to user space.Without
skip_sw, you should still be able to observe a change intc filter show dev ens5f0np0 ingress. Without the patch you should see "in_hw", and with it you should see "not_in_hw".With
skip_sw, then the error in hardware offloading causes the tc command to fail, with the-EOPNOTSUPPerror and associated extended Netlink error message.Also see Ido's testing for mlxsw in this other thread:
https://lore.kernel.org/netdev/ZiABPNMbOOYGiHCq@shredder/#t--
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541
Quoted 20 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Asbjørn Sloth Tønnesen
Sent: Tuesday, April 16, 2024 8:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Eric Dumazet <[email protected]>; Nguyen, Anthony L <[email protected]>; Asbjørn Sloth Tønnesen <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flagsThis driver currently doesn't support any control flags.
Use
flow_rule_has_control_flags()to check for control flags, such as can be set throughtc flower ... ip_flags frag.In case any control flags are masked,
flow_rule_has_control_flags()sets a NL extended error message, and we return-EOPNOTSUPP.
Quoted 7 lines
Only compile-tested.
Signed-off-by Asbjørn Sloth Tønnesen <[email protected]>--- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++++ 1 file changed, 4 insertions(+)