Skip to contentSkip to conversation

cxl: Fix use of phys_to_target_node() for x86

PATCH Superseded Robert Richter 3 participants 3 messages Apr 19, 2024 – Apr 23, 2024 CXL

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cxl: Fix use of phys_to_target_node() for x86

The CXL driver uses both functions phys_to_target_node() and memory_add_physaddr_to_nid(). The x86 architecture relies on the NUMA_KEEP_MEMINFO kernel option enabled for both functions to work correct. Update Kconfig to make sure the option is always enabled for the driver.

---
 drivers/cxl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/cxl/Kconfig +1 -0
index 67998dbd1d46..6140b3529a29 100644
@@ -6,6 +6,7 @@ menuconfig CXL_BUS
 	select FW_UPLOAD
 	select PCI_DOE
 	select FIRMWARE_TABLE
+	select NUMA_KEEP_MEMINFO if (NUMA && X86)
 	help
 	  CXL is a bus that is electrically compatible with PCI Express, but
 	  layers three protocols on that signalling (CXL.io, CXL.cache, and
Signature · 1 line
2.39.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 8 lines · Robert Richter

The CXL driver uses both functions phys_to_target_node() and memory_add_physaddr_to_nid(). The x86 architecture relies on the NUMA_KEEP_MEMINFO kernel option enabled for both functions to work correct. Update Kconfig to make sure the option is always enabled for the driver.

Reviewed-by on v2 1/1
#2 lore raw
In reply to Robert Richter
Quoted 7 lines · Robert Richter

The CXL driver uses both functions phys_to_target_node() and memory_add_physaddr_to_nid(). The x86 architecture relies on the NUMA_KEEP_MEMINFO kernel option enabled for both functions to work correct. Update Kconfig to make sure the option is always enabled for the driver.

It would be nice if all "Suggested-by:" tags also came with a "Link:" tag to recall the rationale, because my brain had cache flushed what I said earlier.

Found it here:

...with that added: