neighbour: fix neigh_master_filtered()
Subsystems (2)
PATCH 1/1 neighbour: fix neigh_master_filtered()
If we no longer hold RTNL, we must use netdev_master_upper_dev_get_rcu() instead of netdev_master_upper_dev_get().
Fixes ba0f78069423 ("neighbour: no longer hold RTNL in neigh_dump_info()")
Signed-off-by Eric Dumazet <[email protected]>
--- net/core/neighbour.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/neighbour.c +1 -1
@@ -2682,7 +2682,7 @@ static bool neigh_master_filtered(struct net_device *dev, int master_idx)if (!master_idx)return false; - master = dev ?netdev_master_upper_dev_get (dev) :NULL ; + master = dev ?netdev_master_upper_dev_get_rcu (dev) :NULL ;/* 0 is already used to denote NDA_MASTER wasn't passed, therefore need another * invalid value for ifindex to denote "no master".
Signature · 1 line
2.44.0.769.g3c40516874-goog
Quoted 5 lines · Sun, Apr 21, 2024 at 08:57:53PM CEST, [email protected] wrote:
If we no longer hold RTNL, we must use
netdev_master_upper_dev_get_rcu()instead ofnetdev_master_upper_dev_get().Fixes ba0f78069423 ("neighbour: no longer hold RTNL in neigh_dump_info()")Signed-off-by Eric Dumazet <[email protected]>
Reviewed-by Jiri Pirko <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Sun, 21 Apr 2024 18:57:53 +0000 you wrote:
If we no longer hold RTNL, we must use
netdev_master_upper_dev_get_rcu()instead ofnetdev_master_upper_dev_get().Fixes ba0f78069423 ("neighbour: no longer hold RTNL in neigh_dump_info()")Signed-off-by Eric Dumazet <[email protected]>--- net/core/neighbour.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] neighbour: fix neigh_master_filtered()
https://git.kernel.org/netdev/net-next/c/1c04b46cbddd
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html