Skip to contentSkip to conversation

drm: fixed: Don't use "proxy" headers

PATCH Applied Andy Shevchenko 2 participants 5 messages Apr 22, 2024 – Aug 13, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: fixed: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use) principle.

---
 include/drm/drm_fixed.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/drm/drm_fixed.h +2 -1
index 81572d32db0c..387fb81d5b81 100644
@@ -25,8 +25,9 @@
 #ifndef DRM_FIXED_H
 #define DRM_FIXED_H
 
-#include <linux/kernel.h>
 #include <linux/math64.h>
+#include <linux/types.h>
+#include <linux/wordpart.h>
 
 typedef union dfixed {
 	u32 full;
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Assuming it builds, and nothing depends on other stuff from kernel.h via drm_fixed.h,

Quoted 19 lines
---
 include/drm/drm_fixed.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/drm/drm_fixed.h +2 -1
index 81572d32db0c..387fb81d5b81 100644
@@ -25,8 +25,9 @@
 #ifndef DRM_FIXED_H
 #define DRM_FIXED_H
 
-#include <linux/kernel.h>
 #include <linux/math64.h>
+#include <linux/types.h>
+#include <linux/wordpart.h>
 
 typedef union dfixed {
 	u32 full;
Signature · 1 line
Jani Nikula, Intel
#2 lore raw
Quoted 8 lines · Jani Nikula
Quoted 4 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Assuming it builds, and nothing depends on other stuff from kernel.h via drm_fixed.h,

For the record, I have built-tested this via make allyesconfig on x86_64.

Quoted 1 line

Thank you!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Jani Nikula
Quoted 4 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Quoted 8 lines
Quoted 2 lines

Assuming it builds, and nothing depends on other stuff from kernel.h via drm_fixed.h,

For the record, I have built-tested this via make allyesconfig on x86_64.

Quoted 1 line

Thank you!

Who is going to apply this, please?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Applied
#4 lore raw
Quoted 11 lines · Andy Shevchenko
Quoted 10 lines · Andy Shevchenko
Quoted 8 lines · Jani Nikula
Quoted 4 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Assuming it builds, and nothing depends on other stuff from kernel.h via drm_fixed.h,

Quoted 7 lines
Quoted 5 lines

For the record, I have built-tested this via make allyesconfig on x86_64.

Quoted 1 line

Thank you!

Who is going to apply this, please?

Pushed to drm-misc-next, thanks for the patch.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel