Skip to contentSkip to conversation

arm64: dts: rockchip: move uart2 pinmux to dtsi on rk3588-tiger

PATCH Applied Heiko Stuebner 1 participant 2 messages Apr 22, 2024 – Apr 23, 2024

Subsystems (2)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH v2 1/1 arm64: dts: rockchip: move uart2 pinmux to dtsi on rk3588-tiger

From: Heiko Stuebner <[email protected]>

The association of uart2 to the q7-uart pins is part of the module itself and not the baseboard used. Therefore move the pinctrl over to the tiger dtsi.

---
changes in v2:
- add comment specifying where the signals go to on the Q7 connector
- add Quentin's review

 arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts | 1 -
 arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi       | 5 +++++
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588-tiger-haikou.dts +0 -1
index d672198c6b64..9bdd14799eff 100644
@@ -231,7 +231,6 @@ &u2phy3_host {
 };
 
 &uart2 {
-	pinctrl-0 = <&uart2m2_xfer>;
 	status = "okay";
 };
 
arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +5 -0
index 72fe696b0034..4984e36a8c2d 100644
@@ -688,6 +688,11 @@ &tsadc {
 	status = "okay";
 };
 
+/* Routed to UART0 on the Q7 connector */
+&uart2 {
+	pinctrl-0 = <&uart2m2_xfer>;
+};
+
 /* Mule-ATtiny UPDI */
 &uart4 {
 	pinctrl-0 = <&uart4m2_xfer>;
Signature · 1 line
2.39.2
author maintainer Applied
#1 lore raw
Quoted 8 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

The association of uart2 to the q7-uart pins is part of the module itself and not the baseboard used. Therefore move the pinctrl over to the tiger dtsi.

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: move uart2 pinmux to dtsi on rk3588-tiger

      commit: 5adbad5c464a708a87cf5ade1bfe2ca947bb2f82

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>