Skip to contentSkip to conversation

net: sfp: add quirk for ATS SFP-GE-T 1000Base-TX module

PATCH Applied Marek Behún 2 participants 2 messages Apr 23, 2024 – Apr 26, 2024

Subsystems (4)
Networking Network drivers Ethernet PHY SFF/SFP/SFP+ module support
lore
Share & tools
lore

Marek Behún

author
#0 lore raw

PATCH 1/1 net: sfp: add quirk for ATS SFP-GE-T 1000Base-TX module

From: Daniel Golle <[email protected]>

Add quirk for ATS SFP-GE-T 1000Base-TX module.

This copper module comes with broken TX_FAULT indicator which must be ignored for it to work.

Co-authored-by Josef Schlehofer <[email protected]>
Signed-off-by Daniel Golle <[email protected]>
[ rebased on top of net-next ]
Signed-off-by Marek Behún <[email protected]>
---
 drivers/net/phy/sfp.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/phy/sfp.c +3 -0
index 7d063cd3c6af..3f9cbd797fd6 100644
@@ -509,6 +509,9 @@ static const struct sfp_quirk sfp_quirks[] = {
 	SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt),
 	SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt),
 
+	// OEM SFP-GE-T is a 1000Base-T module with broken TX_FAULT indicator
+	SFP_QUIRK_F("OEM", "SFP-GE-T", sfp_fixup_ignore_tx_fault),
+
 	SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
 	SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
 	SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
Signature · 1 line
2.43.2
CI Applied
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 23 Apr 2024 11:00:25 +0200 you wrote:

From: Daniel Golle <[email protected]>

Add quirk for ATS SFP-GE-T 1000Base-TX module.

This copper module comes with broken TX_FAULT indicator which must be ignored for it to work.

[...]

Here is the summary with links:
- [net-next] net: sfp: add quirk for ATS SFP-GE-T 1000Base-TX module

    https://git.kernel.org/netdev/net-next/c/0805d67bc0ef

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html