s390x: cmm: test no-translate bit after reset
v3 cover s390x: cmm: test no-translate bit after reset
v3:
---
* fix specification exception when ESSA no-dat is not available
v2:
---
* fix reverse christmas tree
Nico Boehr (1):
s390x: cmm: test no-translate bit after reset
s390x/cmm.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
Signature · 1 line
2.41.0
PATCH v3 1/1 s390x: cmm: test no-translate bit after reset
KVM did not properly reset the no-translate bit after reset, see
https://lore.kernel.org/kvm/[email protected]/
Add a test which performs a load normal reset (includes a subsystem reset) and verify that this clears the no-translate bit.
Signed-off-by Nico Boehr <[email protected]>
--- s390x/cmm.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
s390x/cmm.c +34 -0
@@ -9,13 +9,17 @@*/ #include <libcflat.h> +#include <bitops.h> #include <asm/asm-offsets.h> #include <asm/interrupt.h> #include <asm/page.h> #include <asm/cmm.h> +#include <asm/facility.h> static uint8_t pagebuf[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); +extern int diag308_load_reset (u64 ); +static void test_params (void ) {report_prefix_push ("invalid ORC 8" );
@@ -35,6 +39,35 @@ static void test_priv(void)report_prefix_pop (); } +static void test_reset_no_translate (void ) +{ +const uint64_t mask_no_translate =BIT (63 -58 ); +unsigned long state; + +if (!test_facility (147 )) { +report_prefix_push ("no-translate unavailable" ); +expect_pgm_int (); +essa (ESSA_SET_STABLE_NODAT , (unsigned long )pagebuf); +check_pgm_int_code (PGM_INT_CODE_SPECIFICATION ); +report_prefix_pop (); +return ; + } + +report_prefix_push ("reset no-translate" ); +essa (ESSA_SET_STABLE_NODAT , (unsigned long )pagebuf); + + state =essa (ESSA_GET_STATE , (unsigned long )pagebuf); +report (state & mask_no_translate,"no-translate bit set before reset" ); + +/* Load normal reset - includes subsystem reset */ +diag308_load_reset (1 ); + + state =essa (ESSA_GET_STATE , (unsigned long )pagebuf); +report (!(state & mask_no_translate),"no-translate bit unset after reset" ); + +report_prefix_pop (); +} +int main (void ) {bool has_essa =check_essa_available ();
@@ -47,6 +80,7 @@ int main(void)test_priv ();test_params (); +test_reset_no_translate (); done:report_prefix_pop ();return report_summary ();
Signature · 1 line
2.41.0
Quoted 7 lines · On Tue, 23 Apr 2024 12:34:59 +0200 Nico Boehr <[email protected]> wrote:
KVM did not properly reset the no-translate bit after reset, see
https://lore.kernel.org/kvm/[email protected]/Add a test which performs a load normal reset (includes a subsystem reset) and verify that this clears the no-translate bit.
Signed-off-by Nico Boehr <[email protected]>
Reviewed-by Claudio Imbrenda <[email protected]>
Quoted 70 lines
--- s390x/cmm.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)s390x/cmm.c +34
-0@@ -9,13 +9,17 @@*/ #include <libcflat.h> +#include <bitops.h> #include <asm/asm-offsets.h> #include <asm/interrupt.h> #include <asm/page.h> #include <asm/cmm.h> +#include <asm/facility.h> static uint8_t pagebuf[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); +extern int diag308_load_reset (u64 ); +static void test_params (void ) {report_prefix_push ("invalid ORC 8" );@@ -35,6 +39,35 @@ static void test_priv(void)report_prefix_pop (); } +static void test_reset_no_translate (void ) +{ +const uint64_t mask_no_translate =BIT (63 -58 ); +unsigned long state; + +if (!test_facility (147 )) { +report_prefix_push ("no-translate unavailable" ); +expect_pgm_int (); +essa (ESSA_SET_STABLE_NODAT , (unsigned long )pagebuf); +check_pgm_int_code (PGM_INT_CODE_SPECIFICATION ); +report_prefix_pop (); +return ; + } + +report_prefix_push ("reset no-translate" ); +essa (ESSA_SET_STABLE_NODAT , (unsigned long )pagebuf); + + state =essa (ESSA_GET_STATE , (unsigned long )pagebuf); +report (state & mask_no_translate,"no-translate bit set before reset" ); + +/* Load normal reset - includes subsystem reset */ +diag308_load_reset (1 ); + + state =essa (ESSA_GET_STATE , (unsigned long )pagebuf); +report (!(state & mask_no_translate),"no-translate bit unset after reset" ); + +report_prefix_pop (); +} +int main (void ) {bool has_essa =check_essa_available ();@@ -47,6 +80,7 @@ int main(void)test_priv ();test_params (); +test_reset_no_translate (); done:report_prefix_pop ();return report_summary ();