Skip to contentSkip to conversation

fpga: re-enable KUnit test suites for the subsystem

PATCH In review Marco Pagani 2 participants 2 messages Apr 23, 2024 – Apr 26, 2024 FPGA manager framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fpga: re-enable KUnit test suites for the subsystem

The core components no longer assume that low-level modules register a driver for the parent device and use its owner pointer to take the module's refcount. KUnit test suites can now be safely re-enabled even with loadable module support.

This reverts commit a3fad2e92c76 ("fpga: disable KUnit test suites when module support is enabled")

---
 drivers/fpga/tests/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/tests/Kconfig +2 -2
index d4e55204c092..e4a64815f16d 100644
@@ -1,6 +1,6 @@
 config FPGA_KUNIT_TESTS
-	bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
-	depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n
+	tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
+	depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y
 	default KUNIT_ALL_TESTS
         help
           This builds unit tests for the FPGA subsystem

base-commit: b7c0e1ecee403a43abc89eb3e75672b01ff2ece9

Signature · 1 line
2.44.0
#1 lore raw
Quoted 7 lines · Marco Pagani

The core components no longer assume that low-level modules register a driver for the parent device and use its owner pointer to take the module's refcount. KUnit test suites can now be safely re-enabled even with loadable module support.

This reverts commit a3fad2e92c76 ("fpga: disable KUnit test suites when module support is enabled")

Don't wrap the commit reference.

Instead just keep the auto-generated shortlog & changelog auto-generated by "git revert", then follow your description about the change.

Thanks,
Yilun

Quoted 25 lines
---
 drivers/fpga/tests/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/tests/Kconfig +2 -2
index d4e55204c092..e4a64815f16d 100644
@@ -1,6 +1,6 @@
 config FPGA_KUNIT_TESTS
-	bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
-	depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n
+	tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS
+	depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y
 	default KUNIT_ALL_TESTS
         help
           This builds unit tests for the FPGA subsystem

base-commit: b7c0e1ecee403a43abc89eb3e75672b01ff2ece9

Signature · 1 line
2.44.0