ip: Exit exec in child process if setup fails
Subsystems (3)
PATCH 1/1 ip: Exit exec in child process if setup fails
If we forked, returning from the function will make the calling code to continue in both the child and parent process. Make cmd_exec exit if setup failed and it forked already.
An example of issues this causes, where a failure in setup causes multiple unnecessary tries:
``` $ ip netns ef ab $ ip -all netns exec ls netns: ef setting the network namespace "ef" failed: Operation not permitted netns: ab setting the network namespace "ab" failed: Operation not permitted netns: ab setting the network namespace "ab" failed: Operation not permitted ```
--- lib/exec.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
lib/exec.c +6 -1
@@ -36,8 +36,13 @@ int cmd_exec(const char *cmd, char **argv, bool do_fork, } } -if (setup &&setup (arg)) +if (setup &&setup (arg)) { +if (do_fork) { +/* In child, nothing to do */ +_exit (1 ); + }return -1 ; + }if (execvp (cmd, argv) <0 ) fprintf(stderr, "exec of \"%s\" failed: %s\n",
Signature · 1 line
2.34.1
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:
Hello:
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:
Quoted 8 lines · On Tue, 23 Apr 2024 21:38:20 +0300 you wrote:
If we forked, returning from the function will make the calling code to continue in both the child and parent process. Make
cmd_execexit if setup failed and it forked already.An example of issues this causes, where a failure in setup causes multiple unnecessary tries:
[...]
Here is the summary with links:
- ip: Exit exec in child process if setup fails
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=70ba338cd831
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html