Skip to contentSkip to conversation

usb: typec: tcpm: queue correct sop type in tcpm_queue_vdm_unlocked

PATCH In review RD Babiera 2 participants 2 messages Apr 23, 2024 – Apr 25, 2024

Subsystems (4)
lore
Share & tools
lore

RD Babiera

author
#0 lore raw

PATCH 1/1 usb: typec: tcpm: queue correct sop type in tcpm_queue_vdm_unlocked

tcpm_queue_vdm_unlocked queues VDMs over SOP regardless of input parameter tx_sop_type. Fix tcpm_queue_vdm() call.

Fixes 7e7877c55eb1 ("usb: typec: tcpm: add alt mode enter/exit/vdm support for sop'")

---
Patch applies starting at 6.9 tree.

---
 drivers/usb/typec/tcpm/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/typec/tcpm/tcpm.c +1 -1
index c26fb70c3ec6..3f38e7c7d13f 100644
@@ -1565,7 +1565,7 @@ static void tcpm_queue_vdm_unlocked(struct tcpm_port *port, const u32 header,
 				    const u32 *data, int cnt, enum tcpm_transmit_type tx_sop_type)
 {
 	mutex_lock(&port->lock);
-	tcpm_queue_vdm(port, header, data, cnt, TCPC_TX_SOP);
+	tcpm_queue_vdm(port, header, data, cnt, tx_sop_type);
 	mutex_unlock(&port->lock);
 }
 

base-commit: 684e9f5f97eb4b7831298ffad140d5c1d426ff27

Signature · 1 line
2.44.0.769.g3c40516874-goog
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · RD Babiera

tcpm_queue_vdm_unlocked queues VDMs over SOP regardless of input parameter tx_sop_type. Fix tcpm_queue_vdm() call.

Fixes 7e7877c55eb1 ("usb: typec: tcpm: add alt mode enter/exit/vdm support for sop'")
Quoted 23 lines

---
Patch applies starting at 6.9 tree.

---
 drivers/usb/typec/tcpm/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/typec/tcpm/tcpm.c +1 -1
index c26fb70c3ec6..3f38e7c7d13f 100644
@@ -1565,7 +1565,7 @@ static void tcpm_queue_vdm_unlocked(struct tcpm_port *port, const u32 header,
 				    const u32 *data, int cnt, enum tcpm_transmit_type tx_sop_type)
 {
 	mutex_lock(&port->lock);
-	tcpm_queue_vdm(port, header, data, cnt, TCPC_TX_SOP);
+	tcpm_queue_vdm(port, header, data, cnt, tx_sop_type);
 	mutex_unlock(&port->lock);
 }
 

base-commit: 684e9f5f97eb4b7831298ffad140d5c1d426ff27

Signature · 1 line
2.44.0.769.g3c40516874-goog
Signature · 1 line
heikki