Skip to contentSkip to conversation

drm/amdgpu: skip to create ras xxx_err_count node when ACA is enabled

PATCH In review Yang Wang 2 participants 2 messages Apr 24, 2024 – Apr 26, 2024

Subsystems (2)
lore
Share & tools
lore

Yang Wang

author
#0 lore raw

PATCH 1/1 drm/amdgpu: skip to create ras xxx_err_count node when ACA is enabled

skip to create 'xxx_err_count' node when ACA is enabled.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +6 -0
index 1e2b866751c3..96a8359b703b 100644
@@ -1756,6 +1756,9 @@ int amdgpu_ras_sysfs_create(struct amdgpu_device *adev,
 	if (!obj || obj->attr_inuse)
 		return -EINVAL;
 
+	if (amdgpu_aca_is_enabled(adev))
+		return 0;
+
 	get_obj(obj);
 
 	snprintf(obj->fs_data.sysfs_name, sizeof(obj->fs_data.sysfs_name),
@@ -1790,6 +1793,9 @@ int amdgpu_ras_sysfs_remove(struct amdgpu_device *adev,
 	if (!obj || !obj->attr_inuse)
 		return -EINVAL;
 
+	if (amdgpu_aca_is_enabled(adev))
+		return 0;
+
 	if (adev->dev->kobj.sd)
 		sysfs_remove_file_from_group(&adev->dev->kobj,
 				&obj->sysfs_attr.attr,
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - General]

[Tao] it's better to add comment to explain how to get error count when aca is enabled.

BTW, according to the change, do we need to update ras tool?

Quoted 44 lines

-----Original Message-----
From: Wang, Yang(Kevin) <[email protected]>
Sent: Wednesday, April 24, 2024 10:50 AM
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Zhou1, Tao <[email protected]>
Subject: [PATCH] drm/amdgpu: skip to create ras xxx_err_count node when ACA is enabled

skip to create 'xxx_err_count' node when ACA is enabled.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +3 -0
index 1e2b866751c3..96a8359b703b 100644
@@ -1756,6 +1756,9 @@ int amdgpu_ras_sysfs_create(struct amdgpu_device
 *adev,
      if (!obj || obj->attr_inuse)
              return -EINVAL;
 
+     if (amdgpu_aca_is_enabled(adev))
+             return 0;
+
      get_obj(obj);
 
      snprintf(obj->fs_data.sysfs_name, sizeof(obj->fs_data.sysfs_name), @@ -
1790,6 +1793,9 @@ int amdgpu_ras_sysfs_remove(struct amdgpu_device *adev,
      if (!obj || !obj->attr_inuse)
              return -EINVAL;
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +3 -1
+     if (amdgpu_aca_is_enabled(adev))
+             return 0;
+
      if (adev->dev->kobj.sd)
              sysfs_remove_file_from_group(&adev->dev->kobj,
                              &obj->sysfs_attr.attr,
--

2.34.1