drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc
Subsystems (2)
PATCH v2 4/4 drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc
Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x03000001.
V2: To really improve the handling we would actually
need to have a separate value of 0xffffffff.(Christian)
Signed-off-by Jesse Zhang <[email protected]>
Suggested-by Christian König <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c +2 -1
@@ -743,7 +743,8 @@ int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser *p,uint32_t created =0 ;uint32_t allocated =0 ;uint32_t tmp, handle =0 ; -uint32_t *size = &tmp; +uint32_t dummy =0xffffffff ; +uint32_t *size = &dummy;unsigned int idx;int i, r =0 ;
Signature · 1 line
2.25.1
Am 24.04.24 um 11:04 schrieb Jesse Zhang:
Quoted 6 lines
Initialize the size before calling
amdgpu_vce_cs_reloc, such as case0x03000001.
V2: To really improve the handling we would actuallyneed to have a separate value of 0xffffffff.(Christian)Signed-off-by Jesse Zhang <[email protected]>Suggested-by Christian König <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 18 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c +2
-1@@ -743,7 +743,8 @@ int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser *p,uint32_t created =0 ;uint32_t allocated =0 ;uint32_t tmp, handle =0 ; -uint32_t *size = &tmp; +uint32_t dummy =0xffffffff ; +uint32_t *size = &dummy;unsigned int idx;int i, r =0 ;