Skip to contentSkip to conversation

nvmet-auth: print an error message if the auth timeout expires

PATCH In review Maurizio Lombardi 2 participants 3 messages Apr 24, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvmet-auth: print an error message if the auth timeout expires

When the auth_expired_work fires, an error message should be printed to inform the user that the authentication is failing because of a timeout, so he doesn't get misleaded into thinking there is a bug in the auth code when seeing messages like the following:

nvmet: nvmet_execute_auth_send: ctrl 1 qid 2 step mismatch (2 != 0)
nvmet: nvmet_execute_auth_send: failure incorrect message.

---
 drivers/nvme/target/fabrics-cmd-auth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/target/fabrics-cmd-auth.c +2 -2
index eb7785be0ca7..7436ebda9f70 100644
@@ -17,8 +17,8 @@ static void nvmet_auth_expired_work(struct work_struct *work)
 	struct nvmet_sq *sq = container_of(to_delayed_work(work),
 			struct nvmet_sq, auth_expired_work);
 
-	pr_debug("%s: ctrl %d qid %d transaction %u expired, resetting\n",
-		 __func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
+	pr_err("%s: ctrl %d qid %d transaction %u expired, resetting\n",
+		__func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
 	sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE;
 	sq->dhchap_tid = -1;
 }
Signature · 1 line
2.39.3
#1 lore raw

Sorry, ignore this patch, this was a mistake.

This should stay as a debug message.

st 24. 4. 2024 v 12:25 odesílatel Maurizio Lombardi <[email protected]> napsal:

Quoted 33 lines

When the auth_expired_work fires, an error message should be printed to inform the user that the authentication is failing because of a timeout, so he doesn't get misleaded into thinking there is a bug in the auth code when seeing messages like the following:

nvmet: nvmet_execute_auth_send: ctrl 1 qid 2 step mismatch (2 != 0)
nvmet: nvmet_execute_auth_send: failure incorrect message.

---
 drivers/nvme/target/fabrics-cmd-auth.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/target/fabrics-cmd-auth.c +2 -3
index eb7785be0ca7..7436ebda9f70 100644
@@ -17,8 +17,8 @@ static void nvmet_auth_expired_work(struct work_struct *work)
        struct nvmet_sq *sq = container_of(to_delayed_work(work),
                        struct nvmet_sq, auth_expired_work);
 
-       pr_debug("%s: ctrl %d qid %d transaction %u expired, resetting\n",
-                __func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
+       pr_err("%s: ctrl %d qid %d transaction %u expired, resetting\n",
+               __func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
        sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE;
        sq->dhchap_tid = -1;
 }
--

2.39.3

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Maurizio Lombardi
Quoted 18 lines · Maurizio Lombardi

When the auth_expired_work fires, an error message should be printed to inform the user that the authentication is failing because of a timeout, so he doesn't get misleaded into thinking there is a bug in the auth code when seeing messages like the following:

nvmet: nvmet_execute_auth_send: ctrl 1 qid 2 step mismatch (2 != 0)
nvmet: nvmet_execute_auth_send: failure incorrect message.

---
  drivers/nvme/target/fabrics-cmd-auth.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/target/fabrics-cmd-auth.c +0 -0
index eb7785be0ca7..7436ebda9f70 100644

drivers/nvme/target/fabrics-cmd-auth.c static void nvmet_auth_expired_work(struct work_struct *work) · line 24

Quoted 10 lines
drivers/nvme/target/fabrics-cmd-auth.c +2 -2
@@ -17,8 +17,8 @@ static void nvmet_auth_expired_work(struct work_struct *work)
  	struct nvmet_sq *sq = container_of(to_delayed_work(work),
  			struct nvmet_sq, auth_expired_work);
 
-	pr_debug("%s: ctrl %d qid %d transaction %u expired, resetting\n",
-		 __func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
+	pr_err("%s: ctrl %d qid %d transaction %u expired, resetting\n",
+		__func__, sq->ctrl->cntlid, sq->qid, sq->dhchap_tid);
  	sq->dhchap_step = NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE;
  	sq->dhchap_tid = -1;
  }

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich