Skip to contentSkip to conversation

drm/amdgpu: fix the warning about the expression (int)size - len

PATCH In review Jesse Zhang 2 participants 2 messages Apr 25, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/amdgpu: fix the warning about the expression (int)size - len

Converting size from size_t to int may overflow.
v2: keep reverse xmas tree order (Christian)

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +2 -1
index f5d0fa207a88..eed60d4b3390 100644
@@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
 	struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
 	char reg_offset[11];
 	uint32_t *new = NULL, *tmp = NULL;
+	unsigned int len = 0;
 	int ret, i = 0, len = 0;
 
 	do {
 		memset(reg_offset, 0, 11);
 		if (copy_from_user(reg_offset, buf + len,
-					min(10, ((int)size-len)))) {
+					min(10, (size-len)))) {
 			ret = -EFAULT;
 			goto error_free;
 		}
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Am 25.04.24 um 09:11 schrieb Jesse Zhang:

Quoted 14 lines

Converting size from size_t to int may overflow.
v2: keep reverse xmas tree order (Christian)

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +0 -0
index f5d0fa207a88..eed60d4b3390 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c static ssize_t amdgpu_reset_dump_register_list_write(struct file *f, · line 2069

Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1 -0
@@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
  	struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
  	char reg_offset[11];
  	uint32_t *new = NULL, *tmp = NULL;
+	unsigned int len = 0;
  	int ret, i = 0, len = 0;

Well now you have len defined twice :)

Christian.

Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +1 -1
  	do {
  		memset(reg_offset, 0, 11);
  		if (copy_from_user(reg_offset, buf + len,
-					min(10, ((int)size-len)))) {
+					min(10, (size-len)))) {
  			ret = -EFAULT;
  			goto error_free;
  		}