Skip to contentSkip to conversation

drm/amdgpu: fix the warning about the expression (int)size - len

PATCH In review Jesse Zhang 2 participants 2 messages Apr 25, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: fix the warning about the expression (int)size - len

Converting size from size_t to int may overflow.
v2: keep reverse xmas tree order (Christian)

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +3 -2
index f5d0fa207a88..b62ae3c91a9d 100644
@@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
 	struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
 	char reg_offset[11];
 	uint32_t *new = NULL, *tmp = NULL;
-	int ret, i = 0, len = 0;
+	unsigned int len = 0;
+	int ret, i = 0;
 
 	do {
 		memset(reg_offset, 0, 11);
 		if (copy_from_user(reg_offset, buf + len,
-					min(10, ((int)size-len)))) {
+					min(10, (size-len)))) {
 			ret = -EFAULT;
 			goto error_free;
 		}
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jesse Zhang

Converting size from size_t to int may overflow.
v2: keep reverse xmas tree order (Christian)

Quoted 27 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c +3 -3
index f5d0fa207a88..b62ae3c91a9d 100644
@@ -2065,12 +2065,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f,
        struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private;
        char reg_offset[11];
        uint32_t *new = NULL, *tmp = NULL;
-       int ret, i = 0, len = 0;
+       unsigned int len = 0;
+       int ret, i = 0;
 
        do {
                memset(reg_offset, 0, 11);
                if (copy_from_user(reg_offset, buf + len,
-                                       min(10, ((int)size-len)))) {
+                                       min(10, (size-len)))) {
                        ret = -EFAULT;
                        goto error_free;
                }
--

2.25.1