svm: Fix MISRA 8.2 violation
PATCH 1/1 svm: Fix MISRA 8.2 violation
Misra 8.2 requires named parameters in prototypes. Use the name from the implementaiton.
Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit").
---
CC: Andrew Cooper <[email protected]>
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monne <[email protected]>
CC: Nicola Vetrini <[email protected]>
--- xen/arch/x86/include/asm/hvm/nestedhvm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
xen/arch/x86/include/asm/hvm/nestedhvm.h +2 -2
@@ -83,7 +83,7 @@ static inline bool vvmcx_valid(const struct vcpu *v) } -void start_nested_svm (struct hvm_function_table *); -void start_nested_vmx (struct hvm_function_table *); +void start_nested_svm (struct hvm_function_table *hvm_function_table); +void start_nested_vmx (struct hvm_function_table *hvm_function_table);#endif /* _HVM_NESTEDHVM_H */
Signature · 1 line
2.25.1
Quoted 6 lines · George Dunlap
Misra 8.2 requires named parameters in prototypes. Use the name from the implementaiton.
Fixes
0d19d3aab0("svm/nestedsvm: Introduce nested capabilities bit").Signed-off-by George Dunlap <[email protected]>
Quoted 4 lines · George Dunlap
Misra 8.2 requires named parameters in prototypes. Use the name from the implementaiton.
Fixes
0d19d3aab0("svm/nestedsvm: Introduce nested capabilities bit").
Nit. We treat Fixes: as a tag.
Also you might want to include the Reported-by's.
Otherwise, Acked-by: Andrew Cooper <[email protected]> although I have a strong wish to shorten the parameter name. That can be done at a later point.
~Andrew
Quoted 8 lines · Andrew Cooper
Quoted 4 lines · George Dunlap
Misra 8.2 requires named parameters in prototypes. Use the name from the implementaiton.
Fixes
0d19d3aab0("svm/nestedsvm: Introduce nested capabilities bit").Nit. We treat Fixes: as a tag.
Oops -- I'll fix that on check-in. Gmail is also underlining my misspelling of "implementation" in red, so I'll fix that as well.
Quoted 1 line
Also you might want to include the Reported-by's.
I thought about adding a Reported-by; but this was reported by Eclair, which is run automatically, right? We typically don't give a "Reported-by" to the person who flagged up the osstest or gitlab failure, so I figured this would be similar.
I'm happy to give credit where it's due, however. You were the first one who reported it to me, but Nicola also raised it; and I guess it's someone else who's paying for the Eclair runs. So what "Reported-by" did you have in mind?
Quoted 3 lines
Otherwise, Acked-by: Andrew Cooper <[email protected]> although I have a strong wish to shorten the parameter name. That can be done at a later point.
Thanks,
-George