drm/bridge: imx: Fix unmet depenency for PHY_FSL_SAMSUNG_HDMI_PHY
Subsystems (5)
PATCH v2 1/1 drm/bridge: imx: Fix unmet depenency for PHY_FSL_SAMSUNG_HDMI_PHY
When enabling i.MX8MP DWC HDMI driver, it automatically selects PHY_FSL_SAMSUNG_HDMI_PHY, since it wont' work without the phy. This may cause some Kconfig warnings during various build tests. Fix this by implying the phy instead of selecting the phy.
To prevent this from happening with the DRM_IMX8MP_HDMI_PVI, also imply it instead of selecting it.
---
V2: Change DRM_IMX8MP_HDMI_PVI at the same time since it was affected
from the same commit.
drivers/gpu/drm/bridge/imx/Kconfig +2 -2
@@ -8,8 +8,8 @@ config DRM_IMX8MP_DW_HDMI_BRIDGE depends on COMMON_CLK depends on DRM_DW_HDMI depends on OF - select DRM_IMX8MP_HDMI_PVI - select PHY_FSL_SAMSUNG_HDMI_PHY + imply DRM_IMX8MP_HDMI_PVI + imply PHY_FSL_SAMSUNG_HDMI_PHY help Choose this to enable support for the internal HDMI encoder found on the i.MX8MP SoC.
Signature · 1 line
2.43.0
Hi Adam,
Thank you for the patch.
Quoted 5 lines · Adam Ford
When enabling i.MX8MP DWC HDMI driver, it automatically selects
PHY_FSL_SAMSUNG_HDMI_PHY, since it wont' work without the phy. This may cause someKconfigwarnings during various build tests. Fix this by implying the phy instead of selecting the phy.
Quoted 7 lines
To prevent this from happening with the
DRM_IMX8MP_HDMI_PVI, also imply it instead of selecting it.Fixes 1f36d634670d ("drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI")Reported-by kernel test robot <[email protected]>Signed-off-by Adam Ford <[email protected]>
This looks sensible to me.
Quoted 19 lines
---
V2: ChangeDRM_IMX8MP_HDMI_PVIat the same time since it was affected
from the same commit.drivers/gpu/drm/bridge/imx/Kconfig +2
-2@@ -8,8 +8,8 @@ config DRM_IMX8MP_DW_HDMI_BRIDGE depends on COMMON_CLK depends on DRM_DW_HDMI depends on OF - select DRM_IMX8MP_HDMI_PVI - select PHY_FSL_SAMSUNG_HDMI_PHY + imply DRM_IMX8MP_HDMI_PVI + imply PHY_FSL_SAMSUNG_HDMI_PHY help Choose this to enable support for the internal HDMI encoder found on the i.MX8MP SoC.
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 9 lines · Adam Ford
When enabling i.MX8MP DWC HDMI driver, it automatically selects
PHY_FSL_SAMSUNG_HDMI_PHY, since it wont' work without the phy. This may cause someKconfigwarnings during various build tests. Fix this by implying the phy instead of selecting the phy.To prevent this from happening with the
DRM_IMX8MP_HDMI_PVI, also imply it instead of selecting it.[...]
Applied, thanks!
[1/1] drm/bridge: imx: Fix unmet depenency for PHY_FSL_SAMSUNG_HDMI_PHY
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=cbdbd9ca718e
Rob