Add support for Ethernet Boot on SK-AM62
Subsystems (6)
v2 cover Add support for Ethernet Boot on SK-AM62
This series enables Ethernet Boot on SK-AM62 device.
Link to v1:
https://lore.kernel.org/all/[email protected]/
Changes from v1 to v2:
- Updated dram_init_banksize() function to be called from common section instead of board specific function call as suggested by Tom.
- Dropped [PATCH 06/10] from this version since it was a clean up patch and not required for AM62x Ethernet Boot functionality.
- Removed independent defconfig files for R5 and A53 configs and created a config fragment for them as suggested by Nishanth.
- Added new patch [PATCH v2 10/10] in this series to enable CPSW MAC's PHY node "phy_gmii_sel" which is required for Ethernet Boot.
This changes are done as per discussion here:
https://lore.kernel.org/r/[email protected]/
Logs:
https://gist.github.com/chintanv133/07bcb1473301581aab6d4e951d9c6572
Chintan Vankar (2):
common: spl: spl: Init DRAM size in R5/A53 SPL
arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property
to phy_gmii_sel node
Kishon Vijay Abraham I (6):
firmware: ti_sci: Add No-OP for "RX_FL_CFG"
soc: ti: k3-navss-ringacc: Initialize base address of ring cfg
registers
dma: ti: k3-udma: Add support for native configuration of chan/flow
arm: mach-k3: am625_init: Probe AM65 CPSW NUSS
configs: am62: Add configs for enabling ETHBOOT in R5SPL
configs: am62: Enable configs required for Ethboot
Siddharth Vadapalli (1):
arm: dts: k3-am625-r5-sk: Enable DM services for main_pktdma
Vignesh Raghavendra (1):
soc: ti: k3-navss-ringacc: Fix reset ring API
arch/arm/dts/k3-am625-r5-sk.dts | 5 +++++ arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ arch/arm/mach-k3/am625_init.c | 10 ++++++++++ common/spl/spl.c | 2 +- configs/am62x_evm_a53_ethboot_defconfig | 11 +++++++++++ configs/am62x_evm_r5_ethboot_defconfig | 19 +++++++++++++++++++ drivers/dma/ti/k3-udma.c | 6 ++++++ drivers/firmware/ti_sci.c | 8 +++++++- drivers/soc/ti/k3-navss-ringacc-u-boot.c | 9 ++++++++- drivers/soc/ti/k3-navss-ringacc.c | 7 ++++++- 10 files changed, 77 insertions(+), 4 deletions(-) create mode 100644 configs/am62x_evm_a53_ethboot_defconfig create mode 100644 configs/am62x_evm_r5_ethboot_defconfig
Signature · 1 line
2.34.1
PATCH v2 1/10 common: spl: spl: Init DRAM size in R5/A53 SPL
Initialize DRAM size in SPL stage since networking requires DDR to be initialized.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- Updated dram_init_banksize() function to be called from common section instead of board specific function call as suggested by Tom.
common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl.c +1 -1
@@ -718,7 +718,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)initr_watchdog ();if (IS_ENABLED (CONFIG_SPL_OS_BOOT ) ||CONFIG_IS_ENABLED (HANDOFF ) || -IS_ENABLED (CONFIG_SPL_ATF )) +IS_ENABLED (CONFIG_SPL_ATF ) ||IS_ENABLED (CONFIG_SPL_NET ))dram_init_banksize ();if (CONFIG_IS_ENABLED (PCI ) && !(gd->flags &GD_FLG_DM_DEAD )) {
Signature · 1 line
2.34.1
PATCH v2 2/10 firmware: ti_sci: Add No-OP for "RX_FL_CFG"
In reply to Chintan VankarFrom: Kishon Vijay Abraham I <[email protected]>
RX_FL_CFG message should not be forwarded to TIFS and should be handled within R5 SPL (when DM services are not available). Add a no-op function to not handle RX_FL_CFG messages.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- No changes.
drivers/firmware/ti_sci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/firmware/ti_sci.c +7 -1
@@ -2452,6 +2452,12 @@ fail:return ret; } +static int ti_sci_cmd_rm_udmap_rx_flow_cfg_noop (const struct ti_sci_handle *handle, +const struct ti_sci_msg_rm_udmap_flow_cfg *params) +{ +return 0 ; +} +/** * ti_sci_cmd_set_fwl_region() - Request for configuring a firewall region * @handle: pointer to TI SCI handle
@@ -2897,7 +2903,7 @@ static __maybe_unused int ti_sci_dm_probe(struct udevice *dev) udmap_ops = &ops->rm_udmap_ops; udmap_ops->tx_ch_cfg = ti_sci_cmd_rm_udmap_tx_ch_cfg; udmap_ops->rx_ch_cfg = ti_sci_cmd_rm_udmap_rx_ch_cfg; - udmap_ops->rx_flow_cfg = ti_sci_cmd_rm_udmap_rx_flow_cfg; + udmap_ops->rx_flow_cfg = ti_sci_cmd_rm_udmap_rx_flow_cfg_noop;return ret; }
Signature · 1 line
2.34.1
PATCH v2 3/10 soc: ti: k3-navss-ringacc: Initialize base address of ring cfg registers
In reply to Chintan VankarFrom: Kishon Vijay Abraham I <[email protected]>
Initialize base address of ring config registers required to natively setup ring cfg registers in the absence of Device Manager (DM) services at R5 SPL stage.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- No changes.
drivers/soc/ti/k3-navss-ringacc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/soc/ti/k3-navss-ringacc.c +6 -1
@@ -1030,8 +1030,8 @@ static int k3_nav_ringacc_init(struct udevice *dev, struct k3_nav_ringacc *ringastruct k3_nav_ringacc *k3_ringacc_dmarings_init (struct udevice *dev,struct k3_ringacc_init_data *data) { +void __iomem *base_rt, *base_cfg;struct k3_nav_ringacc *ringacc; -void __iomem *base_rt;int i; ringacc =devm_kzalloc (dev,sizeof (*ringacc),GFP_KERNEL );
@@ -1049,6 +1049,10 @@ struct k3_nav_ringacc *k3_ringacc_dmarings_init(struct udevice *dev,if (!base_rt)return ERR_PTR (-EINVAL ); + base_cfg =dev_read_addr_name_ptr (dev,"cfg" ); +if (!base_cfg) +return ERR_PTR (-EINVAL ); + ringacc->rings = devm_kzalloc(dev, sizeof(*ringacc->rings) * ringacc->num_rings * 2,
@@ -1063,6 +1067,7 @@ struct k3_nav_ringacc *k3_ringacc_dmarings_init(struct udevice *dev,for (i =0 ; i < ringacc->num_rings; i++) {struct k3_nav_ring *ring = &ringacc->rings[i]; + ring->cfg = base_cfg +KNAV_RINGACC_CFG_REGS_STEP * i; ring->rt = base_rt +K3_DMARING_RING_RT_REGS_STEP * i; ring->parent = ringacc; ring->ring_id = i;
Signature · 1 line
2.34.1
PATCH v2 4/10 soc: ti: k3-navss-ringacc: Fix reset ring API
In reply to Chintan VankarFrom: Vignesh Raghavendra <[email protected]>
Expectation of k3_ringacc_ring_reset_raw() is to reset the ring to requested size and not to 0. Fix this.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- No changes.
drivers/soc/ti/k3-navss-ringacc-u-boot.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/soc/ti/k3-navss-ringacc-u-boot.c +8 -1
@@ -25,9 +25,16 @@ struct k3_nav_ring_cfg_regs {#define KNAV_RINGACC_CFG_RING_SIZE_ELSIZE_MASK GENMASK(26, 24)#define KNAV_RINGACC_CFG_RING_SIZE_ELSIZE_SHIFT (24) +#define KNAV_RINGACC_CFG_RING_SIZE_MASK GENMASK(15, 0) +static void k3_ringacc_ring_reset_raw (struct k3_nav_ring *ring) { -writel (0 , &ring->cfg->size); +u32 reg; + + reg =readl (&ring->cfg->size); + reg &=KNAV_RINGACC_CFG_RING_SIZE_MASK ; + reg |= ring->size; +writel (reg, &ring->cfg->size); }static void k3_ringacc_ring_reconfig_qmode_raw (struct k3_nav_ring *ring,enum k3_nav_ring_mode mode)
Signature · 1 line
2.34.1
PATCH v2 5/10 dma: ti: k3-udma: Add support for native configuration of chan/flow
In reply to Chintan VankarFrom: Kishon Vijay Abraham I <[email protected]>
In absence of Device Manager (DM) services such as at R5 SPL stage, driver will have to natively setup TCHAN/RCHAN/RFLOW cfg registers. Existing UDMA driver performed the above mentioned configuration for UDMA. Add similar configuration for PKTDMA here.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- No changes.
drivers/dma/ti/k3-udma.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/dma/ti/k3-udma.c +6 -0
@@ -2119,6 +2119,9 @@ static int bcdma_tisci_tx_channel_config(struct udma_chan *uc)if (ret)dev_err (ud->dev,"tchan%d cfg failed %d\n" , tchan->id, ret); +if (IS_ENABLED (CONFIG_K3_DM_FW )) +udma_alloc_tchan_raw (uc); +return ret; }
@@ -2167,6 +2170,9 @@ static int pktdma_tisci_rx_channel_config(struct udma_chan *uc)dev_err (ud->dev,"flow%d config failed: %d\n" , uc->rflow->id, ret); +if (IS_ENABLED (CONFIG_K3_DM_FW )) +udma_alloc_rchan_raw (uc); +return ret; }
Signature · 1 line
2.34.1
PATCH v2 6/10 arm: mach-k3: am625_init: Probe AM65 CPSW NUSS
In reply to Chintan VankarFrom: Kishon Vijay Abraham I <[email protected]>
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in board_init_f().
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- No changes.
arch/arm/mach-k3/am625_init.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/mach-k3/am625_init.c +10 -0
@@ -277,6 +277,16 @@ void board_init_f(ulong dummy)if (ret)panic ("DRAM init failed: %d\n" , ret); } + +if (IS_ENABLED (CONFIG_SPL_ETH ) &&IS_ENABLED (CONFIG_TI_AM65_CPSW_NUSS ) && +spl_boot_device () ==BOOT_DEVICE_ETHERNET ) { +struct udevice *cpswdev; + +if (uclass_get_device_by_driver (UCLASS_MISC ,DM_DRIVER_GET (am65_cpsw_nuss), + &cpswdev)) +printf ("Failed to probe am65_cpsw_nuss driver\n" ); + } +spl_enable_cache ();fixup_a53_cpu_freq_by_speed_grade ();
Signature · 1 line
2.34.1
Re: [PATCH v2 06/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS
Quoted 27 lines · Chintan Vankar
From: Kishon Vijay Abraham I <[email protected]>
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in
board_init_f().Signed-off-by Kishon Vijay Abraham I <[email protected]>Signed-off-by Siddharth Vadapalli <[email protected]>Signed-off-by Chintan Vankar <[email protected]>---
Link to v1:
https://lore.kernel.org/r/[email protected]/Changes from v1 to v2:
- No changes.arch/arm/mach-k3/am625_init.c | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/mach-k3/am625_init.c +0
-0@@ -277,6 +277,16 @@ void board_init_f(ulong dummy)if (ret)panic ("DRAM init failed: %d\n" , ret); }
arch/arm/mach-k3/am625_init.c void board_init_f(ulong dummy) · line 289
Quoted 10 lines
arch/arm/mach-k3/am625_init.c +10
-0+ +if (IS_ENABLED (CONFIG_SPL_ETH ) &&IS_ENABLED (CONFIG_TI_AM65_CPSW_NUSS ) && +spl_boot_device () ==BOOT_DEVICE_ETHERNET ) { +struct udevice *cpswdev; + +if (uclass_get_device_by_driver (UCLASS_MISC ,DM_DRIVER_GET (am65_cpsw_nuss), + &cpswdev)) +printf ("Failed to probe am65_cpsw_nuss driver\n" ); + } +
This looks like a HACK.
The network driver should be probed only when the networking feature is actually required.
Quoted 3 lines
arch/arm/mach-k3/am625_init.c +0
-0spl_enable_cache ();fixup_a53_cpu_freq_by_speed_grade ();
Signature · 2 lines
cheers, -roger
Re: [PATCH v2 06/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS
Quoted 35 lines · Roger Quadros
Quoted 32 lines · Chintan Vankar
From: Kishon Vijay Abraham I <[email protected]>
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in
board_init_f().Signed-off-by Kishon Vijay Abraham I <[email protected]>Signed-off-by Siddharth Vadapalli <[email protected]>Signed-off-by Chintan Vankar <[email protected]>---
Link to v1:
https://lore.kernel.org/r/[email protected]/Changes from v1 to v2:
- No changes.arch/arm/mach-k3/am625_init.c | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/mach-k3/am625_init.c +5
-0@@ -277,6 +277,16 @@ void board_init_f(ulong dummy)if (ret)panic ("DRAM init failed: %d\n" , ret); } + +if (IS_ENABLED (CONFIG_SPL_ETH ) &&IS_ENABLED (CONFIG_TI_AM65_CPSW_NUSS ) && +spl_boot_device () ==BOOT_DEVICE_ETHERNET ) { +struct udevice *cpswdev; +
Quoted 9 lines
arch/arm/mach-k3/am625_init.c void board_init_f(ulong dummy) · line 289
Quoted 5 lines
arch/arm/mach-k3/am625_init.c +5
-0+if (uclass_get_device_by_driver (UCLASS_MISC ,DM_DRIVER_GET (am65_cpsw_nuss), + &cpswdev)) +printf ("Failed to probe am65_cpsw_nuss driver\n" ); + } +This looks like a HACK.
The network driver should be probed only when the networking feature is actually required.
Driver is probed only when the condition above "spl_boot_device() == BOOT_DEVICE_ETHERNET" is true, which says Boot device is Ethernet, and here we are booting with Ethernet so driver is getting probed.
Quoted 4 lines
Quoted 3 lines
arch/arm/mach-k3/am625_init.c +0
-0spl_enable_cache ();fixup_a53_cpu_freq_by_speed_grade ();
Re: [PATCH v2 06/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS
Quoted 48 lines · Chintan Vankar
Quoted 35 lines · Roger Quadros
Quoted 32 lines · Chintan Vankar
From: Kishon Vijay Abraham I <[email protected]>
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in
board_init_f().Signed-off-by Kishon Vijay Abraham I <[email protected]>Signed-off-by Siddharth Vadapalli <[email protected]>Signed-off-by Chintan Vankar <[email protected]>---
Link to v1:
https://lore.kernel.org/r/[email protected]/Changes from v1 to v2:
- No changes.
arch/arm/mach-k3/am625_init.c| 10 ++++++++++1 file changed, 10 insertions(+)arch/arm/mach-k3/am625_init.c +5
-0@@ -277,6 +277,16 @@ void board_init_f(ulong dummy) if (ret) panic("DRAM init failed: %d\n", ret); } + + if (IS_ENABLED(CONFIG_SPL_ETH) && IS_ENABLED(CONFIG_TI_AM65_CPSW_NUSS) && + spl_boot_device() == BOOT_DEVICE_ETHERNET) { + struct udevice *cpswdev; +Quoted 9 lines
arch/arm/mach-k3/am625_init.c void board_init_f(ulong dummy) · line 289
Quoted 5 lines
arch/arm/mach-k3/am625_init.c +5
-0+ if (uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(am65_cpsw_nuss), + &cpswdev)) + printf("Failed to probe am65_cpsw_nuss driver\n"); + } +This looks like a HACK.
The network driver should be probed only when the networking feature is actually required.
Quoted 4 lines
Driver is probed only when the condition above "
spl_boot_device()==BOOT_DEVICE_ETHERNET" is true, which says Boot device is Ethernet, and here we are booting with Ethernet so driver is getting probed.
I think you misunderstood what I was saying as am625_init.c is not using any Ethernet function it should not cause the Ethernet driver to probe.
Instead it should be probed by the networking use case.
What happens if you don't use this patch? Where is it failing?
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
arch/arm/mach-k3/am625_init.c +0
-0spl_enable_cache(); fixup_a53_cpu_freq_by_speed_grade();
Signature · 2 lines
cheers, -roger
Re: [PATCH v2 06/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS
Quoted 56 lines · Roger Quadros
Quoted 48 lines · Chintan Vankar
Quoted 35 lines · Roger Quadros
Quoted 32 lines · Chintan Vankar
From: Kishon Vijay Abraham I <[email protected]>
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in
board_init_f().Signed-off-by Kishon Vijay Abraham I <[email protected]>Signed-off-by Siddharth Vadapalli <[email protected]>Signed-off-by Chintan Vankar <[email protected]>---
Link to v1:
https://lore.kernel.org/r/[email protected]/Changes from v1 to v2:
- No changes.arch/arm/mach-k3/am625_init.c | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/mach-k3/am625_init.c +5
-0@@ -277,6 +277,16 @@ void board_init_f(ulong dummy) if (ret) panic("DRAM init failed: %d\n", ret); } + + if (IS_ENABLED(CONFIG_SPL_ETH) && IS_ENABLED(CONFIG_TI_AM65_CPSW_NUSS) && + spl_boot_device() == BOOT_DEVICE_ETHERNET) { + struct udevice *cpswdev; +Quoted 9 lines
arch/arm/mach-k3/am625_init.c void board_init_f(ulong dummy) · line 289
Quoted 5 lines
arch/arm/mach-k3/am625_init.c +5
-0+ if (uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(am65_cpsw_nuss), + &cpswdev)) + printf("Failed to probe am65_cpsw_nuss driver\n"); + } +This looks like a HACK.
The network driver should be probed only when the networking feature is actually required.Quoted 4 lines
Driver is probed only when the condition above "
spl_boot_device()==BOOT_DEVICE_ETHERNET" is true, which says Boot device is Ethernet, and here we are booting with Ethernet so driver is getting probed.
Quoted 7 lines
I think you misunderstood what I was saying as
am625_init.cis not using any Ethernet function it should not cause the Ethernet driver to probe.Instead it should be probed by the networking use case.
What happens if you don't use this patch? Where is it failing?
You are correct that it should be probed by the networking use case and we are using networking functionality of "Booting via Ethernet". Regarding its probing, I already had discussion that why do I have to probe it explicitly at here:
https://lore.kernel.org/r/[email protected]/
Now if I don't use this patch then Ethernet will not get initialized at SPL stage, and in "spl_net_load_image()" function, there will be an error saying "No Ethernet Found", and since we selected booting via Ethernet it will fail to boot.
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
arch/arm/mach-k3/am625_init.c +0
-0spl_enable_cache(); fixup_a53_cpu_freq_by_speed_grade();
Re: [PATCH v2 06/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS
Quoted 73 lines · Chintan Vankar
Quoted 56 lines · Roger Quadros
Quoted 48 lines · Chintan Vankar
Quoted 35 lines · Roger Quadros
Quoted 32 lines · Chintan Vankar
From: Kishon Vijay Abraham I <[email protected]>
In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS driver in
board_init_f().Signed-off-by Kishon Vijay Abraham I <[email protected]>Signed-off-by Siddharth Vadapalli <[email protected]>Signed-off-by Chintan Vankar <[email protected]>---
Link to v1:
https://lore.kernel.org/r/[email protected]/Changes from v1 to v2:
- No changes.
arch/arm/mach-k3/am625_init.c| 10 ++++++++++1 file changed, 10 insertions(+)arch/arm/mach-k3/am625_init.c +5
-0@@ -277,6 +277,16 @@ void board_init_f(ulong dummy) if (ret) panic("DRAM init failed: %d\n", ret); } + + if (IS_ENABLED(CONFIG_SPL_ETH) && IS_ENABLED(CONFIG_TI_AM65_CPSW_NUSS) && + spl_boot_device() == BOOT_DEVICE_ETHERNET) { + struct udevice *cpswdev; +Quoted 9 lines
arch/arm/mach-k3/am625_init.c void board_init_f(ulong dummy) · line 289
Quoted 5 lines
arch/arm/mach-k3/am625_init.c +5
-0+ if (uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(am65_cpsw_nuss), + &cpswdev)) + printf("Failed to probe am65_cpsw_nuss driver\n"); + } +This looks like a HACK.
The network driver should be probed only when the networking feature is actually required.Quoted 4 lines
Driver is probed only when the condition above "
spl_boot_device()==BOOT_DEVICE_ETHERNET" is true, which says Boot device is Ethernet, and here we are booting with Ethernet so driver is getting probed.Quoted 7 lines
I think you misunderstood what I was saying as
am625_init.cis not using any Ethernet function it should not cause the Ethernet driver to probe.Instead it should be probed by the networking use case.
What happens if you don't use this patch? Where is it failing?
You are correct that it should be probed by the networking use case and we are using networking functionality of "Booting via Ethernet". Regarding its probing, I already had discussion that why do I have to probe it explicitly at here:
https://lore.kernel.org/r/[email protected]/
Quoted 4 lines
Now if I don't use this patch then Ethernet will not get initialized at SPL stage, and in "
spl_net_load_image()" function, there will be an error saying "No Ethernet Found", and since we selected booting via Ethernet it will fail to boot.
OK Now I see the problem.
in am65-cpsw-nuss.c the following is defined:
Quoted 9 lines
U_BOOT_DRIVER(am65_cpsw_nuss) = { .name = "am65_cpsw_nuss", .id = UCLASS_MISC, .of_match = am65_cpsw_nuss_ids, .probe = am65_cpsw_probe_nuss, .priv_auto = sizeof(struct am65_cpsw_common), };
U_BOOT_DRIVER(am65_cpsw_nuss_port)= {
Quoted 8 lines
.name = "am65_cpsw_nuss_port", .id = UCLASS_ETH, .probe = am65_cpsw_port_probe, .ops = &am65_cpsw_ops,.priv_auto =
sizeof(struct am65_cpsw_priv),
.plat_auto =sizeof(struct eth_pdata),
.flags =DM_FLAG_ALLOC_PRIV_DMA|DM_FLAG_OS_PREPARE,
};
Now I suppose spl_net_load_image() tries to probe all UCLASS_ETH devices which should call am65_cpsw_port_probe() but it fails to probe am65_cpsw_probe_nuss().
This limitation was introduced by commit38922b1f4acc ("net: ti: am65-cpsw: Add support for multi port independent MAC mode")
which says "Since top level driver is now UCLASS_MISC, board files would need to instantiate this driver explicitly.
I wonder if there can be a better solution to this?
Signature · 2 lines
cheers, -roger
PATCH v2 7/10 configs: am62: Add configs for enabling ETHBOOT in R5SPL
In reply to Chintan VankarFrom: Kishon Vijay Abraham I <[email protected]>
Add configs for enabling ETHBOOT in R5SPL.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- Removed independent defconfig files for R5 configs and created a config fragment for them as suggested by Nishanth.
configs/am62x_evm_r5_ethboot_defconfig | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 configs/am62x_evm_r5_ethboot_defconfig
configs/am62x_evm_r5_ethboot_defconfig new file +19 -0
@@ -0,0 +1,19 @@ +#include<configs/am62x_evm_r5_defconfig> + +CONFIG_SPL_GPIO=y +CONFIG_SPL_MMC=n +CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x200000 +CONFIG_SPL_DMA=y +CONFIG_SPL_ENV_SUPPORT=y +CONFIG_SPL_ETH=y +CONFIG_SPL_I2C=y +CONFIG_SPL_NET=y +CONFIG_SPL_NET_VCI_STRING="AM62X U-Boot R5 SPL" +CONFIG_CMD_DHCP=y +CONFIG_SPL_SYSCON=y +CONFIG_DMA_CHANNELS=y +CONFIG_TI_K3_NAVSS_UDMA=y +CONFIG_DM_I2C=y +CONFIG_PHY_TI_DP83867=y +CONFIG_TI_AM65_CPSW_NUSS=y
Signature · 1 line
2.34.1
PATCH v2 8/10 configs: am62: Enable configs required for Ethboot
In reply to Chintan VankarFrom: Kishon Vijay Abraham I <[email protected]>
Enable config options needed to support Ethernet boot on AM62x SK.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- Removed independent defconfig files for A53 configs and created a config fragment for them as suggested by Nishanth.
configs/am62x_evm_a53_ethboot_defconfig | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 configs/am62x_evm_a53_ethboot_defconfig
configs/am62x_evm_a53_ethboot_defconfig new file +11 -0
@@ -0,0 +1,11 @@ +#include <configs/am62x_evm_a53_defconfig> + +CONFIG_SPL_STACK_R_ADDR=0x83000000 +CONFIG_SPL_DRIVERS_MISC=y +CONFIG_SPL_BOARD_INIT=y +CONFIG_SPL_DMA=y +CONFIG_SPL_ENV_SUPPORT=y +CONFIG_SPL_ETH=y +CONFIG_SPL_NET=y +CONFIG_SPL_NET_VCI_STRING="AM62X U-Boot A53 SPL" +CONFIG_SPL_SYSCON=y
Signature · 1 line
2.34.1
PATCH v2 9/10 arm: dts: k3-am625-r5-sk: Enable DM services for main_pktdma
In reply to Chintan VankarFrom: Siddharth Vadapalli <[email protected]>
Enable DM services for main_pktdma during R5 SPL stage.
---
Link to v1:
https://lore.kernel.org/r/[email protected]/
Changes from v1 to v2:
- No changes.
arch/arm/dts/k3-am625-r5-sk.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/dts/k3-am625-r5-sk.dts +5 -0
@@ -83,3 +83,8 @@ reg = <0x00 0x0fc40000 0x00 0x100>, <0x00 0x60000000 0x00 0x08000000>; }; + +&main_pktdma { + ti,sci = <&dm_tifs>; + bootph-all; +};
Signature · 1 line
2.34.1
PATCH v2 10/10 arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property to phy_gmii_sel node
In reply to Chintan VankarAdd "bootph-all" property to CPSW MAC's PHY node phy_gmii_sel.
---
Changes from v1 to v2:
- This patch is newly added in this series to enable CPSW MAC's PHY node "phy_gmii_sel". As per discussion at here:
https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/
changes made by this patch can be dropped in the future when the DT-Sync is performed with am62-main.dtsi containing this change in the Linux DT which will match U-Boot's DT.
arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/dts/k3-am625-sk-u-boot.dtsi +4 -0
@@ -46,3 +46,7 @@ &cpsw_port2 { status = "disabled"; }; + +&phy_gmii_sel { + bootph-all; +};
Signature · 1 line
2.34.1
Re: [PATCH v2 10/10] arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property to phy_gmii_sel node
Quoted 5 lines · Chintan Vankar
Add "bootph-all" property to CPSW MAC's PHY node
phy_gmii_sel.Signed-off-by Chintan Vankar <[email protected]>---
Quoted 7 lines
Changes from v1 to v2:
- This patch is newly added in this series to enable CPSW MAC's PHY node "phy_gmii_sel". As per discussion at here:
https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/
changes made by this patch can be dropped in the future when the DT-Sync is performed witham62-main.dtsicontaining this change in the Linux DT which will match U-Boot's DT.
I don't think bootph-all exists in am62-main.dtsi. It should come from board.dts
Quoted 16 lines
arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/dts/k3-am625-sk-u-boot.dtsi +4
-0@@ -46,3 +46,7 @@ &cpsw_port2 { status = "disabled"; }; + +&phy_gmii_sel { + bootph-all; +};
Signature · 2 lines
cheers, -roger
Re: [PATCH v2 10/10] arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property to phy_gmii_sel node
Quoted 16 lines · Roger Quadros
Quoted 5 lines · Chintan Vankar
Add "bootph-all" property to CPSW MAC's PHY node
phy_gmii_sel.Signed-off-by Chintan Vankar <[email protected]>---
Quoted 7 lines
Changes from v1 to v2:
- This patch is newly added in this series to enable CPSW MAC's PHY node "phy_gmii_sel". As per discussion at here:
https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/
changes made by this patch can be dropped in the future when the DT-Sync is performed witham62-main.dtsicontaining this change in the Linux DT which will match U-Boot's DT.
Quoted 3 lines
I don't think bootph-all exists in
am62-main.dtsi. It should come fromboard.dts
Yes, I am having the same discussion at here:
https://lore.kernel.org/all/[email protected]/
Quoted 17 lines
Quoted 16 lines
arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/dts/k3-am625-sk-u-boot.dtsi +4
-0@@ -46,3 +46,7 @@ &cpsw_port2 { status = "disabled"; }; + +&phy_gmii_sel { + bootph-all; +};
Re: [PATCH v2 10/10] arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property to phy_gmii_sel node
Quoted 19 lines · Chintan Vankar
Quoted 16 lines · Roger Quadros
Quoted 12 lines · Chintan Vankar
Add "bootph-all" property to CPSW MAC's PHY node
phy_gmii_sel.Signed-off-by Chintan Vankar <[email protected]>---
Changes from v1 to v2:
- This patch is newly added in this series to enable CPSW MAC's PHY node "phy_gmii_sel". As per discussion at here:
https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/
changes made by this patch can be dropped in the future when the DT-Sync is performed witham62-main.dtsicontaining this change in the Linux DT which will match U-Boot's DT.
Quoted 7 lines
Quoted 3 lines
I don't think bootph-all exists in
am62-main.dtsi. It should come fromboard.dtsYes, I am having the same discussion at here:
https://lore.kernel.org/all/[email protected]/
Since I have posted patch which adds bootph-all property to "k3-am62x-sk-common.dtsi" at here:
https://lore.kernel.org/r/[email protected]/
and it has no open comments and this series
also does not have any open comments, so can it be merged ?
Quoted 17 lines
Quoted 17 lines
Quoted 16 lines
arch/arm/dts/k3-am625-sk-u-boot.dtsi| 4 ++++1 file changed, 4 insertions(+)arch/arm/dts/k3-am625-sk-u-boot.dtsi +4
-0@@ -46,3 +46,7 @@ &cpsw_port2 { status = "disabled"; }; + +&phy_gmii_sel { + bootph-all; +};
Re: [PATCH v2 10/10] arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property to phy_gmii_sel node
Quoted 30 lines · Chintan Vankar
Quoted 19 lines · Chintan Vankar
Quoted 16 lines · Roger Quadros
Quoted 12 lines · Chintan Vankar
Add "bootph-all" property to CPSW MAC's PHY node
phy_gmii_sel.Signed-off-by Chintan Vankar <[email protected]>---
Changes from v1 to v2:
- This patch is newly added in this series to enable CPSW MAC's PHY node "phy_gmii_sel". As per discussion at here:
https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/
changes made by this patch can be dropped in the future when the DT-Sync is performed witham62-main.dtsicontaining this change in the Linux DT which will match U-Boot's DT.Quoted 7 lines
Quoted 3 lines
I don't think bootph-all exists in
am62-main.dtsi. It should come fromboard.dtsYes, I am having the same discussion at here:
https://lore.kernel.org/all/[email protected]/
Quoted 5 lines
Since I have posted patch which adds bootph-all property to "
k3-am62x-sk-common.dtsi" at here:
https://lore.kernel.org/r/[email protected]/
and it has no open comments and this series
also does not have any open comments, so can it be merged ?
Since bootph-all is being added to k3-am62x-sk-common.dtsi don't you have to drop patch 10 from this series?
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
arch/arm/dts/k3-am625-sk-u-boot.dtsi| 4 ++++1 file changed, 4 insertions(+)arch/arm/dts/k3-am625-sk-u-boot.dtsi +4
-0@@ -46,3 +46,7 @@ &cpsw_port2 { status = "disabled"; }; + +&phy_gmii_sel { + bootph-all; +};
Signature · 2 lines
cheers, -roger
Re: [PATCH v2 10/10] arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property to phy_gmii_sel node
Quoted 33 lines · Roger Quadros
Quoted 30 lines · Chintan Vankar
Quoted 26 lines · Chintan Vankar
Quoted 16 lines · Roger Quadros
Quoted 5 lines · Chintan Vankar
Add "bootph-all" property to CPSW MAC's PHY node
phy_gmii_sel.Signed-off-by Chintan Vankar <[email protected]>---
Quoted 7 lines
Changes from v1 to v2:
- This patch is newly added in this series to enable CPSW MAC's PHY node "phy_gmii_sel". As per discussion at here:
https://lore.kernel.org/r/20240112130127.rvvrhz7p4vmlyalh@smother/
changes made by this patch can be dropped in the future when the DT-Sync is performed witham62-main.dtsicontaining this change in the Linux DT which will match U-Boot's DT.Quoted 3 lines
I don't think bootph-all exists in
am62-main.dtsi. It should come fromboard.dtsYes, I am having the same discussion at here:
https://lore.kernel.org/all/[email protected]/
Quoted 9 lines
Quoted 5 lines
Since I have posted patch which adds bootph-all property to "
k3-am62x-sk-common.dtsi" at here:
https://lore.kernel.org/r/[email protected]/
and it has no open comments and this series
also does not have any open comments, so can it be merged ?Since bootph-all is being added to
k3-am62x-sk-common.dtsidon't you have to drop patch 10 from this series?
Yes you are correct, but that patch is not merged yet.
Quoted 19 lines
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
arch/arm/dts/k3-am625-sk-u-boot.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/dts/k3-am625-sk-u-boot.dtsi +4
-0@@ -46,3 +46,7 @@ &cpsw_port2 { status = "disabled"; }; + +&phy_gmii_sel { + bootph-all; +};